GithubHelp home page GithubHelp logo

Comments (4)

agrover avatar agrover commented on July 17, 2024

This is a change we made to give the caller a chance to do something when an exception occurs, instead of swallowing the exception internally. You can look at the changes in targetcli-fb's script:

    while not shell._exit:
        try:
            shell.run_interactive()
        except (RTSLibError, ExecutionError) as msg:
            shell.log.error(str(msg))

basically just handling the exception (if desired) and then re-invoking the shell if an explicit exit command has not been given.

from configshell-fb.

iavael avatar iavael commented on July 17, 2024

Ok, I agree that catching this exception is necessary. But if shell initialization is heavy it may be reasonable to let user catch exception closer to it's raise, so that there would be no need to reinitialize shell context.

from configshell-fb.

agrover avatar agrover commented on July 17, 2024

It's just re-invoking run_interactive, which is not a big deal as far as I can tell.

from configshell-fb.

iavael avatar iavael commented on July 17, 2024

Ok, I've got it, thanks for your help.

from configshell-fb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.