open-keychain / open-keychain Goto Github PK

• use aidl api
• optimze encryption based on space

When importing a secret key, only the secret part is imported. After editing and saving the key ring the public part is generated again.

-> Fix import by also adding the public part after importing.

see http://nelenkov.blogspot.com.es/2012/05/storing-application-secrets-in-androids.html

Other apps should use new api

use SearchView

JakeWharton/ActionBarSherlock#70

progress in progressdialog when importing keyrings stops at 84% and then goes on...

Look into send key, sign key by senecaso: How are they implemented?

Use sliding menu?

https://github.com/jfeinstein10/SlidingMenu

Lookup key when unknown key is encountered when verifying sig not working

• KeyServerQueryActivity should return something that is used in onActivityResult in DecryptActivity

I've compiled successfully APG, but when I run it in the emulator and try to click on "Manage Keys" I get an exception telling me an unkown URI was passed (content://org.thialfihar.android.apg.internal/key_rings/public), the exception is coded in the line 544 of the file /org.thialfihar.android.apg.ui.MainActivity/src/org/thialfihar/android/apg/provider/ApgProvider.java:

default: throw new IllegalArgumentException("Unknown URI " + uri);

The same exception is thrown when I click on the "My Keys" icon.

The trace is the following one:
11-18 21:44:19.618: W/dalvikvm(534): threadid=11: thread exiting with uncaught exception (group=0x409c01f8)
11-18 21:44:19.668: E/AndroidRuntime(534): FATAL EXCEPTION: ModernAsyncTask #1
11-18 21:44:19.668: E/AndroidRuntime(534): java.lang.RuntimeException: An error occured while executing doInBackground()
11-18 21:44:19.668: E/AndroidRuntime(534): at android.support.v4.content.ModernAsyncTask$3.done(ModernAsyncTask.java:137)
11-18 21:44:19.668: E/AndroidRuntime(534): at java.util.concurrent.FutureTask$Sync.innerSetException(FutureTask.java:273)
11-18 21:44:19.668: E/AndroidRuntime(534): at java.util.concurrent.FutureTask.setException(FutureTask.java:124)
11-18 21:44:19.668: E/AndroidRuntime(534): at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:307)
11-18 21:44:19.668: E/AndroidRuntime(534): at java.util.concurrent.FutureTask.run(FutureTask.java:137)
11-18 21:44:19.668: E/AndroidRuntime(534): at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1076)
11-18 21:44:19.668: E/AndroidRuntime(534): at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:569)
11-18 21:44:19.668: E/AndroidRuntime(534): at java.lang.Thread.run(Thread.java:856)
11-18 21:44:19.668: E/AndroidRuntime(534): Caused by: java.lang.IllegalArgumentException: Unknown URI content://org.thialfihar.android.apg.internal/key_rings/public
11-18 21:44:19.668: E/AndroidRuntime(534): at org.thialfihar.android.apg.provider.ApgProvider.query(ApgProvider.java:544)
11-18 21:44:19.668: E/AndroidRuntime(534): at android.content.ContentProvider$Transport.query(ContentProvider.java:178)
11-18 21:44:19.668: E/AndroidRuntime(534): at android.content.ContentResolver.query(ContentResolver.java:311)
11-18 21:44:19.668: E/AndroidRuntime(534): at android.support.v4.content.CursorLoader.loadInBackground(CursorLoader.java:49)
11-18 21:44:19.668: E/AndroidRuntime(534): at android.support.v4.content.CursorLoader.loadInBackground(CursorLoader.java:35)
11-18 21:44:19.668: E/AndroidRuntime(534): at android.support.v4.content.AsyncTaskLoader.onLoadInBackground(AsyncTaskLoader.java:240)
11-18 21:44:19.668: E/AndroidRuntime(534): at android.support.v4.content.AsyncTaskLoader$LoadTask.doInBackground(AsyncTaskLoader.java:51)
11-18 21:44:19.668: E/AndroidRuntime(534): at android.support.v4.content.AsyncTaskLoader$LoadTask.doInBackground(AsyncTaskLoader.java:40)
11-18 21:44:19.668: E/AndroidRuntime(534): at android.support.v4.content.ModernAsyncTask$2.call(ModernAsyncTask.java:123)
11-18 21:44:19.668: E/AndroidRuntime(534): at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:305)
11-18 21:44:19.668: E/AndroidRuntime(534): ... 4 more
11-18 21:44:19.708: I/dalvikvm(534): threadid=3: reacting to signal 3
11-18 21:44:19.728: I/dalvikvm(534): Wrote stack traces to '/data/anr/traces.txt'

see discussion: https://groups.google.com/forum/?fromgroups=#!topic/k-9-dev/0KwkFfuIY_Q

• Can encrypt wrong in selections? Test with only sign keyring
• dsa only signing algo, drop down wrong

• Go through all intent actions
• make tests in API Demo
• eventually rename extras, differentiate into result extras
• check file encryption & decrytion

• Small buttons to switch between sections in SectionView needs to be replaced by bigger more intuitive buttons

Other ideas:

• Replace SectionView for selection of Message or File in EncryptActivity and DecryptActivity by Tabs using new ICS Tabs and Fragments like it is done in HelpActivity.

• especially the list features
• search button and dropdown could be in a fragment that is displayed when importing from key server
• Make list selectable to choose which keys to import

onClick is not getting through on Jelly Bean

Use mime types for nfc exchange etc.
see http://tools.ietf.org/html/rfc3156

Implement Contextual Action Bar for selections in all Lists instead on long-press context menu.

See http://developer.android.com/design/patterns/actionbar.html#contextual
use https://github.com/JakeWharton/ActionBarSherlock

Convert constants in Id.java to xml files were possible.

• Move all menus seperated by activity into xml files instead of using Id.java

better email pattern from android.util.Patterns.EMAIL_ADDRESS ?

see https://github.com/johnkil/Android-AppMsg

gpg files have no MIME type defined in Android, thus Filemanagers don't know how to open these. asc files have the MIME-type text/plain, thus they can be linked.

We could seperate features that need the internet permission into another app, like an addon. For those who wish to use APG without having to allow it internet access

no extra avtivity to share by nfc.
make abstract nfcactivity and extend view activity from it

PGP/MIME is missing in K9-Mail

see thunderbird/thunderbird-android#4

Many dialogs use the old dialog system.
Replace these calls with the new DialogFragments.

Working examples are in EncryptActivity or DecryptActivity.

DialogFragments can be found in .ui.dialog

implement some trust model, allowing to sign keys easily, preferably across devices in some way
better integration with Android and possibly other email apps

As a service with handlers?

see for example http://www.blackhat.com/presentations/bh-usa-09/BURNS/BHUSA09-Burns-AndroidSurgery-PAPER.pdf

Is it a problem to put a passphrase into the extras passing to the IntentService?

Corresponding bug: http://code.google.com/p/android-privacy-guard/issues/detail?id=21

• Make APG filetype for .asc and .gpg
• Instead register APG as a possible "share by" app for every filetype or content

Ideas:

• Dashboard?!
• ActionBarSherlock
• Do we need a list on apgs home screen?

java.lang.RuntimeException: Unable to start activity ComponentInfo{org.sufficientlysecure.keychain/org.sufficientlysecure.keychain.ui.DecryptActivity}: java.lang.NullPointerException
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:1960)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:1985)
at android.app.ActivityThread.access$600(ActivityThread.java:127)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1151)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:137)
at android.app.ActivityThread.main(ActivityThread.java:4482)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:511)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:794)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:561)
at dalvik.system.NativeStart.main(Native Method)
Caused by: java.lang.NullPointerException
at org.sufficientlysecure.keychain.ui.dialog.PassphraseDialogFragment.onActivityCreated(PassphraseDialogFragment.java:235)
at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:891)
at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1080)
at android.support.v4.app.BackStackRecord.run(BackStackRecord.java:622)
at android.support.v4.app.FragmentManagerImpl.execPendingActions(FragmentManager.java:1416)
at android.support.v4.app.FragmentActivity.onStart(FragmentActivity.java:505)
at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1135)
at android.app.Activity.performStart(Activity.java:4738)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:1933)
... 11 more

to generate or import key on first use.

Also provide information how OpenPGP works

"For inexperienced users, simplify the display. Too much information hides the important information. An initial display configuration could concentrate on giving the user the correct model of the relationship between public and private keys and a clear understanding of the functions for acquiring and distributing keys."

1. provide information (private/pub key, web of trust, exchange, verify, can be skipped
2. provide options to generate or import secret keyring

Implement SyncAdapter with account to link public keys and contacts

I tried importing my own public key from several keyservers, and had the same problem. I tried it both in emulator (API level 14) and on a Nexus S running Android 4.1.2, with the same results. The steps I tried are the following.

1. I selected Manage Public Keyrings on the main screen.
2. I clicked the search icon in the lower-right corner.
3. I entered my e-mail address in the field and pressed Search.
4. I clicked on a key (it didn't matter which).
5. A progress bar appeared for a second, and then a Toast said No keyrings added or updated.

I checked the SQLite database /data/data/org.thialfihar.android.apg/databases/apg.db and the structure was created successfully, but all three tables (key_rings, keys and user_ids) were empty, so it seems to be an issue with the import logic. Below is a screenshot of the 5th and 3rd steps above (yes, they're in reverse order).

Move all menu seperated by activity into xml files instead of using Id.java

Hi,

watching the original source to try to implement this idea (the base idea comes from http://wiki.debian.org/subkeys ), I stumbled upon this patch. As the author told, it is a quick'n'dirty patch. It should be better designed and integrated. As such as :

• deactivate all creation of subkeys and identities when the master private key is not present
• deactivate all web of trust action when the master private key is not present

But given the propension of smartphone being robbed, having a way to keep its master key and the web of trust linked to that master key out of the phone would be a good step towards security.

Since the original app is not updated anymore, wouldn't it be good to communicate more about this fork ? except if you think it is not stable enough ?