openbakery / obimagepicker Goto Github PK

At present ALAsset.thumbnailImage is used to retrieve the thumbnail synchronously. In the Photos.framework as well as in future network-based libraries the thumbnails are retrieved asynchronously.

For this reason Apple removed the thumbnailImage property from PHAsset. Instead you request a lower resolution image via PHImageManager. Assets are not supposed to care about a specific representation of theirs, they only hold metadata.

I propose you implement a similar image loading method in the library protocol that has a completion block that is called as soon as the image or thumbnail has been loaded.

On each change with multiple selections the selection handler should be fired

in OBAssetPickerViewController, this is missing, line 181

if (self.selectionHandler) {
        self.selectionHandler(_selectedAssets, (OBImagePickerViewController *)self.navigationController);
    }

The method fetchPhotosForCollection:completion: really fetches OBAssets. Because there can also be videos in a collection, I propose to rename this method to fetchAssetsForCollection:completion: