opencadc / apps Goto Github PK

caom2-datalink-server supports a custom request=downloads-only parameter as an optimisation to avoid figuring out of soda cutouts are possible. DLC relies on this and if used with a datalink service that does not support that it will generate and try to invoke incomplete SODA-sync cutout calls.

Solution: the filtering of links in the advance() method of the iterator needs to be more careful in picking either download or service links and not do both.

line 456 of DataLinkClient only checks for old cutout service and should look for and use SODA#sync

The Clear button in the UI doesn't clear items from the panel above. This seems to indicate some change in requirements with recent java versions (using OpenJDK Runtime Environment 1.8.0_151-b12):

Exception in thread "AWT-EventQueue-0" java.lang.IllegalStateException: This function should be called while holding treeLock
at java.awt.Component.checkTreeLock(Component.java:1201)
at java.awt.Container.validateTree(Container.java:1689)
at ca.nrc.cadc.dlm.client.JDownloadManager.access$600(JDownloadManager.java:124)
at ca.nrc.cadc.dlm.client.JDownloadManager$ClearAction.actionPerformed(JDownloadManager.java:578)
at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022)

It should not include any xsd files