opencollab / debile Goto Github PK

The default contrib/clemux/docker/debile-master/master.yaml seems to specify the wrong path to PGP keyring. Currently it is "/srv/debile/keyring.pgp"; it should be either "/srv/debile/.gnupg/pubring.gpg" or, if I'm building the data container wrong, "/srv/debile/keyring".

We should be checking that in the roodi analyzer:
roodi/roodi#29

See https://docs.docker.com/compose/

There is something that seems like a bug to me and it is in https://github.com/opencollab/debile/blob/master/debile/slave/runners/sbuild.py#L85 :

def ensure_chroot_sanity(chroot_name):
    out, _, _ = run_command(['schroot', '-l'])
    for chroot in out.splitlines():
        chroot = chroot.strip()
        chroots = [
            chroot,
            "chroot:%s" % (chroot)
        ]
        if chroot in chroots:
            return True
    raise ValueError("No such schroot (%s) found." % (chroot_name))

Shouldn't the if-statement read:

        if chroot_name in chroots:

instead?

The docker setup is almost complete. Once it proves to be usable, it should be moved from contrib/clemux somewhere else in the source tree (most likely it should replace contrib/docker).

contrib/debian/debile-slave-import-conf has moved to tools/debile_slave_import_conf.py.

The debian source package for debile-slave should be updated.

debile-remote should be able to modifiy a builder's configuration

The more urgent functionality is the ability to change a builder ip address (for ip-based authentication).

Relevant files are:

• https://github.com/opencollab/debile/blob/master/debile/utils/cli.py#L51
• https://github.com/opencollab/debile/blob/master/debile/master/interface.py#L181

This diff can give some pointers: 0fdea93

Basically:

1. add a "update_builder" handler in the server interface (debile/master/interface.py)
2. add a "update-builder" command to debile-remote (debile/utils/cli.py)

With our current docker setup, we need to manually update the database to set the builders' ip addresses.

Using docker inspect of newly created debile-slave containers, we could automate that process.

Ideally, we should first close #39 and use

debile-remote update-builder [id] --ip [new_ip]

PGP and SSL keys are currently imported with a shell script (contrib/debian/debile-slave-import-cred).

PGP keys will soon be handled (see #3). x.509 files should be handled too (with tests).

debile-slave-import conf (in contrib/debian) currently only works with the SSL-based authentication backend.

It needs an argument for disabling the SSL-only configuration keys, and should handle the PGP key import itself (currently done with the shell script debile-slave-import-cred), for better testability.

Also it should be covered by unit tests.

https://github.com/opencollab/debile/blob/master/debile/slave/runners/coccinelle.py#L35

To use the simple authentication backend with debile-slave and debile-master, we currently need to pass --auth simple as a CLI argument.

On the other hand, debile-remote can (and must) use the simple auth with a configuration key in /etc/debile/user.yaml: auth_method.

For consistency and easier configuration of debile-slave and debile-master, we should add the support for 'auth_method' configuration key in slave.yaml and master.yaml.

Hints:

• https://github.com/opencollab/debile/blob/master/debile/utils/cli.py#L236
• https://github.com/opencollab/debile/blob/master/debile/master/server.py#L203
• https://github.com/opencollab/debile/blob/master/debile/slave/cli.py#L41

The documentation for using clemux's docker images is for from being complete and should be improved.

Currently, to use debile-remote with simple authentication, we need to edit the database manually to add the user's ip address.

We need a new command: debile-remote create-user-ip [name] [email] [pgp] [ip].

See #1.

The pgp key of the user that will upload packages should be imported at built time.

Files to change:

• contrib/clemux/docker/debile-data/Dockerfile
• contrib/clemux/docker/README.rst