openebs / istgt Goto Github PK
View Code? Open in Web Editor NEWCAS Data Engine - iSCSI Target for OpenEBS cStor
Home Page: https://docs.openebs.io
License: Apache License 2.0
CAS Data Engine - iSCSI Target for OpenEBS cStor
Home Page: https://docs.openebs.io
License: Apache License 2.0
What would you like to be added:
Why is this needed:
This is required to check the consistency across the replicas.
Describe the solution you'd like:
[A clear and concise description of what you want to happen]
Environment:
kubectl version
):/etc/os-release
):Upon modifying the LUN0 Storage in istgt.conf file, to reload modified configuration executed istgtcontrol refresh
then segmentation fault is seen.
istgt should not crash
/usr/local/etc/istgt/istgt.conf
fileistgtcontrol refresh
command to reload the configurations.Logs of istgt
2019-02-11/12:13:40.023 main :3089: m#-1747536064.6923 : istgt:0.5.20121028:09:27:44:Feb 7 2019: starting
2019-02-11/12:13:40.023 main :3146: m#-1747536064.6923 : LU2 HDD UNIT
2019-02-11/12:13:40.024 istgt_lu_disk_init: 904: m#-1747536064.6923 : lu_disk_init LU2 TargetName=iqn.2016-09.com.openebs.cstor:vol1
LU2: LUN0 iqn.2016-09.com.openebs.cstor:vol1: storage_online [(null), 4GB.0MB, 1048576 blks of 4096 bytes, phy:0/3 WCE rpm:7200] q:128 thr:6/0 [0.0, 0.0]
LU2: LUN0 serial:4059aab98f093c5d95207f7af09d1413
2019-02-11/12:13:40.024 istgt_lu_disk_init:1337: m#-1747536064.6923 : LU2: LUN0 serial:4059aab98f093c5d95207f7af09d1413
2019-02-11/12:13:52.055 istgt_reload :2141: u#10.140606617675520: reload configuration#1 start
[istgt:0.5.20121028:09:27:44:Feb 7 2019]
2019-02-11/12:13:52.056 istgt_lu_disk_shut:1432: u#10.140606617675520: LU2: LUN0 iqn.2016-09.com.openebs.cstor:vol1: storage_offlinex [(null) 1048576 blocks, 4096 bytes/block] [0.0 0.0 0.0]
LU2 HDD UNIT
2019-02-11/12:13:52.056 istgt_lu_disk_init: 904: u#10.140606617675520: lu_disk_init LU2 TargetName=iqn.2016-09.com.openebs.cstor:vol1
LU2: LUN0 iqn.2016-09.com.openebs.cstor:vol1: storage_online [(null), 5GB.0MB, 1310720 blks of 4096 bytes, phy:0/3 WCE rpm:7200] q:128 thr:6/0 [0.0, 0.0]
2019-02-11/12:13:52.057 istgt_lu_disk_init:1327: u#10.140606617675520: LU2: LUN0 iqn.2016-09.com.openebs.cstor:vol1: storage_online [(null), 5GB.0MB, 1310720 blks of 4096 bytes, phy:0/3 WCE rpm:7200] q:128 thr:6/0 [0.0, 0.0]
LU2: LUN0 serial:4059aab98f093c5d95207f7af09d1413
2019-02-11/12:13:52.057 istgt_lu_disk_init:1337: u#10.140606617675520: LU2: LUN0 serial:4059aab98f093c5d95207f7af09d1413
2019-02-11/12:13:52.057 istgt_lu_reload_up:3325: u#10.140606617675520: update LU2: Name=iqn.2016-09.com.openebs.cstor:vol1
Fatal signal received: 11
Stack trace:
./istgt[0x40bd10]
/lib/x86_64-linux-gnu/libc.so.6(+0x354b0)[0x7fe196c5b4b0]
./istgt[0x5a236c]
./istgt[0x5a367d]
./istgt[0x5936d1]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x76ba)[0x7fe19750b6ba]
/lib/x86_64-linux-gnu/libc.so.6(clone+0x6d)[0x7fe196d2d41d]
Segmentation fault (core dumped)
What would you like to be added:
It will help to fix memory issues/corruption in cstor-istgt.
Why is this needed:
Add a test case to track memory leak (or) corruption using Valgrind tool
Describe the solution you'd like:
[A clear and concise description of what you want to happen]
Environment:
kubectl version
):/etc/os-release
):The following function istgt_lu_disk_execute(CONN_Ptr, ISTGT_LU_CMD_Ptr)https://github.com/openebs/istgt/blob/62d20a1ae272b4604359d47af06c1ff701f65033/src/istgt_lu_disk.c#L9072-L10923 can be refactored, which is a unit of 1537 lines of code.
Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Short Units of Code guideline rating!
Here's the gist of this guideline:
You can find more info about this guideline in Building Maintainable Software. ๐
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.