openedx / frontend-app-authn Goto Github PK

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Repository problems

These problems occurred while renovating this repository. View logs.

• WARN: Package lookup failures

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• fix(deps): update dependency algoliasearch-helper to v3.22.3
• fix(deps): update dependency @openedx/paragon to v22.7.0
• fix(deps): update font awesome to v6.6.0 (@fortawesome/fontawesome-svg-core, @fortawesome/free-brands-svg-icons, @fortawesome/free-solid-svg-icons)
• fix(deps): update react-router monorepo to v6.25.1 (react-router, react-router-dom)
• fix(deps): update dependency @testing-library/react to v16
• fix(deps): update dependency query-string to v9
• fix(deps): update dependency react-redux to v9
• fix(deps): update dependency react-responsive to v10
• fix(deps): update dependency redux to v5
• fix(deps): update dependency redux-thunk to v3
• fix(deps): update dependency reselect to v5
• fix(deps): update dependency universal-cookie to v7
• 🔐 Create all rate-limited PRs at once 🔐

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• fix(deps): update dependency redux to v4.2.1
• fix(deps): update dependency algoliasearch to v4.24.0
• chore(deps): update actions/checkout action to v4
• chore(deps): update actions/setup-node action to v4
• chore(deps): update dependency @edx/reactifex to v2
• chore(deps): update dependency glob to v11
• chore(deps): update dependency husky to v9
• chore(deps): update dependency ubuntu to v22
• fix(deps): update dependency @optimizely/react-sdk to v3
• fix(deps): update react monorepo to v18 (major) (react, react-dom, react-test-renderer)
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

I use a plugin to customize the registration fields. It would be good if it could be documented how to do that in the context of this new frontend as well. (Clearly it would involve setting ENABLE_DYNAMIC_REGISTRATION_FIELDS, but it's not clear where the actual other fields would be set, or how their values would be retrieved.)

Thank you for your kind consideration of this ticket.

When the third party authentication is enabled, it comes in contact with the sign in button. It can be modified by adding a class "mb-3" for the sign-in button.

Has anyone already made any modification on these?

Whenever I clicked on 'Sign In' button, it takes me to the Authn MFE. The issue is that it shows 'Authn | null' in the header. The reason is that in public/index.html, the header is <title>Authn | <%= process.env.SITE_NAME %></title>. For first time, the process.env.SITE_NAME is null and after that mergeConfig runs which updates SITE_NAME. Due to that thing, it shows Authn | null which is not a good user experience. I will suggest to remove | <%= process.env.SITE_NAME %> and its better to just show Authn only in title. Here is the screenshot:

I am running openedx using tutor local

in the cookie banner can we change "edX and its members..." to "{PLATFORM_NAME} and its members..."
Is there a way to set the cookie banner off by default?

Paragon 22 includes breaking changes for Form.Autosuggest. These should aid in simplifying the implementation of CountryField, but some changes may be needed in Paragon to support certain parts of the error handling logic. One part that stands out is handleErrorChange as seen here:

In trying to include the AuthN MFE in the Tutor release of Olive, we found that the login API used by this MFE requires edx-enterprise to be deployed and configured, so that even if DISABLE_ENTERPRISE_LOGIN is set to true in the MFE, logins cannot work without it.

It should be possible to use this MFE without the edx-enterprise requirement.

Abstract
Node 16's support will end on September 11, 2023. So we have to upgrade node JS to v18 before that.

Extras
Project should use .nvmrc to have a consistent node version
We have to update Readme accordingly.

Upgrade Node JS from 16 to 18

hey guys, I just installed this mfe alongside my lilac.rc3 open edx and SignIn functionality doesn't work
maybe the API changed or something but I couldn't access this URL. it returned 404.

LMS/api/user/v2/account/login_session/
which was used here:

https://github.com/edx/frontend-app-authn/blob/32300db8dd44effaffa6e9980887d8556543cfc1/src/login/data/service.js#L14
note that register function worked like a charm.

This repo is currently using React JS v16. We need to upgrade it to React 17 before moving to latest React version(v18).
React 17 doesn’t add any new developer-facing features, so its upgrade might not cause any breaking changes. Our end goal is to upgrade React to v18 but v18 no longer support enzyme, so we are upgrading to React 17 and then we’ll migrate from enzyme.

Epic Link

React 17 upgrade

Under the new student registration page is the following text/code with broken links:

By creating an account, you agree to the [Terms of Service and Honor Code](https://apps.test.mydomain.com/authn/register?next=%2F#)
[in a new tab](https://apps.test.mydomain.com/authn/register?next=%2F#) and you acknowledge that MyLongSiteNameTest and each Member process your personal data in accordance with the [Privacy Policy](https://apps.test.mydomain.com/authn/register?next=%2F#)
[in a new tab](https://apps.test.mydomain.com/authn/register?next=%2F#).

Those "Terms of Service and Honor Code" and "Privacy Policy" links are broken by default, and go nowhere, except back to the registration page itself.

FWIW on my previous instance (which is using tutor indigo theme, though I don't know if that matters), the URL for the terms of service is "test.mydomain.com/tos". I think that was the default URL.

Is this expected breakage, and there's somewhere I'm supposed to change these URLs? Or is this unexpected breakage that just no one has reported yet for Olive.3?

Description

See the parent ticket for the general description and motivation, openedx/public-engineering#267. Make sure to follow its recommendations for each step of the process.

When an Open edX site has a long name, the new registration/login page UI bisects the site-name. See here for image of issue: https://discuss.openedx.org/t/how-to-get-rid-of-diagonal-line-in-sign-in-page-in-indigo-on-olive/10182

This is a regression from pre-Olive behavior.

In order to advance implementation of both OEP-45: Configuring and Operating Open edX and openedx/public-engineering#51, we would like to switch devstack from using primarily Docker images built with Ansible code from the configuration repository to images built from Dockerfiles in each service's repository. We hope this will also help simplify Tutor by providing better base images to derive from, with fewer workarounds and duplicated code blocks required in Tutor.

A/C

Ensure that the repo's Dockerfile can create a base image which is appropriate for small production installations
Ensure that the repo's Dockerfile also defines an additional image derived from the base which adds dependencies and configuration changes needed for development environments
Check with the Tutor developers during code review to see if any further changes to the Dockerfile would help simplify Tutor
Automate uploads of both images when code changes are merged
Switch devstack to use the new Ansible-free development image, and do some basic testing to ensure it works before merging

When registering as a user in authn MFE Register tab, there is a full Name field.

• That field allows user to enter single character. I believe that the validation should update and must allow to enter at least 3 characters.
• The full name field is accepting the special characters as well. Full name doesn't contain any special characters so validation should include only alphabets

Toggle key: https://edx.readthedocs.io/projects/edx-platform-technical/en/latest/featuretoggles.html#featuretoggle-FEATURES['ALLOW_PUBLIC_ACCOUNT_CREATION']