openfootball / england Goto Github PK

Hi all,

Looks like in all of the 1998-99 files for England, the games are 1 day too early. For example, see:

https://github.com/openfootball/england/blob/master/archive/1990s/1998-99/1-premierleague.txt

This file tells us that:

Matchday 1
[Fri Aug/14]
  Wimbledon FC             3-1  Tottenham

But actually it was played on Sat Aug/15:

https://www.premierleague.com/match/2534

Can I go and correct all these files?

When I did sportdb build and looked up the exported sport.db sqlite file, I found that Manchester United's match number is only 19 in 2012/13 season.

https://github.com/openfootball/england/blob/master/2012-13/1-premierleague-ii.txt
This file describes Manchester united as "Manchester U" and Manchester City as "Manchester C", and
https://github.com/openfootball/england/blob/master/.build/conf.txt

[10/81] >2012-13/1-premierleague-ii.txt<
  1 section(s):
    261 lines - league: >English Premier League< (eng.1), season: >2012/13<
      20 clubs:
        Arsenal x19 => Arsenal FC
        Aston Villa x19 => Aston Villa FC
        Chelsea x19 => Chelsea FC
        Everton x19 => Everton FC
        Fulham x19 => Fulham FC
        Liverpool x19 => Liverpool FC
        Manchester C x19 => Manchester City FC
        Manchester U x19 => Manchester United FC

I think the last two line don't handle the conversion correctly.
I don't know why.
But you can confirm something is wrong by doing what I did:

When I did sportdb build and looked up the exported sport.db sqlite file, I found that Manchester United's match number is only 19 in 2012/13 season.

This file is empty
eng-england/2003-04/1-premierleague.txt

After "sportdb build", when I open the "sport.db" file, it only contains matches up until 30th June.
Matches after 1st July were not there.
No match after July appeared on sport.db.

My guess is, a kind of "lock" is present somewhere (sportdb itself or some config file) that it recognizes matches only up until June, because June is normally assumed as after the end of a season. (But current Corona situation is abnormal)

Could you test this and comment that this bug happens only to me or to everyone?

On Windows 10 + ruby 2.5, i get the below error when calling "sportdb new en"

*** error: undefined method `get_input_stream' for nil:NilClass

Can you help?

Heres the preceeding output...

[info] parsing data in zip 'setups/all' (eng-england-master/setups/all.txt)...
[info] parsing data in zip (league) 'eng-england!/leagues' (eng-england-master/leagues.txt)...
DEPRECATION WARNING: update_attributes! is deprecated and will be removed from Rails 6.1 (please, use update! instead) (called from load at C:/Ruby25-x64/bin/sportdb:23)
DEPRECATION WARNING: update_attributes! is deprecated and will be removed from Rails 6.1 (please, use update! instead) (called from load at C:/Ruby25-x64/bin/sportdb:23)
DEPRECATION WARNING: update_attributes! is deprecated and will be removed from Rails 6.1 (please, use update! instead) (called from load at C:/Ruby25-x64/bin/sportdb:23)
DEPRECATION WARNING: update_attributes! is deprecated and will be removed from Rails 6.1 (please, use update! instead) (called from load at C:/Ruby25-x64/bin/sportdb:23)
[info] parsing data in zip (team) 'eng-england!/clubs/1-premierleague' (eng-england-master/clubs/1-premierleague.txt)...

*** error: undefined method `get_input_stream' for nil:NilClass

When I clone the repo and run

sportdb new en

It does not add the 2018-19 results or anything past 2010.

Is it possible to get these results?

I have tried changing ./setups/all.txt to:

##################
# All Fixtures

# - Leagues
eng-england!/leagues

# - Clubs
eng-england!/clubs/1-premierleague
eng-england!/clubs/2-championship
eng-england!/clubs/wales
eng-england!/clubs/more

# - Fixtures
eng-england!/2018-19/1-premierleague.conf
eng-england!/2018-19/1-premierleague

eng-england!/2017-18/1-premierleague.conf
eng-england!/2017-18/1-premierleague

eng-england!/2016-17/1-premierleague.conf
eng-england!/2016-17/1-premierleague

eng-england!/2015-16/1-premierleague.conf
eng-england!/2015-16/1-premierleague

eng-england!/2014-15/1-premierleague.conf
eng-england!/2014-15/1-premierleague

eng-england!/2013-14/1-premierleague.conf
eng-england!/2013-14/1-premierleague

eng-england!/2012-13/1-premierleague.conf
eng-england!/2012-13/1-premierleague

eng-england!/2011-12/1-premierleague.conf
eng-england!/2011-12/1-premierleague

eng-england!/2010-11/1-premierleague.conf
eng-england!/2010-11/1-premierleague

eng-england!/2009-10/1-premierleague.conf
eng-england!/2009-10/1-premierleague

eng-england!/2008-09/1-premierleague.conf
eng-england!/2008-09/1-premierleague

eng-england!/2007-08/1-premierleague.conf
eng-england!/2007-08/1-premierleague

eng-england!/2006-07/1-premierleague.conf
eng-england!/2006-07/1-premierleague

eng-england!/2005-06/1-premierleague.conf
eng-england!/2005-06/1-premierleague

eng-england!/2004-05/1-premierleague.conf
eng-england!/2004-05/1-premierleague

eng-england!/2003-04/1-premierleague.conf
eng-england!/2003-04/1-premierleague

eng-england!/2002-03/1-premierleague.conf
eng-england!/2002-03/1-premierleague

eng-england!/2001-02/1-premierleague.conf
eng-england!/2001-02/1-premierleague

eng-england!/2000-01/1-premierleague.conf
eng-england!/2000-01/1-premierleague

eng-england!/1999-00/1-premierleague.conf
eng-england!/1999-00/1-premierleague

eng-england!/1998-99/1-premierleague.conf
eng-england!/1998-99/1-premierleague

but this is not working