openkitten / lynx

The OpenKitten HTTP Framework

Lynx

An extremely high performance HTTP framework.

lynx's Issues

A name

Yarn isn't going to work

Test at least 3 controller implementations

CORS, cookies and sessions

• CORS
• Cookies
• SafeSite in cookies
• Sessions

WebSocket client

Reduce copies by using COW for a whole request, not just the components inside it (like Path)

HTTP Multipart form parsing for files

Multipart serialisation

WebSockets

Really fast Multipart and JSON

Supporting libraries (using Codable)

• JWT request/response Support
• Request encoder/decoder

Error system

Create and test mutating headers including the underlying cache

Crash on Telnet Session Cancellation

Building 2a6ed87

1. run server, 127.0.0.1:8080
2. telnet 127.0.0.1 8080

telnet 127.0.0.1 8080
Trying 127.0.0.1...
Connected to localhost.
Escape character is '^]'.

3. end telnet session (CMD-C)
4. self.readSource.setEventHandler(qos: .userInteractive) { will call once (though occasionally twice) where
   let read = Darwin.recv(self.descriptor, self.incomingBuffer.pointer, Int(UInt16.max), 0)
   resolves to 5
5. end command line session (CMD-W)
6. let read = Darwin.recv(self.descriptor, self.incomingBuffer.pointer, Int(UInt16.max), 0) resolves to a small int (have seen 18, 12, or 39)
7. observe crash

call stack:

#0	0x0000000100cdd5a0 in parsePath #1 () in RequestPlaceholder.parse(_:len:) at /Users/jameswilliamgraham/Lynx/Sources/Lynx/HTTP/HTTPParser.swift:151
#1	0x0000000100cdb4ee in RequestPlaceholder.parse(_:len:) at /Users/jameswilliamgraham/Lynx/Sources/Lynx/HTTP/HTTPParser.swift:189
#2	0x0000000100cdeea2 in closure #1 in HTTPServer.connection(from:) at /Users/jameswilliamgraham/Lynx/Sources/Lynx/HTTP/HTTPServer.swift:47
#3	0x0000000100cdf02e in partial apply for closure #1 in HTTPServer.connection(from:) ()
#4	0x0000000100d0eee6 in closure #1 in ClientHolder.listen() at /Users/jameswilliamgraham/Lynx/Sources/Lynx/Sockets/TCPClient.swift:89
#5	0x0000000100d0ef4c in partial apply for closure #1 in ClientHolder.listen() ()
#6	0x0000000100d0e9f9 in thunk for @callee_owned () -> () ()
#7	0x0000000100d861f1 in _dispatch_block_async_invoke ()
#8	0x0000000100d7078c in _dispatch_client_callout ()
#9	0x0000000100d869fb in _dispatch_continuation_pop ()
#10	0x0000000100d7c64a in _dispatch_source_latch_and_call ()
#11	0x0000000100d735da in _dispatch_source_invoke ()
#12	0x0000000100d86721 in _dispatch_continuation_pop ()
#13	0x0000000100d7ddfc in _dispatch_async_redirect_invoke ()
#14	0x0000000100d72a0c in _dispatch_root_queue_drain ()
#15	0x0000000100d7271d in _dispatch_worker_thread3 ()
#16	0x0000000100de77da in _pthread_wqthread ()
#17	0x0000000100de72b5 in start_wqthread ()

The crash occurs in parsing paths
self.path = Path(path: UnsafeBufferPointer(start: buffer.baseAddress, count: buffer.count &- 1), query: nil)

(lldb) po buffer.count
0

seems like checking the buffer size before making a pointer would solve this, though I'd like to understand more why it's happening

@Joannis