openliberty / devfile-stack-starters Goto Github PK

I had to hard-code the app name:

   <webApplication contextRoot="/" location="starter-default.war" />

whereas the MicroProfile starter uses a POM property passed through as a bootstrap property.

I couldn't get this to work trying the stack starter; I think there could be an issue with liberty-maven-plugin wrongly caching the config.

All files looks good to me except I have following comments for the pom.xml

• Should use milestone versions?
• Most plugin versions are defined in the <properties/> but maven-compiler-plugin not, should it be consistent?
  • the guides do not define versions in the <properties/>
• based on https://maven.apache.org/plugins/maven-war-plugin/war-mojo.html#failOnMissingWebXml, default is false for 3.1+, may consider to remove <failOnMissingWebXml>false</failOnMissingWebXml>
• may consider the test dependecides are need or not
  • cxf-rt-rs-client, cxf-rt-rs-extension-providers, and org.glassfish, specially using MST
• may consider the comment <!-- Support for JDK 9 and above --> and the test dependencies under it are necessary or not
  • compiler target and source are set to 11
  • if using MST, some dependecides may not need