Comments (7)
xref #126 and #144. If there's a relatively clean way to do this within GitHub Actions, a PR would be great. Thanks!
from openslide-python.
Yes, please do. I'd prefer to use explicit build steps rather than having the Action do it for us, but if that turns out to be too complex, the Action could be a reasonable alternative.
from openslide-python.
xref #126 and #144. If there's a relatively clean way to do this within GitHub Actions, a PR would be great. Thanks!
@bgilbert I can make an attempt later today and make a PR.
from openslide-python.
@bgilbert Made a PR which resolves this issue: #188
from openslide-python.
Oh, I just went through the proposed edits you mentioned here, which looks very similar to mine. What exactly were the issues? Seemed to work fine in my case. At least when testing the precompiled wheel on my external macOS. I guess you are talking about backward-compatibility on older linux-versions, or?
EDIT: Should've read the discussion more carefully here. What exactly is the reason why precompiled wheels (with the current solution) might be a bad idea?
from openslide-python.
Yup, the wheels built by that PR failed to load on older Linux versions, which seemed to defeat the point. As I understand it, we'd need to build in a special container, but that should be doable.
There are two separate questions: whether to build OpenSlide Python wheels for Linux and macOS, and whether to bundle OpenSlide (the actual C library) into those wheels. I'm in favor of the former, but the latter is complex (OpenSlide has a lot of dependencies) and I'd consider it out of scope.
from openslide-python.
Yup, the wheels built by that PR failed to load on older Linux versions
What we often do is to build on the oldest relevant Linux version, as python packages tend to be forward compatible on Ubuntu. However, it is true that there is no guarantee. Manylinux solution might be the best fit.
However, I see that there exists an Action that can be used for exactly this purpose:
https://github.com/marketplace/actions/python-wheels-manylinux-build
If I understand correctly, building inside this container, it should work as intended, right? Shall i make an attempt? I can make commits to the same branch as in the PR.
from openslide-python.
Related Issues (20)
- OSError: -9 HOT 2
- openslide can not read a file with chinese path HOT 2
- get_thumbnail bug report HOT 3
- miniconda & openslide-python; LIBFFI_BASE_7.0 HOT 1
- WSIs appear dark black when I convert SVS files to 10x or lower scale factor HOT 6
- Release 1.3.0
- Build for Python 3.12 HOT 2
- Missing _convert.cpython-310-darwin.so HOT 4
- "openslide.lowlevel.OpenSlideUnsupportedFormatError: Unsupported or missing image file" for DICOM image HOT 1
- Release 1.3.1 HOT 2
- Consider dropping 32-bit Windows wheels
- No DICOM support in Anaconda version of openslide-python 1.3.1 HOT 1
- PIL.UnidentifiedImageError: cannot identify image file HOT 6
- OpenSlideError: Bad direction attribute "LEFT" HOT 1
- a bug of mrxs HOT 6
- Streamlining installation on Linux/MacOS HOT 1
- the shape of image from DeepZoomGenerator.get_tile is inconsistent HOT 1
- ValueError: Argument is not writable HOT 3
- Cannot open SVS file HOT 8
- Cannot read example data properly czi HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openslide-python.