opensuse / brp-check-suse Goto Github PK

#18 entered openSUSE Factory a couple days ago.
It causes quite some build issues.

example 1:

[ 148s] + /usr/lib/rpm/suse_update_desktop_file.sh -r spyder Qt Science ComputerScience Development IDE
[ 148s] WARNING: Category "ComputerScience" is unknown !

According to https://en.opensuse.org/openSUSE:Packaging_desktop_menu_categories#Science, ComputerScience can be a subcategory of either Education or Science

example 2:
Fixing mayavi.desktop to have
Categories=GNOME;Education;DataVisualization;X-Science,X-DataVisualization;
now makes the build fail for leap with an unknown categories error

example 3:

[ 128s] ERROR: No sufficient Category definition "Qt;KDE;Education;X-KDE-Edu-Misc;X-KDE-Edu-Teaching;" in /home/abuild/rpmbuild/BUILDROOT/ktouch-19.08.0-1.2.i386//usr/share/applications/org.kde.ktouch.desktop

The categories are valid. X-KDE-Edu-Teaching is the only one accepted and X-KDE-Edu-Misc is compliant with the XDG spec.

I'm looking at the other issues. Teaching now being rejected is the cause of multiple failures.

RemovePathPostfixes allows us to do some neat things with placing multiple files in the same place in rpms, but brp doesn't know that symlinks pointing to that actually end up existing in the package, because they don't exist in the buildroot

that check was moved to rpmlint

brp-30-desktop fails on categories=Education;Science; with the error message:
ERROR: No sufficient Category definition:

But according to https://en.opensuse.org/openSUSE:Packaging_desktop_menu_categories this category is allowed. As I think the check should check what's agreed on and not change the allowed categories to be determined by the check, this is a bug in the check. Also there are several comments below the corresponding commit complaining about similar issues: 031533d

@scarabeusiv
The script is redundant to rpmlint check named linked-against-opt-library.

According to freedesktop.org categories like Science/Physics are allowed. But brp-30-desktop returns "ERROR: No sufficient Category definition"