Fix building on sle12 about mysql-packaging

[scarabeusiv]

This should break it on leap which has readline5-devel no?

[darix]

On 2015-11-17 11:00:35 -0800, Tomáš Chvátal wrote:

This should break it on leap which has readline5-devel no?

it actually succeeds but it will use libedit. I needed builds for sle12
to get the exec fix fir mysql_start().

darix

       openSUSE - SUSE Linux is my linux
           openSUSE is good for you
               www.opensuse.org

[darix]

tbh ... the logic was probably wrong in any case. and only did by luck what you expected.

[darix]

tbh i would be interested in a matrix for "which readline library do you want to use on which target"

[darix]

This should even work on sle11

Index: mariadb-101.spec
===================================================================
--- mariadb-101.spec    (revision 43)
+++ mariadb-101.spec    (working copy)
@@ -128,8 +128,12 @@
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
 %{?systemd_requires}
 # On mariadb we want readline5 and on mysql we use libedit from system
-%if "%{name}" == "mariadb" && (0%{?suse_version} != 1315)
+%if ("%{name}" == "mariadb" ) && ! (( 0%{?suse_version} == 1315 ) && ( ! 0%{?is_opensuse} ))
+%if 0%{?suse_version} >= 1310
 BuildRequires:  readline5-devel
+%else
+BuildRequires:  readline-devel
+%endif
 %else
 BuildRequires:  libedit-devel
 %endif

[kstreitova]

It should be like that (for mysql-packaging git)

Product	Library
SLE12	libedit
13.1	readline5
13.2	readline5
Factory	readline5
Leap	readline5

As we are not interested in SLE11 here I would simplify the condition to:

 %{?systemd_requires}
 # On mariadb we want readline5 and on mysql we use libedit from system
-%if "%{name}" == "mariadb" && (0%{?suse_version} != 1315)
+%if ("%{name}" == "mariadb" ) && ! (( 0%{?suse_version} == 1315 ) && ( ! 0%{?is_opensuse} ))
 BuildRequires:  readline5-devel
 %else
 BuildRequires:  libedit-devel
 %endif

[kstreitova]

Submitted by cc5b28e

Closing.