npc trader when the item has a high value about canary

[Mirkaanks]

I didn't understand, what bugged?

[pedrohfk]

I didn't understand, what bugged?

44 upgrade potions = 2kkk gold coins
1405 upgrade potions = 1kkk500kk gold coins.

It seems to me that the NPC is getting lost in the midst of so much money.

[luanluciano93]

Surely someone type of variable is like uint32_t and makes values ​​above 4,294,967,295 impossible. You can test, values ​​above this should be buggy.

[Chapeleiiro]

I also have this problem

[pedrohfk]

Does anyone know if there is a way to enable purchases up to x value?

[luanluciano93]

canary/src/server/network/protocol/protocolgame.cpp

Line 7930 in 9efbe4c

msg.add<uint32_t>(shopBlock.itemSellPrice == 4294967295 ? 0 : shopBlock.itemSellPrice);

the problem is with the cip client limitation, it receives a 32-bit integer, the maximum transaction value must be 4,294,967,295

[pedrohfk]

canary/src/server/network/protocol/protocolgame.cpp

Line 7930 in 9efbe4c

msg.add<uint32_t>(shopBlock.itemSellPrice == 4294967295 ? 0 : shopBlock.itemSellPrice);

the problem is with the cip client limitation, it receives a 32-bit integer, the maximum transaction value must be 4,294,967,295

But in this case there is some lock that we can put in place to prevent this bug from occurring.?

[luanluciano93]

canary/src/server/network/protocol/protocolgame.cpp

Line 7930 in 9efbe4c

msg.add<uint32_t>(shopBlock.itemSellPrice == 4294967295 ? 0 : shopBlock.itemSellPrice);

the problem is with the cip client limitation, it receives a 32-bit integer, the maximum transaction value must be 4,294,967,295

But in this case there is some lock that we can put in place to prevent this bug from occurring.?

I would use another currency on the NPC, something worth 1kk for example

[pedrohfk]

@dudantas Can you see if we can put a check so this doesn't happen?