GithubHelp home page GithubHelp logo

Comments (7)

auryn-macmillan avatar auryn-macmillan commented on May 18, 2024

Was just coming here to post this.
Would be great if you could also easily deploy the proxy in Remix.

from contracts-wizard.

frangio avatar frangio commented on May 18, 2024

Added a warning in c5c84fa.

from contracts-wizard.

cyanlink avatar cyanlink commented on May 18, 2024

Sorry for bothering but as a new comer I find the warning easily overlooked as it only shows as a bubble dialog on mouse hover. This information is not very accessible by Googling either. At least we should show a static noticeable warning message "⚠ Remix cannot be used for upgradeable contracts " next to the "Open in Remix" option IMO.

from contracts-wizard.

frangio avatar frangio commented on May 18, 2024

Thanks for the suggestion @cyanlink. Do you suggest the warning should be visible even before selecting upgradeability?

from contracts-wizard.

cyanlink avatar cyanlink commented on May 18, 2024

I would prefer not to because without upgradeability Remix IDE is all right. It's still conventional contract code that does not need extra setup. When upgradeability selected, a sudden appearance of a warning sign can better draw user's attention than a constant warning.

from contracts-wizard.

cyanlink avatar cyanlink commented on May 18, 2024

After going back to the wizard website I reconsidered. The warning should be displayed in a even more noticeable way, because the webpage is scrollable, when we scroll down to select upgradeability, then scroll back to top to reach the export buttons, we might still overlook if the appeared warning is placed near the buttons.

Maybe it should be right under the Upgradeability options section when toggled, and if we check the checkbox we can instantly see it; or we can even pop up a modal dialog for acknowledgement when user try to open in remix when toggled.

from contracts-wizard.

frangio avatar frangio commented on May 18, 2024

Ok, in e42c3fb I've made it so the button is disabled for upgradeable contracts and actually opening in Remix requires an additional click inside the tooltip.

Check it out please!

from contracts-wizard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.