GithubHelp home page GithubHelp logo

Comments (5)

benoit74 avatar benoit74 commented on July 22, 2024 1

Yep, this is what I meant. Issue is here: openzim/sotoki#315

from zimfarm.

benoit74 avatar benoit74 commented on July 22, 2024

This is a Zimfarm configuration issue.

Proper CLI flag is --tag and not --tags. Passing multiple tags require that the --tag flag is called multiple times like sotoki --tag "Quality Assurance" --tag "Another TAG" and this is currently not supported by the Zimfarm. I will adjust Zimfarm configuration to at least support one additional tag.

Nevertheless, I expect that we want / need to support multiple tags. Do we want to fix this in sotoki (move from --tag to --tags and process this as a CSV, this is easy but a breaking change) or in Zimfarm (add support for list flags, this most probably needs UI adaptations and will most probably come with its own share of subtle bugs). WDYT?

from zimfarm.

kelson42 avatar kelson42 commented on July 22, 2024

Nevertheless, I expect that we want / need to support multiple tags.

Definitely, and it should be able to provide everything with a string, using ; for example as separator. This is something we have done in a few other scrapers AFAIK. CSV is uselessly too cumbersome to prepare.

from zimfarm.

benoit74 avatar benoit74 commented on July 22, 2024

Zimfarm + recipe reconfigured, we can now specify 1 single tag.

Task: https://farm.openzim.org/pipeline/d3e4cbf0-50a5-4385-a6ac-7167b3307ec8

The task failed due to another bug most probably linked to known problems with SE data dump

This issue is hence fixed and other issues are opened, let's close this.

from zimfarm.

benoit74 avatar benoit74 commented on July 22, 2024

Btw, I transfer this issue to zimfarm repo since it is a zimfarm issue

from zimfarm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.