GithubHelp home page GithubHelp logo

crawlme's People

Contributors

arokor avatar wali-s avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

crawlme's Issues

Port

Is there a way to update what port zombie uses? My site runs on 8080 so zombie always fails to connect to what it thinks it wants.

Seems like the zombie api changed?

According to this:

https://groups.google.com/forum/#!msg/zombie-js/qOS0W_cMCgQ/4iFcqLjVEPgJ

It seems like this code in crawlme.js cannot work because the callback doesn't get browser. Simply removing the browser argument from the callback seems to fix the issue.

browser.visit(url, {waitFor: options.waitFor},
  function(err, browser, status) {
    if(err) return cb(err);

    // links
    var links = browser.queryAll('a'); // browser is undefined
    links.forEach(function(link) {
      var href = link.getAttribute('href');
      var absoluteUrl = urlParser.resolve(url, href);
      link.setAttribute('href', absoluteUrl);
    });

Protocol not properly obtained from req.protocol

In crawme.js (starting line 30) you have the following:

var protocol = req.protocol || options.protocol;
var url = options.protocol + '://' + req.headers.host;

that second options.protocol should just be protocol, otherwise the above line is useless :)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.