Comments (10)
Either it should be in document to use only child compartment for this module or code should behave properly for root compartment as well as for child together. That logic is currently missing to take of that scenario.
from terraform-oci-base.
Why would you create this in the root compartment?
from terraform-oci-base.
Bydefault, every default user gets root comparment and might tend to go with it unless mentioned in document or error output needs to be more accurate instead of below-
"data.oci_identity_compartments.compartments_id.compartments is empty list of object"
More significant for non corporates which tend to directly work on root compartment, may be.
Only concern is, message to have more clear that "you have chosen root compartment for OKE clusters and its not supported with this module"
from terraform-oci-base.
This is the base module, not the OKE module.
from terraform-oci-base.
Same issue in both because OKE module uses this one.
from terraform-oci-base.
This should be documentation then.
from terraform-oci-base.
Will you be adding the documentation?
from terraform-oci-base.
yes, i will update.
from terraform-oci-base.
Sorry, was busy, This is pull request- #62
from terraform-oci-base.
Resolved in #62
from terraform-oci-base.
Related Issues (20)
- Add a mechanism so solutions built on top of base know when the instance_principal group and policy have been created. HOT 1
- Remove ip.finish HOT 1
- Use terraform-oci-vcn module, terraform-oci-bastion, terraform-oci-operator HOT 2
- vcn tags are hardcoded HOT 1
- Update bastion and operator version to avoid error with image version not existing
- Add schema for resource manager
- Make label_prefix optional HOT 1
- Support Cluster Upgrade through automation HOT 2
- Upgrade submodule versions HOT 1
- Allow public ssh key to be passed in variables instead of only file path
- Update to operator v1.0.11 and bastion to v1.0.6
- Update operator module version so kubectl can be installed
- reverse 1.3.0 and 1.3.1
- Upgrade operator module to v1.0.14
- update operator module to 1.0.15 to avoid name collision with dynamic group for operator
- Validate module for Terraform 0.13
- Use all 2.0 submodules
- By default module is bastion enabled and operator enabled but documentation says its optional , so default has to be disabled in codebase HOT 5
- Add logging to base module HOT 1
- Refactor input variables into primitive and collection types
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terraform-oci-base.