GithubHelp home page GithubHelp logo

Comments (10)

saurabhuja avatar saurabhuja commented on May 27, 2024

Either it should be in document to use only child compartment for this module or code should behave properly for root compartment as well as for child together. That logic is currently missing to take of that scenario.

from terraform-oci-base.

hyder avatar hyder commented on May 27, 2024

Why would you create this in the root compartment?

from terraform-oci-base.

saurabhuja avatar saurabhuja commented on May 27, 2024

Bydefault, every default user gets root comparment and might tend to go with it unless mentioned in document or error output needs to be more accurate instead of below-
"data.oci_identity_compartments.compartments_id.compartments is empty list of object"
More significant for non corporates which tend to directly work on root compartment, may be.
Only concern is, message to have more clear that "you have chosen root compartment for OKE clusters and its not supported with this module"

from terraform-oci-base.

hyder avatar hyder commented on May 27, 2024

This is the base module, not the OKE module.

from terraform-oci-base.

saurabhuja avatar saurabhuja commented on May 27, 2024

Same issue in both because OKE module uses this one.

from terraform-oci-base.

hyder avatar hyder commented on May 27, 2024

This should be documentation then.

from terraform-oci-base.

hyder avatar hyder commented on May 27, 2024

Will you be adding the documentation?

from terraform-oci-base.

saurabhuja avatar saurabhuja commented on May 27, 2024

yes, i will update.

from terraform-oci-base.

saurabhuja avatar saurabhuja commented on May 27, 2024

Sorry, was busy, This is pull request- #62

from terraform-oci-base.

hyder avatar hyder commented on May 27, 2024

Resolved in #62

from terraform-oci-base.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.