GithubHelp home page GithubHelp logo

oracle-terraform-modules / terraform-oci-base Goto Github PK

View Code? Open in Web Editor NEW
40.0 13.0 35.0 223 KB

terraform-oci-base for Oracle Cloud Infrastructure provides a reusable Terraform module that provisions a minimal infrastructure on OCI, including a VCN, an optional bastion host and an optional internal admin server

License: Universal Permissive License v1.0

HCL 100.00%
oci terraform terraform-modules infrastructure bastion

terraform-oci-base's People

Contributors

djelibeybi avatar gabetocci avatar hyder avatar karthicgit avatar kumar-dhanagopal avatar marciozampiron avatar ronabop avatar saurabhuja avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

terraform-oci-base's Issues

Support Cluster Upgrade through automation

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

  1. Upgrade Master Nodes on an existing terraform deployed oke cluster
  2. Upgrade Worker Nodes on an existing terraform deployed oke cluster

New or Affected Resource(s)

Potential Terraform Configuration

# Copy-paste any Terraform configurations for how the requested feature may be used. 

References

https://docs.cloud.oracle.com/en-us/iaas/Content/ContEng/Tasks/contengupgradingk8smasternode.htm
https://docs.cloud.oracle.com/en-us/iaas/Content/ContEng/Tasks/contengupgradingk8sworkernode.htm

update operator module to 1.0.15 to avoid name collision with dynamic group for operator

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

New or Affected Resource(s)

Potential Terraform Configuration

# Copy-paste any Terraform configurations for how the requested feature may be used. 

References

Provider not defined for non-home region?

@hyder - Hi Ali, when I tested the terraform-oci-base config the other day, I had set region to us-ashburn-1 and everything worked. But when I tested with region=us-phoenix-1 today, the resources were still created in Ashburn (the home region)! I suspect that only one provider is defined, i.e., for the home region. Am I missing anything?

Use compartment_id to create the instance principal policy

@hyder , per our email conversation...

To create the policy we could use the compartment_id instead of compartment_name:

Allow dynamic-group base-bastion-instance-principal to manage all-resources in compartment id <ocid>

If we take this route, then we can remove compartment_name from the list of input variables. Please consider this suggestion.

data.oci_core_images.oracle_images returns empty tuple

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version and Provider Version

0.12.16

Affected Resource(s)

autonomous_image_id = lookup(data.oci_core_app_catalog_subscriptions.autonomous_linux[0].app_catalog_subscriptions[0], "listing_resource_id")
oracle_image_id = data.oci_core_images.oracle_images[0].images.0.id

Terraform Configuration Files

bastion/locals.tf

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. 
# Please remove any sensitive information from configuration files before sharing them. 

Debug Output

Panic Output

Expected Behavior

Actual Behavior

Error: Invalid index on modules\base\bastion\locals.tf line 13, in locals: 13: oracle_image_id = data.oci_core_images.oracle_images[0].images.0.id

data.oci_core_images.oracle_images is empty tuple
The given key does not identify an element in this collection value.

Steps to Reproduce

  1. terraform plan

Important Factoids

References

Remove ip.finish

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The need to introduce a delay for instance_principal was a red herring. oracle-terraform-modules/terraform-oci-oke#156

We can remove it.

New or Affected Resource(s)

Potential Terraform Configuration

# Copy-paste any Terraform configurations for how the requested feature may be used. 

References

Add a mechanism so solutions built on top of base know when the instance_principal group and policy have been created.

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Some solutions require the instance_principal on the admin host to be enabled after which they issue oci commands from the admin host. In such cases, they also need to know when the instance_principal is effective so that the oci commands are run successfully. See oracle-terraform-modules/terraform-oci-oke#143 for more details.

We should add a file on the admin host so that users can look and wait for its creation before they can proceed.

New or Affected Resource(s)

Potential Terraform Configuration

# Copy-paste any Terraform configurations for how the requested feature may be used. 

References

Add schema for resource manager

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

https://docs.cloud.oracle.com/en-us/iaas/Content/ResourceManager/Concepts/terraformconfigresourcemanager.htm

Add logging to base module

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

We should be able to add VCN flow logs, bastion and operator logs as well as any other infra that is created on top of the base module.

New or Affected Resource(s)

Potential Terraform Configuration

# Copy-paste any Terraform configurations for how the requested feature may be used. 

References

Add a README as asciidoc is not recognized by terraform registry

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

New or Affected Resource(s)

Potential Terraform Configuration

# Copy-paste any Terraform configurations for how the requested feature may be used. 

References

reverse 1.3.0 and 1.3.1

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version and Provider Version

Affected Resource(s)

Terraform Configuration Files

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. 
# Please remove any sensitive information from configuration files before sharing them. 

Debug Output

Panic Output

Expected Behavior

Actual Behavior

Steps to Reproduce

  1. terraform apply

Important Factoids

References

Add tagging

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Add tagging for resources

New or Affected Resource(s)

  • Define an interface to accept tag values
  • Tag all resources
  • Document pre-requisites

Update operator module version so kubectl can be installed

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version and Provider Version

Affected Resource(s)

Terraform Configuration Files

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. 
# Please remove any sensitive information from configuration files before sharing them. 

Debug Output

Panic Output

Expected Behavior

Actual Behavior

Steps to Reproduce

  1. terraform apply

Important Factoids

References

Allow public ssh key to be passed in variables instead of only file path

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

New or Affected Resource(s)

Potential Terraform Configuration

# Copy-paste any Terraform configurations for how the requested feature may be used. 

References

Broken doc links in Readme.md

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version and Provider Version

Affected Resource(s)

Terraform Configuration Files

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. 
# Please remove any sensitive information from configuration files before sharing them. 

Debug Output

Panic Output

Expected Behavior

Actual Behavior

Steps to Reproduce

  1. terraform apply

Important Factoids

References

Use terraform-oci-vcn module, terraform-oci-bastion, terraform-oci-operator

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Use terraform-oci-vcn module: https://github.com/oracle-terraform-modules/terraform-oci-vcn
instead of managing base as a monolithic module.

New or Affected Resource(s)

Potential Terraform Configuration

# Copy-paste any Terraform configurations for how the requested feature may be used. 

References

vcn tags are hardcoded

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version and Provider Version

Affected Resource(s)

In the vcn module definition, the tags are hardcoded instead of taken from the variables.

Terraform Configuration Files

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. 
# Please remove any sensitive information from configuration files before sharing them. 

Debug Output

Panic Output

Expected Behavior

Actual Behavior

Steps to Reproduce

  1. terraform apply

Important Factoids

References

Broken link for notifications in README

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

The notifications documentation link on the README gives a 404 error.

oci_ons_notification_topic.bastion_notification is empty tuple when bastion is disabled

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version and Provider Version

Affected Resource(s)

modules\base\modules\bastion\datasources.tf

data "oci_ons_notification_topic" "bastion_notification" {
#Required
topic_id = oci_ons_notification_topic.bastion_notification[0].topic_id
count = (var.oci_bastion.bastion_enabled == true && var.oci_bastion_notification.notification_enabled == true) ? 1 : 0
}

Terraform Configuration Files

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. 
# Please remove any sensitive information from configuration files before sharing them. 

Debug Output

Panic Output

Expected Behavior

Actual Behavior

Steps to Reproduce

  1. terraform apply

Important Factoids

References

oracle-terraform-modules/terraform-oci-oke#121

Consider replacing the quickstart doc with a link to the solution guide

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Consider replacing the quickstart doc with a link to the solution guide

Allow users to specify image_id for bastion

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

New or Affected Resource(s)

resource "oci_core_instance" "bastion" {
....
source_details {
source_type = "image"
source_id = lookup(data.oci_core_app_catalog_subscriptions.autonomous_linux.app_catalog_subscriptions[0], "listing_resource_id") //allow option to specify bastion image id here
}
....
}

Potential Terraform Configuration

# Copy-paste any Terraform configurations for how the requested feature may be used. 

image_id = "...."

References

Use Autonomous Platform image instead of the Marketplace image.

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The Autonomous Linux image is now available as a platform image. We should use that instead of the Marketplace image for the bastion host.

New or Affected Resource(s)

datasources.tf in bastion module

This modules doesnt works with root compartment instead child compartment

terraform plan give below error for root compartment provided in tfvars file, but works fine with child compartment id--
module.bastion.oci_core_instance.bastion[0]: Refreshing state... [id=ocid1.instance.oc1.ap-mumbai-1.anrg6ljrbrnzudqcd55dlcmtirxqkc5ph6cndyusq6vbf2xb7i2pelb266ta]

Error: Invalid index

on modules/admin/instance_principal.tf line 42, in resource "oci_identity_policy" "admin_instance_principal":
42: statements = ["Allow dynamic-group ${oci_identity_dynamic_group.admin_instance_principal[0].name} to manage all-resources in compartment id ${data.oci_identity_compartments.compartments_id.compartments.0.id}"]
|----------------
| data.oci_identity_compartments.compartments_id.compartments is empty list of object

The given key does not identify an element in this collection value.

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version and Provider Version

Affected Resource(s)

Terraform Configuration Files

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. 
# Please remove any sensitive information from configuration files before sharing them. 

Debug Output

Panic Output

Expected Behavior

Actual Behavior

Steps to Reproduce

  1. terraform apply

Important Factoids

References

Make the notification & subscription resources dependent on the bastion instance

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Affected Resource(s)

oci_ons_notification_topic
oci_ons_subscription

Terraform Configuration Files

modules/bastion/ons.tf

Expected Behavior

When bastion_enabled = false, the notification topic and the subscription for the bastion must not be created.

Actual Behavior

The notification topic and the subscription for the bastion are created even if bastion_enabled = false

Update to operator v1.0.11 and bastion to v1.0.6

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

New or Affected Resource(s)

Potential Terraform Configuration

# Copy-paste any Terraform configurations for how the requested feature may be used. 

References

data.oci_core_images.autonomous_images.images is empty list of object when selecting Autonomous

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version and Provider Version

Affected Resource(s)

oci_core_images.autonomous_images

The operating system name has changed since last commit. It should now be "Oracle Autonomous Linux".

Terraform Configuration Files

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. 
# Please remove any sensitive information from configuration files before sharing them. 

Expected Behavior

Running terraform plan should be successful.

Actual Behavior

Running terraform plan returns the following:

Error: Invalid index on modules\bastion\locals.tf line 12, in locals: 12: bastion_image_id = var.oci_bastion.bastion_image_id == "Autonomous" ? data.oci_core_images.autonomous_images.images.0.id : var.oci_bastion.bastion_image_id |---------------- | data.oci_core_images.autonomous_images.images is empty list of object The given key does not identify an element in this collection value.

Steps to Reproduce

  1. terraform plan

Important Factoids

References

Update bastion and operator version to avoid error with image version not existing

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version and Provider Version

Affected Resource(s)

Terraform Configuration Files

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. 
# Please remove any sensitive information from configuration files before sharing them. 

Debug Output

Panic Output

Expected Behavior

Actual Behavior

Steps to Reproduce

  1. terraform apply

Important Factoids

References

oci cli tool is not installed on the admin host.

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version and Provider Version

Affected Resource(s)

Terraform Configuration Files

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. 
# Please remove any sensitive information from configuration files before sharing them. 

Debug Output

Panic Output

Expected Behavior

oci cli tool installed on admin host

Actual Behavior

oci cli tool installed on admin host

Steps to Reproduce

  1. terraform apply

Important Factoids

References

oracle-terraform-modules/terraform-oci-oke#126

Update terraform-oci-base to include admin server

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

To perform administrative tasks using oci-cli from a host, it is required for the host to have instance_principal. This removes the need to to upload keys, and setting up oci-cli configuration.

Allowing the bastion instance_principal access is not a good idea. Instead, we can use an internal admin server with instance_principal access that resides on a private subnet. The bastion host is then used as jump host only.

New or Affected Resource(s)

New module for admin host

Potential Terraform Configuration

# Copy-paste any Terraform configurations for how the requested feature may be used. 

References

Upgrade submodule versions

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

New or Affected Resource(s)

Potential Terraform Configuration

# Copy-paste any Terraform configurations for how the requested feature may be used. 

References

Invalid index when bastion is disabled

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version and Provider Version

0.12

Affected Resource(s)

data "oci_core_images" "autonomous_images" and locals in bastion module

Terraform Configuration Files

datasources.tf and locals.tf in bastion module

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. 
# Please remove any sensitive information from configuration files before sharing them. 

Debug Output

Error: Invalid index

on modules\bastion\locals.tf line 12, in locals:
12: bastion_image_id = var.oci_bastion.bastion_image_id == "Autonomous" ? data.oci_core_images.autonomous_images[0].images.0.id : var.oci_bastion.bastion_image_id
|----------------
| data.oci_core_images.autonomous_images is empty tuple

The given key does not identify an element in this collection value.

Panic Output

Expected Behavior

Actual Behavior

Steps to Reproduce

  1. terraform plan

Important Factoids

References

Meet guidelines to publish to hashicorp's registry

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

  1. Outputs description
  2. Absolute Links

New or Affected Resource(s)

Potential Terraform Configuration

# Copy-paste any Terraform configurations for how the requested feature may be used. 

References

Validate module for Terraform 0.13

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

New or Affected Resource(s)

Potential Terraform Configuration

# Copy-paste any Terraform configurations for how the requested feature may be used. 

References

Make label_prefix optional

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Make level prefix optional by passing appropriate values to submodules. Also change vcn module to 1.0.3

Document IAM requirements

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Document all OCI IAM requirements:

  1. on a separate page
  2. in the form of a table

Things to document:

  1. Dynamic group
  2. Policies
  3. Notifications

Upgrade operator module to v1.0.14

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

New or Affected Resource(s)

Potential Terraform Configuration

# Copy-paste any Terraform configurations for how the requested feature may be used. 

References

By default module is bastion enabled and operator enabled but documentation says its optional , so default has to be disabled in codebase

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version and Provider Version

terraform --version
Terraform v0.14.7

  • provider registry.terraform.io/hashicorp/oci v4.14.0
  • provider registry.terraform.io/hashicorp/template v2.2.0

Affected Resource(s)

oci_core_instance
bastion

Terraform Configuration Files

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. 
# Please remove any sensitive information from configuration files before sharing them. 

Debug Output

Panic Output

Expected Behavior

By filling mandatory parameters, terraform plan should pass.

Actual Behavior

terraform plan fails for bastion resources creation as it is set as default enabled etc. Either documentation should says its mandatory or it should be default false in codebase

Steps to Reproduce

  1. terraform apply
    a) Fill mandatory parameters
    b) terraform init
    Terraform has been successfully initialized!
    c) terraform plan

Error: Invalid function argument

on .terraform/modules/bastion/compute.tf line 29, in resource "oci_core_instance" "bastion":
29: ssh_authorized_keys = var.ssh_public_key != "" ? var.ssh_public_key : file(var.ssh_public_key_path)
|----------------
| var.ssh_public_key_path is ""

Invalid value for "path" parameter: failed to read ..

Error: Invalid function argument

on .terraform/modules/operator/compute.tf line 35, in resource "oci_core_instance" "operator":
35: ssh_authorized_keys = var.ssh_public_key != "" ? var.ssh_public_key : file(var.ssh_public_key_path)
|----------------
| var.ssh_public_key_path is ""

Invalid value for "path" parameter: failed to read ..

Important Factoids

References

Refactor input variables into primitive and collection types

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The input variables to this module currently use structural types (object/tuples) and this is a bit difficult to pass/render as input when used in ORM, command line arguments. Users also struggle with initializing and passing the correct arguments to it.

We propose that we revert to using a primitive and collection types (list, map, set) only. The changes would be reflected in a major version.

New or Affected Resource(s)

Potential Terraform Configuration

# Copy-paste any Terraform configurations for how the requested feature may be used. 

References

Use instance configuration and instance pool for bastion and admin servers

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

New or Affected Resource(s)

Use instance_configuration and pool for bastion and admin servers to ensure a minimum of 1 instance for each

Potential Terraform Configuration

# Copy-paste any Terraform configurations for how the requested feature may be used. 

References

Add timezone variable in terraform.tfvars.example

In terraform.tfvars, I had to add a timezone variable for terraform apply to work. I wasn’t sure what string format the time zone should be in. So I tried the IANA time zone format, β€œAmerica/Los_Angeles”, and it worked. Please add this variable to terraform.tfvars.example, with a comment about the time zone format.

Update example module code and docs

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

After the changes in #7, #8 and #10, update the docs for the example gitlab module.

Also, finish load balancer example code.

Remove ssh_private_key_path variable

@hyder , in our offline email exchange, you clarified that the ssh_private_key_path variable is not needed for the bastion module, and asked me to file an issue to remove it.

Duplicate label prefix in bastion notification name

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version and Provider Version

Affected Resource(s)

Terraform Configuration Files

Both locals.tf in root and ons.tf in bastion have the label prefix.

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. 
# Please remove any sensitive information from configuration files before sharing them. 

Debug Output

Panic Output

Expected Behavior

Actual Behavior

Steps to Reproduce

  1. terraform apply

Important Factoids

References

Use all 2.0 submodules

Community Note

  • Please vote on this issue by adding a πŸ‘ reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

New or Affected Resource(s)

Potential Terraform Configuration

# Copy-paste any Terraform configurations for how the requested feature may be used. 

References

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.