orchestral / dusk-updater Goto Github PK

This may require symfony/process and version comparison to check if we need to update ChromeDriver.

It seems it's changed since 115 to use the new endpoints: https://github.com/GoogleChromeLabs/chrome-for-testing#json-api-endpoints

Laravel already takes this into account:
https://github.com/laravel/dusk/blob/7.x/src/Console/ChromeDriverCommand.php

Can we backport this here?

• Package Version: 7.7
• Laravel Dusk Version: 7.7
• PHP Version: 8.1

Description:

When I run the two basic commands, I get the following result

Is it normal to get results on update command and on detect --auto-update to get this exception and if I debug the process I get the errorOutput /usr/bin/google-chrome: not found

Steps To Reproduce:

Just run on ubuntu 22 using Laravel sail (Laravel 9) the commands update command and on detect --auto-update

• Package Version: 1.5.1
• Laravel Dusk Version: 7.1.1
• PHP Version: 8.0.24

Description:

When attempting to run update command, the error Unable to retrieve ChromeDriver [106.0.5249.61] appears. This appears to be due to a change in the url for Mac m1 chromedriver binaries. See SeleniumHQ/selenium#11066

Steps To Reproduce:

On M1 Mac, run update command

This is to allow installation of ChromeDriver outside of the normal vendor/laravel/dusk/bin directory.

• Package Version: v1.2.1
• Laravel Dusk Version: v5.11.0
• PHP Version: 7.4.4

Description:

dusk-updater detect is unable to find the chrome installation when on WSL since the OS detection identifies it as windows. This is because $PHP_OS returns "win", which is more likely a php problem, but not one that's likely to be fixed anytime soon.

Additionally, I'm unable to simply pass in the path to the chrome installation because:

[InvalidArgumentException]
Chrome version cannot be detected in custom installation path on Windows.

Steps To Reproduce:

1. Start with a Windows 10 machine with an ubuntu instance running in WSL, with php and chromium-browser installed
2. Setup a project that uses dusk-updater.
3. Run ./vendor/bin/dusk-updater detect --auto-update

Recommendation

Use php_uname('s') instead. On WSL Ubuntu, it correctly returns "Linux". Native windows returns "Windows NT". I don't have a Mac to test, but I would expect "Darwin" (https://www.php.net/manual/en/function.php-uname.php)