GithubHelp home page GithubHelp logo

Comments (4)

oriolmirosa avatar oriolmirosa commented on July 22, 2024

Yes, I agree. I'm even more concerned about the color for comments in the cells, which is even harder to see since the background within the cell is lighter, and thus the comments are harder to discern. I won't have time to work on this right away, but I'll try to test a few different options. Thanks for bringing this up!

from jupyterlab_materialdarker.

oriolmirosa avatar oriolmirosa commented on July 22, 2024

Version 0.3.6 fixes this as well as the color of the comments. Let me know if you have any feedback!

from jupyterlab_materialdarker.

secsilm avatar secsilm commented on July 22, 2024

Thanks for your quickly fix.

I tried reinstalling the extension and the version is still 0.3.1. The output is the following:

> C:\Users\secsi\AppData\Local\Continuum\anaconda3\npm.CMD pack @oriolmirosa/jupyterlab_materialdarker
oriolmirosa-jupyterlab_materialdarker-0.3.6.tgz
> C:\Users\secsi\AppData\Local\Continuum\anaconda3\npm.CMD pack @oriolmirosa/[email protected]
oriolmirosa-jupyterlab_materialdarker-0.3.1.tgz
Incompatible extension:

"@oriolmirosa/[email protected]" is not compatible with the current JupyterLab
Conflicting Dependencies:
JupyterLab              Extension        Package
>=0.16.3 <0.17.0        >=0.18.2 <0.19.0 @jupyterlab/application
>=0.16.4 <0.17.0        >=0.18.2 <0.19.0 @jupyterlab/apputils

Found compatible version: 0.3.1
> C:\Users\secsi\AppData\Local\Continuum\anaconda3\npm.CMD pack @oriolmirosa/[email protected]
oriolmirosa-jupyterlab_materialdarker-0.3.1.tgz
> node C:\Users\secsi\AppData\Local\Continuum\anaconda3\lib\site-packages\jupyterlab\staging\yarn.js install
yarn install v1.5.1
info No lockfile found.
[1/4] Resolving packages...
warning @oriolmirosa/jupyterlab_materialdarker > npm > [email protected]: This version mistakenly dropped node@4 compatibility in a semver-patch release. Please stay on 1.6.2 or update to 2 or latest
warning @oriolmirosa/jupyterlab_materialdarker > npm > [email protected]: this version has a breaking change. use 1.1.0 or upgrade to latest
warning @oriolmirosa/jupyterlab_materialdarker > npm > npm-registry-fetch > make-fetch-happen > socks-proxy-agent > [email protected]: If using 2.x branch, please upgrade to at least 2.1.6 to avoid a serious bug with socket data flow and an import issue introduced in 2.1.0
warning css-loader > cssnano > postcss-merge-rules > [email protected]: Browserslist 2 could fail on reading Browserslist >3.0 config used in other tools.
warning css-loader > cssnano > postcss-merge-rules > caniuse-api > [email protected]: Browserslist 2 could fail on reading Browserslist >3.0 config used in other tools.
warning css-loader > cssnano > autoprefixer > [email protected]: Browserslist 2 could fail on reading Browserslist >3.0 config used in other tools.
[2/4] Fetching packages...
info [email protected]: The platform "win32" is incompatible with this module.
info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
warning "@jupyterlab/json-extension > [email protected]" has incorrect peer dependency "react@^15.0.0".
warning "@jupyterlab/json-extension > [email protected]" has incorrect peer dependency "react-dom@^15.0.0".
warning "@jupyterlab/vdom-extension > @nteract/[email protected]" has incorrect peer dependency "react@^15.6.1".
[4/4] Building fresh packages...
success Saved lockfile.
Done in 637.34s.
> node C:\Users\secsi\AppData\Local\Continuum\anaconda3\lib\site-packages\jupyterlab\staging\yarn.js run build:prod
yarn run v1.5.1
$ webpack --config webpack.prod.config.js
Hash: 2615331606cdbd00aac2
Version: webpack 2.7.0
Time: 37167ms
                                 Asset     Size  Chunks                    Chunk Names
        vendor.6a86007c210613833369.js  1.57 MB       2  [emitted]  [big]  vendor
  912ec66d7572ff821749319396470bde.svg   444 kB          [emitted]  [big]
  674f50d287a8c48dc19ba404d20fe713.eot   166 kB          [emitted]
 fee66e712a8a08eef5805a46892932ad.woff    98 kB          [emitted]
af7ae505a9eed503f8b8e6982036873e.woff2  77.2 kB          [emitted]
             0.279ec850a9242db04c85.js   465 kB       0  [emitted]  [big]
          main.343a89ba2a406596a6ea.js  2.25 MB       1  [emitted]  [big]  main
  b06871f281fee6b241d60582ae9369b9.ttf   166 kB          [emitted]
      manifest.7512b7c82077057246ae.js  1.62 kB       3  [emitted]         manifest
         0.279ec850a9242db04c85.js.map  1.35 MB       0  [emitted]
      main.343a89ba2a406596a6ea.js.map  7.67 MB       1  [emitted]         main
    vendor.6a86007c210613833369.js.map  5.69 MB       2  [emitted]         vendor
  manifest.7512b7c82077057246ae.js.map  8.24 kB       3  [emitted]         manifest
                            index.html  1.53 kB          [emitted]
[/sZe] ./~/@phosphor/commands/lib/index.js 33.3 kB {2} [built]
[2Kj9] ./~/@phosphor/widgets/lib/index.js 1.38 kB {2} [built]
[6nap] ./~/ajv/lib/ajv.js 15.2 kB {2} [built]
[cYMN] ./~/@phosphor/virtualdom/lib/index.js 21 kB {2} [built]
[dyOy] ./~/url-parse/index.js 11.4 kB {2} [built]
[hKoQ] ./~/es6-promise/dist/es6-promise.js 28.6 kB {2} [built]
[kzCB] ./~/path-posix/index.js 6.94 kB {2} [built]
[l9te] ./~/@phosphor/application/lib/index.js 18.1 kB {2} [built]
[lMhA] ./~/@phosphor/dragdrop/lib/index.js 33.7 kB {2} [built]
[nh00] ./~/@phosphor/disposable/lib/index.js 4.24 kB {2} [built]
[o73R] ./~/sanitize-html/index.js 11.2 kB {2} [built]
[qzHn] ./~/@phosphor/coreutils/lib/index.js 721 bytes {2} [built]
[rplX] ./~/whatwg-fetch/fetch.js 13 kB {1} [built]
   [8] multi @phosphor/algorithm @phosphor/application @phosphor/commands @phosphor/coreutils @phosphor/datagrid @phosphor/disposable @phosphor/domutils @phosphor/dragdrop @phosphor/messaging @phosphor/properties @phosphor/signaling @phosphor/virtualdom @phosphor/widgets ajv ansi_up codemirror comment-json es6-promise marked moment path-posix react react-dom sanitize-html url-parse xterm 328 bytes {2} [built]
   [9] multi whatwg-fetch ./build/index.out.js 40 bytes {1} [built]
    + 2215 hidden modules
Child html-webpack-plugin for "index.html":
    [3IRH] (webpack)/buildin/module.js 517 bytes {0} [built]
    [DuR2] (webpack)/buildin/global.js 509 bytes {0} [built]
    [GTAU] ./~/html-loader!./templates/partial.html 420 bytes {0} [built]
    [M4fF] ./~/lodash/lodash.js 540 kB {0} [built]
    [vxCX] ./~/html-webpack-plugin/lib/loader.js!./templates/template.html 1.41 kB {0} [built]
Done in 40.81s.

There seems to be a compatibility problem. My jupyterlab version is 0.32.1. How to solve this problem?

from jupyterlab_materialdarker.

oriolmirosa avatar oriolmirosa commented on July 22, 2024

Yes, the extension has been updated to jupyterlab 0.34, so for it to work you should update to that version. Are you unable to do so?

Your other option is to use an earlier version of the materialdarker extension, but that won't have the fixes that include the new colors in 0.3.6. You can see the versions available in the 'versions' tab of this page:

https://www.npmjs.com/package/@oriolmirosa/jupyterlab_materialdarker

If you want to install 0.3.2, you would do this:

jupyter labextension install @oriomirosa/[email protected]

from jupyterlab_materialdarker.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.