ornl / cabanapf Goto Github PK

With Cabana#744, Cabana now supports specifying the filename when using BOVwriter. This will remove dependency on std::filesystem for outputing on Frontier, allowing us to get c grids on Frontier.

• 3d output
• 3d test

Deprecated in Cabana 0.6 and planned to be removed

Proposed renaming test files in #16; also useful to prepend all source files with CabanaPF_ for clarity and shared installs

File read is done on the host into the stored device view

This is required for a PFHub upload.

Here are a list of suggestions for cleaning up the code from its state in !7. None of these involve correctness, but are more focused on usability. These changes, if we decide to make them, can be after the 0.1 release if necessary.

• Users will want to vary CabanaPF::PFHub1aBase::END_TIME since that isn't given in the spec (and we've discussed this in terms of the PFHub upload). It should be an option at construction (a default of 250 is ok).
• The "PerformanceRuns" executable should also be able to have a user-set time step and/or number of time steps so you can do individual runs like the "PFHub1a_Benchmark" and "PFHub1a_Periodic" collection of calculations.
• The main functions the "Benchmark" cases are only 40 lines, but they are identical except for which child of PFHub1aBase they use. It seems more intuitive to merge them into one function with a selection statement for which case to run based on e.g. a command line argument. Maybe you could do something fancy with base class pointers so that you only have to do that selection statement once? (Not something that I'm very strong with.)
• I'm not sure that using fft for a forward transform and ifft for an inverse transform in CabanaPF::PFVariables is the most intuitive, unless that's standard elsewhere. I prefer the interface that FFTW and heFFTe use, where you're specifying "forward" or "inverse". I'd prefer fft_forward and fft_inverse.
  Since the code is written to work in both 2 and 3 dimensions, it should have a 3D test