osinet / qa Goto Github PK

Replace the home-grown plugin system with the standard D8/D9 plugins architecture.

Probably should go in a submodule which can remain enabled even if the main audit-oriented QA module is not enabled.

Currently, versioned dependencies appear like "menu (> 7.11)", causing duplicate displays with normal dependencies like "menu".

The plugin should gather them together, either simply merging the dependencies and ignoring the version requirements, or gathering them with a representation of the multiples version dependencies.

When a project is not declared in the info.yml file, and not available through other means, it is linked to the default project, which always has enabled modules, causing such unused projects not to be discovered.

The discovery process needs to be smarter and obtain project information, possibly from the d.o. API or some heuristics based on the filesystem layout.

One possibility might be to check how update and upgrade_manager access the project information in these cases.

The existing 8.x-1.x HEAD is only usable with Drush 8 which is no longer recommended after Drupal 8.5, and is likely to not work at all in 8.7.

This is needed to work on Drupal 9 and useful in late Drupal 8 versions.

Most content entities can be standalone, unlike taxonomy terms which are meant to be used as classifiers for other types of content.

This check identifies terms which are present but not referenced by any other content entity, or only by other terms. Manual review is needed starting from there to identify which are really unneeded, as some terms may be predefined for later use, or used only as parents of other used terms.

Extension status has evolved a lot since D7, with the removal of the system table and the installed but not enabled state.

In audit situations, some modules are typically added, like QA itself : it would be convenient to provide a way to ignore some modules. Use cases:

• ignoring audit-added modules like QA or Schema
• ignoring core modules
• ignoring or only examining specific big packages, like Drupal Commerce
• ignoring disables modules
• ignoring, or just displaying, themes, libraries

Currently the D8/D9 version is only usable with Drush, the Web UI pages are just placeholders.

They need to be plugged with the command implementations to offer a choice between web and CLI usage.

Needs

• Drush 10 (cf #7)
• composer.json / qa.info.yml upgrade
• upgrade_status compliance

Currently, Undeclared

• only checks direct dependencies
• considers required modules (normally only present in core) as undeclared dependencies. Since these are always present, they need not be considered as undeclared

Custom modules frequently uses code from other custom modules without declaring its dependency, assuming both are always deployed.

This check attempts to detect such missing dependencies.

In its first versions it will not attempt to be exhaustive, but just identify (a) function calls (b) in module files (c) calling functions (d) in other module files. Later versions could track OO code and/or check availability with the autoloader.