osk2 / ptt-comment-flag Goto Github PK

Some comments in this post are failed to process.

Both IP regex validation and HTML format of the comment seems just fine. Not sure what's broken.

Attachment:

如題

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

Not every user uses Ptt web, we should consider supporting other app like PttChrome and term.ptt.cc.

這個功能是想要解決你的什麼問題？
像是這篇據說是第一篇風向文，發文者 IP 現在用 whois 也能查到是中國北京

你的想法/建議是？
插旗

其他相關資訊

Some user found IP still useful even if it there's already have the flag for each comment.
We should keep it on page.

We should also support other PTT mirror site.

geoip2 doesn't work with Node.js > 10. We need find some replacements.

1. https://github.com/maxmind/GeoIP2-node
2. https://github.com/runk/node-maxmind

We only process comment currently. Author's ip should be processed too.

Incorrect parse result when there's no IP info in comment. We should just remain it's original state instead showing white flag.