osowskit / atlassian-github-app-addon Goto Github PK

When GitHub's API is down, the app should not crash. Ideally, this should display a message indicating GitHub is unavailable.

Is this by design or a bug ? Seems the former. Once a branch is created off the ticket the "Create Branch" option disappears from the Pane. Since the plug-in's convention is to give the branch the same name as the ticket, I can see that prohibits multiple branches but that could be overcome w/ one extra character for numbering. Just a thought

Users currently install the plug in on Marketplace and see instructions to complete installation when navigating to a JIRA issue. This opens a new tab that takes them to GitHub to log in and install the App.

• Prevent creating a branch outside JIRA window
• Add messaging to notify why they are in a separate tab
• Add instructions to navigate to an issue after the installation is successful.

When you uninstall the App from GitHub but already had a session set up in the plugin, the plugin sends an Internal Server Error

The only way to fix this is to clear the cookie so you can reinstall the app in GitHub

may want to fix this in PR #8

Tokens can (?) expire when generated from a GitHub App.

• Detect when a token has expired or is invalid
• Try generating a new token once

Just installed the app in cloud Jira, but can't get past 'Get Started' screen, the app won't load:

Tried both chrome incognito and safari.

I followed the advice from readme and manually connected the bot using separate browser tab, but the repository selection screen was off and I could only select one repository from an org.

Does this solution work for GitLab in addition to GitHub?

can we configure on how the branches are named?

Most of the code assumes the creation of an app token will succeed. The methods should check for failed app token creation and log users out to reset the session.

This can happen when:

• Re-installing the application

I've just installed it, but it doesn't work.

• I've installed JIRA plugin.
• I've installed GitHub addon.
  • I've allowed access only to one of my organizations, for all repos.
• I've then open some JIRA issue:
  • It shows "Connect to GitHub" and "clear settings" links, but also it show "Add-on is not responding. Wait or cancel?" message.
  • I'm clicking on "Connect to GitHub" and after a couple of redirects I get text "false" in place of "Connect to GitHub" and "clear settings" links.
  • On reloading issue I'm able to see "Connect to GitHub" and "clear settings" links once again.

I've checked Firefox's network requests, and it looks like it gets 404 on https://atlassian-github-app-addon.herokuapp.com/atlassian-connect/all.js - maybe this is the cause.

Summary

To improve the on-boarding experience, add a postInstallPage from the page module. This should instruct new users to OAuth with GitHub and install the App.

There are a number of optimizations that can reduce the API load on GitHub:

• Cache the installation access token and check that it is valid Deployed
• Use conditional requests instead of updating each repository list.

Having two tabs open with separate JIRA issues could result in creating a branch with incorrect information. The branch creation code should query the current page's URL

Hi,
I am using Jira Cloud and I have install addon.
I have completed all steps like in manual. The last one was:
Applications->INTEGRATIONS->DVCS accounts-> Link Github account -> SUCCESS
and as the result no repositories below. Actually I have repositories and they are private.
I have attached screen, please help.

Thanks!

Great plugin!

It would be nice if we could choose to create the branch with:

• a name based on the issue title e.g. ABC-123-slugged-issue-title
• a location based on the issue type e.g. a story creates in feature/ABC-123 and bug in hotfix/ABC-123 to support gitflow

Overview

Use global relay ids when looking up repositories and user GraphQL to pass in an array of ids.

BulkIssue = $GQLClient.parse <<-'GRAPHQL'
query{
  nodes(ids:
  ["MDEwOlJlcG9zaXRvcnk1NjE2NzA2OQ==",
  "MDEwOlJlcG9zaXRvcnk2NDA2NjU==",
  "MDEwOlJlcG9zaXRvcnk4MDQ3MTEyMA=="]
  )
  {
    ... on Repository{
      name
      defaultBranchRef{
        name
      },
      ref (qualifiedName:"SENG-13"){
        name,
        associatedPullRequests(first:10){
          nodes {
              number,
              url,
              baseRef {
                name
              }
            }
        }
      }
    }
  }
}
GRAPHQL

Users that uninstall the App will get a 500 error unless the Installation ID is cleared.

Hi, we have a lot of repositories inside github and when we load all repositories we don't see all repositories inside the list only a few. Are we doing something bad in the config's side or is the normal behaviour of the plugin?

Thanks!

Currently https://atlassian-github-app-addon.herokuapp.com/atlassian-connect.json is different from the source code.

It contains this additional entry:

"postInstallRedirect": {
      "key": "redirect",
      "url": "https://github.com/apps/jira-bot/installations/new"
}

It's only valid for Bitbucket, thus invalid for Jira:
https://developer.atlassian.com/cloud/bitbucket/modules/post-install-redirect/

I'm a user with one personal repo, but I have collaborator access to my work's repos as a part of their Github organization. My work admin installed the GitHub App Plugin for Jira, and I installed the JIRA-bot app in my GitHub account. However, when I try to create a branch, the app only sees my personal repo and none of my work's repos. Tried this with two other co-workers who have owner permissions on their work repos and they couldn't see their work repos either.

Would it be possible to support creating branches in organization repos that a user has access to? I'd love to use this plugin for work. Thanks!

Support when GitHub Apps are supported on GitHub Enterprise.

This was working before, but I have made some changes (consolidated workflows, issue schemes, etc. between projects), and we have 2 repositories in our GitHub account now.

I can see branches that already exist for a Jira issue, but the "create branch" link is not there.

If a JIRA organization admin installs this app for the organization and installs it into a GitHub organization, what configuration is required for individual JIRA / GitHub users to perform?

Does each JIRA user of this plugin need to configure it against their own personal GitHub account, or does it make use of the admin-supplied credentials to create the branches?

Hi Thomas! The app works great with Firefox, but it's not working for me with Chrome browser. When I click on GitHub Development, it says "We're having trouble connecting to GitHub Development. Try contacting the developer for support.". Do you know what could be happening? I guess maybe something with the cookies? Thanks!

Landed on this app from Atlassian community page but could not get it to work with the error in the attachment

When I am creating a new branch workflow triggers won't be triggered. I created the trigger that the transaction should be done when a new branch is created.

I had some problems there, because not the correct email address was used to create a commit or pull request. It must be the same email address as the jira uses for his account. Maybe an option to specify the email address used would be helpful

Created branches through this add-on have each JIRA's issue number as the branch name. I would like to customize branch name like feature/XXXX so that I can follow the git-flow rule.

Thanks in advance.

I recently installed the add-on to connect github repos to jira issues.

The add-on appears to be failing at the point of clicking "create a branch in .... repository". I click, and nothing happens.

Please see screenshot with console image for info. Thanks!

I have received a few requests to support JIRA server. Since I don't have access to an instance, I am blocked on implementing support for this.

My assumption is that this is mostly a packaging exercise. Let me know if you have access to a JIRA Server environment and are willing to help package this add on.

After creating a branch in JIRA, navigating to a new issue doesn't display the correct information.

• Detect when the JIRA ticket and branch ID are different

After installing an App, it will redirect with the installation_id as a URL param. Consider pulling that from a URL param - though perhaps not storing a variable server-side.

https://127.0.0.1:5000/?installation_id=40851

• Strip off URL parameters when creating branch.

Octokit::UnprocessableEntity - POST https://api.github.com/repos/osowskit/about/git/refs: 422 - refs/heads/SENG-2?filter=allopenissues is not a valid ref name. // See: https://developer.github.com/v3/git/refs/#create-a-reference:

Hi Team,

Despite integration of JIRA with Github I don't see "Create branch" button in JIRA tickets:
http://screenshots.client-demo-site.net/scn-20180802-162753-9oxat.png

Please check for better clarifying what I mean:
https://www.youtube.com/watch?v=K78Nk9kFdb0

I assume we're missing something here:
http://screenshots.client-demo-site.net/scn-20180802-162155-v87bp.png

Looking forward to your reply!

Questions

• What happens when there are multiple installations - is this possible?
• Support multiple installations
• What happens when installing an App on an Organization?

Hi,

When creating bug fix branches, we need to use a "release" branch as source, not master.

Is it possible to add a "select source to branch from" to the plugin? Ideally this should be a drop-down like selection, but even a text field would work.

Thanks!

@gleb-gusev I saw you fork this repo. This doesn't contain the lastest code - I hadn't had any serious requests to improve this. Let me know if you are planning on adding support for any of the open issues in this repo and I can gladly help (and push the latest code)

Hi. I'm looking to adapt this code to work with a local instance of jira and GitHub. Anyone interested in participating?

thanks,

Mike

Looks to be for Cloud-only. Add support for standalone/on-premise JIRA installs, please.

We have added added the add-on , but have a lot of issues

Sometimes it connects to the GitHub account and sometimes gives out errors

Also the main reason why we need the add on is to show the branch and pull request

But when we open the ticket from any other browser or user or refresh the page - all the fields above are empty as if nothing was added

From #12 powerman asked:

We're using several repos for same JIRA project, so it's better to ask about repo each time (or let user select more than one repo, or, even better, autodetect all github repos connected to this project) than just remember last choice and require "clear settings" each time we wanna create branch in another repo.

I've recently added this plugin to a repo and it can create branches from master straight up in our repo. However, I'd like it to use gitflow, so create branches from develop and with the name feature/SCC-xxx instead of SCC-xxx.

I created a file .github/jira-bot.yaml with the contents 'branch_pattern: 1' in the root of our repo in the master branch, according to the documentation, and re-added the repo, but it's still creating branches as if this file does not exist and not following gitflow.

Is there something more that needs to be done?

Users have expressed a desire to have more control over the names of branches that are created.

Options

• Pull repo name template from a configuration file in the Repository
• Prompt users for the branch name (textbox input)
• Add a portion of the issue title to the branch

If you have an opinion, please comment below 🙏

https://stackoverflow.com/q/46178234/1375964

When a branch exists, the app shows a link to the branch and and PR associated with it. If the Pull Request doesn't exists, it should show a link that opens the Pull Request.

I'm using JIRA + Github with the same email address. I'm member of multiple JIRA accounts. I authorized to one organization and now, for my personal JIRA, I can't even choose to authorize my own account.

How can I authorize the app to see my own branches as well as another organization's accounts?

I am using JIRA cloud and trying to integrate with github. I've added the github plugin but when I click the Get Started button in the User-installed add-ons section of JIRA's Manage Add Ons page, I get a "Looks like something went wrong!" page.

The current code assumes the default branch is master. This is not required and should query the default branch.

There was an API rate limit issue for a user that had access to 60k repositories. This was returning a sum of installation IDs and was certainly not 60k repositories.

Background:

• Using JIRA Cloud, GitHub.com Business Hosted (Private Repos) and this plug-in to integrate the two.
• DVCS connector also integrated successfully but understood to be unrelated to this plug-in

Goal:

• Create (and view) GitHub branches from JIRA tickets.

Problem Details:

• After installing the plugin in JIRA Cloud, as well as installing the BOT on GitHub (as described here .. https://marketplace.atlassian.com/plugins/com.osowskit.jira.github.app/cloud/overview)

• The GitHub Development Pane displays correctly in JIRA tickets, but server connection to the GitHub Repo. is hanging up or failing (See attached). NOTE: Due to some previous problems, the GitHub side BOT hook was un-installed & re-installed. Related ? Not sure.

ScreenShot (Attached):