GithubHelp home page GithubHelp logo

ottoallmendinger / gnome-shell-screenshot Goto Github PK

View Code? Open in Web Editor NEW
270.0 13.0 53.0 2.02 MB

Gnome Shell extension for making and uploading screenshots

License: MIT License

JavaScript 11.77% Makefile 0.41% CSS 0.11% Shell 0.45% TypeScript 87.26%
gnome-shell-extension gnome screenshot imgur clipboard javascript

gnome-shell-screenshot's People

Contributors

alex-volga avatar alexgluck avatar amivaleo avatar benjozork avatar cmrd-senya avatar cpxondo avatar dependabot[bot] avatar dirosis avatar fastbyte01 avatar iamhefang avatar ibaios avatar jancoow avatar johanbcn avatar kudaliar032 avatar martinpl avatar mavrikant avatar orschiro avatar ottoallmendinger avatar oxayotl avatar pkomur avatar pragmaticlinuxblog avatar randm-ch avatar raphaelrochet avatar saboya avatar tox82 avatar trinaldi avatar vistaus avatar xydone avatar xypine avatar yafp avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

gnome-shell-screenshot's Issues

Gnome shell 3.28 crashes while taking screenshots

Hello,

I am running GNOME Shell 3.28.2 on Debian testing and, since a few days ago, the extension makes gnome-shell to crash as soon as i try to take any screenshot.

sudo journalctl /usr/bin/gnome-shell | grep 20554
Jun 01 09:25:20 lilith gnome-shell[20554]: Some code accessed the property 'KeyClickAction' on the module 'config'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.
Jun 01 09:25:21 lilith gnome-shell[20554]: Some code accessed the property 'SelectionArea' on the module 'selection'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.
Jun 01 09:25:22 lilith gnome-shell[20554]: Some code accessed the property 'getTemp' on the module 'filename'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.
Jun 01 09:25:22 lilith gnome-shell[20554]: g_object_ref: assertion 'G_IS_OBJECT (object)' failed
Jun 01 09:25:22 lilith org.gnome.Shell.desktop[20554]: **
Jun 01 09:25:22 lilith org.gnome.Shell.desktop[20554]: ERROR:../src/shell-screenshot.c:179:write_screenshot_thread: assertion failed: (screenshot != NULL)
Jun 01 09:25:22 lilith org.gnome.Shell.desktop[20554]: == Stack trace for context 0x564e702634d0 ==

Please let me know in case you need other kind of logs

icon gone?

icon become blank one. Does it use the emplty64.png?

-2017-03-02-17 41 46-784x343

Blue overlay is not removed on a second screen

Hi!

I'm on Gnome Shell 3.26.1 & Gnome Screenshot 3.26.0. extensions.gnome.org tells me the Screenshot Tool is up to date, so it should be the v21.

When I selecting a zone on my main screen, everything works fine. But on my second screen (connected by USB-C, 1440p vs 1080p for my main screen, maybe it's important), the blue overlay is not removed from the screenshot.

Main screen:
Main screen

Second screen:
Second screen

Check unicode errors when writing files

Google translate from russian e.o.g comment:

In the Russian version, it tries to save a snapshot to the "Images" folder ... but writes "rubbish with squares" on the way. Vanguuy mistake in with encoding. I ask to correct

Suggestion - upload and copy link

There is allot of free image storage engines with easy API - for example: imgur.com
Please make ability to upload an image and copy to clipboard automaticly

Preferences do not work

Error: Expected type utf8 for Argument 'key' but got type 'undefined'

Stack trace:
buildConfigSwitch@/home/GrandMaster/.local/share/gnome-shell/extensions/[email protected]/prefs.js:51:22
ScreenshotToolSettingsWidget<._makePrefsIndicator@/home/GrandMaster/.local/share/gnome-shell/extensions/[email protected]/prefs.js:117:31
wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
ScreenshotToolSettingsWidget<._initLayout@/home/GrandMaster/.local/share/gnome-shell/extensions/[email protected]/prefs.js:86:12
wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
ScreenshotToolSettingsWidget<._init@/home/GrandMaster/.local/share/gnome-shell/extensions/[email protected]/prefs.js:78:5
wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
buildPrefsWidget@/home/GrandMaster/.local/share/gnome-shell/extensions/[email protected]/prefs.js:538:16
Application<._selectExtension@resource:///org/gnome/shell/extensionPrefs/main.js:91:22
wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
Application<._extensionFound/<@resource:///org/gnome/shell/extensionPrefs/main.js:209:17
main@resource:///org/gnome/shell/extensionPrefs/main.js:402:5
@

:1:43

gnome-3.25.92

Permissions when saving files

I take screenshots, and want to share them with co-workers on my own http/nginx deployment.

But the screenshots are all saved with 0600 permissions, which means unless I change my http user to be my current user, or I manually (or automatically) run chmod on all those files, there's no way for my nginx application to read the screenshots I save.

I can't find in the code where it does this.

$ lsb_release -da
Distributor ID: Debian
Description: Debian GNU/Linux 9.4 (stretch)
Release: 9.4
Codename: stretch

Optional setting to disable the notification?

I have set Gnome Shell Screenshot to auto-save and auto-copy to clipboard.

Hence I don't need this notification shown below.

What do you think of an optional setting to disable notifications? :-)

image

Filenaming of gnome-screenshot

Hi there,
could you please make the default naming scheme follow/like the gnome-screenshot application?
It's quite bad (and unsortable) the current way.

Naming of gnome-screenshot:
{ T R A N SLATION }»Year-Month-Day Hour-Min-Sec«.png
Bildschirmfoto von »2016-12-27 03-23-56«.png

If #9 gets implemented, please allow this as a template, or make it default.

love the beta imgur - user in plan

Love the imgur beta addon i use that now i just found it
are you planning to add user auth to this so the screen shots go to you your account :-0

User-customizeable filename

It would be a great feature if users could define a naming pattern for the screenshots in the extension settings.

Personally i dislike blanks in filenames, timezone isn't important for me and the day/month isn't needed either - all those facts could be solved with a user-defined naming.

It would need some predefined keywords like

  • Date
  • Time
  • Hostname
  • Dimensions

some of those with parameters like

  • Date(Ymd)

in combination with plain strings

Example:
MyUeberScreenshotName_%Date(Ymd)%_%Dimension%_%Hostname%

Results in:
MyUeberScreenshotName_20161123_800x600_pcname.png

Clipboard copy doesn't work after lock screen

When locking the screen and coming back, clipboard copy stops working. Restarting the shell fixes it.

Getting a new clipboard reference via Gtk.Clipboard.get_default() does not seem to help.

Uploading on imgur not working?

Hi, i installed new version for screen shoting but i don't have options with uploading on imgur. I just have select area, select window, whole window and settings, into settings i don't have tabs with imgur like on screenshop in readme, did you tell me what can i do for uploading screens on imgur? Thanks for the patient!

Copying Images to clipboard doesn't work

Fedora 24, Gnome 3.20

When I try to copy a screenshot to the clipboard and then paste into a program (such as GIMP), it doesn't work. Meanwhile using the default Ctrl+PrintSrc shortcut works. Can you reproduce that?

When previous save folder no longer exists

Reproduction steps

  1. Open Screenshot Tool settings
  2. Go to 'Storage'
  3. Change 'Save Location' to a folder
  4. Delete that folder
  5. Take a screenshot

What happened

Nothing happened. No screenshot was taken.

How to fix

  1. Show error message
  2. Create folders (may be nested, i.e. save folder is abc/def/ghi but delete abc)

Add a "clear" feature/menu item

Remove an old screenshot (still shown in the dropdown) that the user may not want anymore. It could be done automatically after a few seconds/minutes (option in settings) or even just manually with a "Clear" menu item. Thanks!

Ability to delay the screenshot

Often its useful to delay the screenshot if you want to bring up some tool tip or popup to be displayed in the screenshot.

Currently it does not look like this is possible and would be a nice feature to have, an OSD counting down would also be a nice feature :)

Reset delay after making screenshot

Hello!

Thank you for delay feature — I've been waiting for this.

But I was confused when screenshots began to be made after some "lag" (as I thought). I was forced to wait for screenshot after selecting area.

Some time later, when I click with right mouse button, instead of usual left, I saw non-zero delay.

Everytime I need to make screenshot with delay — I need it once, and I'm ready to set the new delay for next screenshot.

Please, reset delay after making screenshot (make it one-time), or add a config option for this.

Thanks.

Downscale images from "retina" (hidpi) display

Migrated from: OttoAllmendinger/gnome-shell-imgur#37


When taking a screenshot on retina desktop (which is typically scaled x2), resulting uploaded image has giant 2k width (while scaled "real displayed" is divided by scale factor).

For example, this image:

take a look at original link: http://i.imgur.com/dCDu452.png

The solution might be an option in settings, something like "Downscale from HIDPI display", which uploads not original, but 2x down scaled image.

Selector sometimes visible in screenshot

Regression of #16

https://extensions.gnome.org/errors/view/3766 you need to be logged in apparently

Copy of report:

What's wrong?
Timing error causes area screenshots to contain the selector itself sometimes.  This results in a blue tint over screenshots, which can be very inconvenient. 


What have you tried?
I've looked for a way of either hiding the selector or making a delay, but I lack the experience to do so.


Automatically detected errors:

GNOME Shell Extensions did not detect any errors with this extension.

Version information:

    Shell version: 3.22.3
    Extension version: 11

Add a time to take a screenshot

I suggest to add a timer to take the screenshots, so if you have to take a screenshot after performing any action with the keyboard or mouse, you will have enough time to do it before getting the screenshot.

Suggestion: Set delay for screenshot

Hello!

I'm using gnome-screenshot, but it doesn't allow take screenshot of selected area with delay.

I'm trying this extension, but it doesn't allow set delay for screenshot at all.

Thanks.

Screenshot is blue under Xwayland

Hello,

I've recently upgraded to 18.04 and started using Xwayland which is great.

Versions:

GNOME Shell 3.28.1
wayland 1.19.6-1ubuntu4

How to reproduce:

  1. Log in to Ubuntu 18.04 using Ubuntu on wayland
  2. install gnome screenshot tool via gnome tweaks or extensions.gnome.org
  3. take screenshot
  4. observe blue overlay on the screenshot as attached below:

lpw3vta

The problem does not exist under Xorg.

.scaled images are saved

Hello,

Thank you, it is a very nice extension :-)

But the .scaled image used for notifications should not be saved besides the screenshot itself.
Is it only necessary?

Allow users to upload to custom servers

Hello,

I love your extension, it's well done and works smoothly, but for security reason i can't upload my screenshots on imgur.

So i hacked your code on my laptop and changed these two lines in uploadImgur.js to point your client to my own REST interface.

const clientId = "c5c1369fb46f29e";
const baseUrl = "https://api.imgur.com/3/";

Everything works good, but i wonder if you could allow users to do that via GUI.
In case that you're wondering what servers users could upload to: i wrote my own.

Thanks

Adding a tab with 'About/Version' information

Right now a user can only guess which version of gnome-shell-screenshot he is using as far as i tell.
The metadata.json does not contain a version info either.

The following is supported in metadata.json:

"version": 1

A version number could simply be the commit date or similar if you dislike complex versioning

Why a version number:
I already managed to overwrite my current installed version of gnome-shell-screenshot (with an older version) while visiting https://extensions.gnome.org/ and trusting the offered update-notification.

Ideas about how to
I would love to see an additional tab in the UI featuring:

  • version number
  • the project url

and maybe optional

  • developer name,
  • license and whatever else

If you dislike the idea of an additional tab - how about a small gray footer text on the current UI-tabs.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.