ouf-wow / ouf Goto Github PK

the rune module works fine as long as no deathrunes are created. when deathrunes are created the runes fill up and dont show their cooldown anymore. if they are used they revert to the color they used to have but do not regain their ability to track cooldowns.

Yup, incoming heals are int eh API now. Lets kill HealComm!

realUnit in tags always return nil.

Cataclysm has changed the API for UnitGroupRolesAssigned(unit)

the new API is:
role = UnitGroupRolesAssigned(Unit)

the return value role is of type string, with possible values of "NONE", "TANK", "HEALER", "DAMAGER"

(return values are what I have seen on the beta and read in Blizzard UI code)

Interface\AddOns\oUF\elements\runebar.lua:94: CreateFrame: Couldn't find 'this' in parent object

[C]: ?
[C]: in function `CreateFrame'
Interface\AddOns\oUF\elements\runebar.lua:94: in function `enable'
Interface\AddOns\oUF\ouf.lua:442: in function `EnableElement'
Interface\AddOns\oUF\ouf.lua:289: in function <Interface\AddOns\oUF\ouf.lua:231>
Interface\AddOns\oUF\ouf.lua:307: in function <Interface\AddOns\oUF\ouf.lua:304>
Interface\AddOns\oUF\ouf.lua:357: in function `Spawn'

Got this while trying to spawn a simple runebar.

There are also other issues that are to be brought up with this module, see other issues

Party and Raid seem to work fine now with your lastest commits.

Now, Blizzard raid frame are show while in raid, the container frame is named "CompactRaidFrameContainer". There is also a "CompactRaidFrameManager" frame show with the container.

edit: also clicking party/raid unit to target it seem to work randomly. Sometime we need to click it 2, 3 or 4 times before targeting it.

As the title says, using runes doesnt update it.

On a side note, shouldn't it be .Runes instead of .runes, to match the rest of the elements?

Could you add some checks like this?

local castbar = self.Castbar
local name, rank, text, texture, startTime, endTime, _, castid, interrupt = UnitCastingInfo(unit)
if(not name) then
    castbar.casting = nil -- here!
    castbar:Hide()
    return
end

It seems units with suffix (ex. targettarget, focustarget) need it.

According to the new code, tag syntax is [prefix>tagname<suffix], where it was [(prefix)tagname(suffix)] with 1.3. So [( <)status(>)] should now be written [ <>status<>]. This fails, oUF keeps telling me the tag is invalid. I suspect the getTagName function not to be robust enough to handle it.

I'd think a pattern like ^%[(.-)>(.-)<(.-)%]$ would help parsing these tags but this is not what is used.

From official Blizz change announcement:

• The new event UNIT_CONNECTION is fired if a unit comes back online after a disconnect.

This new event can be registered for elements that check UnitIsConnected to give improved feedback

The latest cataclysm beta changed the name of the constant used to identify holy power and soul shards.

Here are the fixes:

holy power : http://gist.github.com/574498
soul shards : http://gist.github.com/574499

At spawn time the PLAYER_ENTERING_WORLD event is passed through to all elements to cause initialisation to occur.
The EclipseBar element does not run the UNIT_POWER function correctly due to this change: http://github.com/haste/oUF/commit/7716ec41fd6b93be352bd0b9f19ffa85bf253f47

I suggest reverting the change.

The ECLIPSE entry in PowerBarColor consists of two tables, which leaves oUF's power color table for ECLIPSE empty.

http://github.com/tekkub/wow-ui-source/blob/cat/FrameXML/UnitFrame.lua#L10

What steps will reproduce the problem?

1. Target for example a male Royal Dreadguard
2. Switch target to a female Royal Dreadguard
3. The Portrait is still the one from the male guard

What version of the product are you using?
ouf 1.3.28 tested with ouf_Adirelle and ouf_Nivaya

Please provide any additional information below.
The problem occurs only on targets that have the same name but different races, gender etc.

It should be like this:

http://gist.github.com/331133

['perhp'] and ['perpp'] in tags.lua call UnitHealthMax(u) and UnitPowerMax(u) twice, comparing it to itself, rather than UnitHealth(u) and UnitPower(u) respectively.

Branches: 1.4, experimental

-- Thrae

You may have already seen this but I figured I would post something just to make sure. In the 3.3 patch the code from line 185-192 in oUF.lua to hide the Target of Target frame will no longer be needed and will create an error if unchanged. I tested it out just by commenting out the code and it is working fine without it.

This is so we can have different alpha/scale/etc on partyN, partypetN and partyNtarget.

Since the latest bug fix addressing aura issues, the 'aura' buff mode (combining buffs and debuffs) is no longer functional. It will only display debuffs, not buffs.

Reference: http://www.wowinterface.com/portal.php?id=137&a=viewbug&bugid=6494

line 82: trying to get width of a table
line 83: trying to get height of a table
line 84: trying to get texture out of a texture

Thats just the ones I found now

I already have a patch, waiting for next beta patch to test it however.

http://www.wowinterface.com/portal.php?id=137&a=viewbug&bugid=6663

Using Branch: 1.4

Date: 2010-05-02 13:28:25
ID: 1
Error occured in: Global
Count: 38
Message: ..\AddOns\oUF\elements\castbar.lua line 107:
attempt to index global 'castbar' (a nil value)
Debug:
(tail call): ?

oUF\elements\castbar.lua:107:
oUF\elements\castbar.lua:100
(tail call): ?

I get the following error occasionally while in raids, only tested in Wintergrasp so far though. The error is triggered at seemingly a random moment and continues to stack rapidly until a reload.

As you can see I've embedded oUF but I've done it properly and that's never given me issues before. I don't think the error is in my layout, I've updated it according to your example in oUF_Lily.

Message: Interface\AddOns!FreeUI\oUF\ouf.lua:112: attempt to call field '?' (a nil value)
Time: Sat Oct 16 14:52:10 2010
Count: 900
Stack: Interface\AddOns!FreeUI\oUF\ouf.lua:112: in function <Interface\AddOns!FreeUI\oUF\ouf.lua:110>

Locals: self = oUF_FreePartyRaidUnitButton24 {
0 =
MasterLooter = {
}
PARTY_LOOT_METHOD_CHANGED = defined @interface\AddOns!FreeUI\oUF\elements\masterlooter.lua:30
ReadyCheck = {
}
Leader = {
}
UNIT_SPELLCAST_CHANNEL_START = defined @interface\AddOns!FreeUI\oUF\elements\castbar.lua:166
UNIT_SPELLCAST_INTERRUPTIBLE = defined @interface\AddOns!FreeUI\oUF\elements\castbar.lua:100
disallowVehicleSwap = false
Power = {
}
DebuffHighlight = {
}
Health = {
}
RAID_TARGET_UPDATE = defined @interface\AddOns!FreeUI\scripts\unitframes.lua:200
UNIT_SPELLCAST_START = defined @interface\AddOns!FreeUI\oUF\elements\castbar.lua:15
unit = "raid23"
UNIT_SPELLCAST_DELAYED = defined @interface\AddOns!FreeUI\oUF\elements\castbar.lua:128
PARTY_LEADER_CHANGED = defined @interface\AddOns!FreeUI\oUF\elements\leader.lua:13
UNIT_SPELLCAST_STOP = defined @interface\AddOns!FreeUI\oUF\elements\castbar.lua:148
UNIT_SPELLCAST_CHANNEL_STOP = defined @interface\AddOns!FreeUI\oUF\elements\castbar.lua:235
UNIT_FACTION =

There are certain bosses like The Lich King, which switch targets only for a fraction of a second (0.5 in LK's case). Now with bad fps and oUFs current 0.5s OnUpdate it's possible that a target-switch doesn't show up on the targettarget-frame.

I would propose an unit-specific option for layouts to define this update frequency.

SecureAuraHeader has been added to workaround this. However, it's not without some limitations.

More on this here:
http://forums.worldofwarcraft.com/thread.html?topicId=26560499864&postId=267232994300&sid=2000#21

HolyPower doesn't seem to be updating. Here is the thread with everything I was talking about on the WoWI forums: http://www.wowinterface.com/forums/showthread.php?t=34833

here is my code: http://pastie.org/1143643

It is not updating and showing three upon logging in or reloading UI even though I only have zero or 1 holypower. But, if I use Crusader Strike, or Holy Shock, or what Have you, it corrects itself and shows that i have 1, or 2 or the like. And if I use Word of Glory or what ever spell that consumes my HolyPower, it appropriately shows all my HolyPower Runes dissapearing, but if I log in and out or reload UI it shows all three active even though I don't.

Tooltips are no longer displayed upon mousing-over a unit.

The first unit in the group or raid randomly disappears with no errors. I get "Interface action failed because of an AddOn" as a chat message at the same time.

As you said you'd do anyway.

Getting this ready check error when forming a raid.

Message: Interface\AddOns\oUF\elements\readycheck.lua:9: Usage: GetPartyMember(1-4)
Time: Wed Oct 13 20:20:25 2010
Count: 1
Stack: [C]: in function `GetPartyMember'
Interface\AddOns\oUF\elements\readycheck.lua:9: in function <Interface\AddOns\oUF\elements\readycheck.lua:4>
(tail call): ?
(tail call): ?

Locals: (*temporary) = 0

Also, the Blizzard party and raid frames don't hide when there are oUF party or raid frames.

P.S. Can you show an example on how to set individual frame sizes in unit specific options?

Both event handlers UNIT_SPELLCAST_INTERRUPTIBLE and UNIT_SPELLCAST_NOT_INTERRUPTIBLE have an identical code to show/hide Shield icon.

  local shield = self.Castbar.Shield
  if(shield) then
      shield:Hide()
  end

As when you switch or lose targets your combo points should be hidden until the same target is regained. Right now it only reacts to UNIT_COMBO_POINTS.

It may also need to react to any or all of these too: "UNIT_ENTERED_VEHICLE UNIT_ENTERING_VEHICLE UNIT_EXITED_VEHICLE UNIT_EXITING_VEHICLE"

As you already have the check for vehicles that can make combo points but don't switch.

Current Branches: ALL

http://www.wowinterface.com/portal.php?id=137&a=viewbug&bugid=6664

While I don't know of any pets that can build combo points you can get with GetComboPoints('pet', 'target'), and I'm pretty sure you can't see enemy combo points, it makes sense to centralize cpoints.lua with one player frame for all instances. That way you're assured the unit passed is always 'player' getting combo points for something no matter what oUF spawn is using self.CPoints.

Of course this frame would work with vehicle swapping too.

http://www.wowinterface.com/portal.php?id=137&a=viewfeature&featureid=4188

I think people will need that
http://gist.github.com/573383

From official Blizz change announcement:

• The UNIT_{MANA|RAGE|ENERGY|FOCUS|HAPPINESS|RUNIC_POWER} events, and their associated UNIT_MAX* counterparts are now deprecated in favor of the single UNIT_POWER and UNIT_MAXPOWER event. The first argument is the unit, the second is the power type, etc.

This affects the power and tag elements

On some chars the 3D portraits are to close to the head (eg. i've got problems with undead heads). I'm using v1.3.24.

In the frequentUpdate function(s) you are trying to forward and check 'self.Power|Health.unit' instead of 'self.unit', thus making the update functions hang up (especially on vehicles and pets).

Also, if swapping and not using frequentUpdates it also hangs up the power/health bars (missing event update perhaps)

Just found out by testing it on vehicles in Ulduar (swap from one seat to another)

oUF does not hide buffs which are meant to be consolidated if the interface option "Consolidate Buffs" is enabled.