ourzora / auction-house Goto Github PK

Can anyone help me understand exactly what the 15% creator fee referenced in the integration test suite refer to? Many thanks!

I did not realize you have to approve the NFT with the auction contract before creating an auction, otherwise you will get a high gas fee and the transaction will revert.

This step might be obvious to some people but it took me a long time to figure out. Can you please add something about it in the documentation for createAuction? Thanks!

The Zora Auction House is an incredibly useful tool for the owner of an NFT to be able to list their NFT on a reserve auction without needing to pay centralized platform fees.

A feature that we are starting to see popup is the splitting of royalties. Examples:

• Mirror (https://dev.mirror.xyz/V_7Jp1hy_g8bz-J1B4Wb5KYSmj5Lt4W7q7cw0noxJsU)
• Foundation (https://help.foundation.app/en/collections/3010288-splits-on-foundation)

It could be very useful to architect a permissionless contract factory that would allow the owner of an NFT to permissionlessly initiate the splitting of revenue from a sale on the auction house with a reasonable # of addresses.

Requirements:

• Allow for a user to initiate a split contract that keeps track of a pool of ownership for a reasonable # of addresses without being too gas intensive. Use mirror implementation with Merkle proofs as inspiration (https://github.com/mirror-xyz/splits/blob/main/contracts/Splitter.sol)
• Allow for the split contract to interact with Auction House to call functions such as createAuction, setAuctionReservePrice, and cancelAuction
• Determine a heuristic for the conditions required for the split contract to be able to call AuctionHouse methods (in mvp, it might make sense to allow for the split creator address to call methods that interact with AuctionHouse and punt any sort of governance down the line).
• Once the split contract has sold an NFT on AuctionHouse, the split particpants have the ability to receive their share. This could be implement by individual claiming functions, or a single function that would divy out the split shares to all members of the split in a single transactions.
• Allow for the splits contract to split both ETH and / or ERC20 tokens.
• To simplify the scope of the contract, each split should only be used once, and for a specific auction.

Hi All,

Would you consider adding a license to this repo?
Contracts already have GPL-3.0.

Cheers!

According to document: https://docs.zora.co/docs/smart-contracts/zora-contracts. Auction House is deploy at polygon chain at: 0x48F1C97259Dc7f3900965391651693BaeBfd59A2. But when I check https://polygonscan.com/address/0x48F1C97259Dc7f3900965391651693BaeBfd59A2, it seems polygon is not used by zora.

The current auction house is not correctly reflected in the deployment folder addresses json object

Hi all, this code is amazing. Thank you so much everybody for open sourcing this. I want to know if I can auction erc1155s using this code?

Hi there,
We'd like to use this protocol on xDai.
Do you want a canonical deployment from your team whose address would be on the readme or should we just go ahead and deploy it?
I am happy to PR the xDai address of the AuctionHouse contract + verify the code on Blockscout (xDai's block explorer).

Currently on auction creation the check is if the address calling is approved:

require(msg.sender == IERC721(tokenContract).getApproved(tokenId) || msg.sender == tokenOwner, "Caller must be approved or owner for token id");

However, if you're calling this from a smart contract setApprovalForAll does not work, it needs to be set for each token.

Is it a good idea to add in the isApprovedForAll check here?

require(msg.sender == IERC721(tokenContract).getApproved(tokenId) || IERC721(tokenContract).isApprovedForAll(msg.sender) || msg.sender == tokenOwner, "Caller must be approved or owner for token id");

The Zora Auction House has introduced the notion of curators to the standard reserve auction mechanism. We believe that onchain curation will be a very powerful primitive to allows artists and curators tonatively share revenue from profits of individual auctions.

As a curator on the Zora Auction House, an owner of an NFT can submit auction approvals to you. Before the is valid, you as the curator must approve the auction.

There currently does not exist an open-sourced UI for curators to manage their backlog of pending auctions. It would be an immensely powerful admin tool for curators to be able to see a backlog of pending auctions and have the ability to interact with the Auction House contract by either -- approving the auction, cancelling the auction, or editing the reserve price.

Requirements

• Open sourced front end tool for curators to be able to connect their web3 wallet and view an admin like dashboard of auction requests
• Curator should be able to see all past AND pending auction requests.
• Curator should be able to see details of the pending auction including the rendering of the nft and the auction details.
• Curator should be able to see all past auctions won including the rendering of the nft and details of the auction (reserve price, lister, winning bid, winner address)