ourzora / zora-721-contracts

Zora drops contracts (powers create.zora.co)

Zora NFT Drop Media Contracts

How do I integrate these in my own site?

1. Use wagmi/ethers/web3.js with the given artifacts (in the node package) or typechain.
2. Use our subgraph to find media / metadata information (goerli: https://api.thegraph.com/subgraphs/name/iainnash/erc721drop-goerli) (rinkeby: https://thegraph.com/hosted-service/subgraph/iainnash/erc721droprinkeby) (mainnet: https://thegraph.com/hosted-service/subgraph/iainnash/zora-editions-mainnet)
3. For your edition, call address(edition).purchase(quantity, {value: price * quantity}). Price and availability can be found from the subgraph or from the blockchain with the saleInfo call.
4. Find the transfer() or sale() event from the transaction receipt to get the ID that the user minted.
5. ✨

Features these contracts support:

1. ETH NFT sales
2. Modular admin access and minting controls
3. ERC2981 on-chain royalties
4. Presale merkle trees
5. On-chain modular rendering architecture
6. ERC721A Gas savings / linear mint
7. Limit mints per address when purchasing
8. Allows for new features with opt-in gated user upgrades
9. Allows for time-based open mints
10. Includes a platform royalty fee mechanism
11. Can admin mint NFTs to addresses and airdrop to lists of addresses

What are these contracts?

1. ERC721Drop Each drop is a unique contract. This allows for easy royalty collection, clear ownership of the collection, and your own contract 🎉
2. ZoraNFTCreatorV1 Gas-optimized factory contract allowing you to easily + for a low gas transaction create your own drop contract.
3. DropMetadataRenderer A flexible metadata renderer architecture that allows for centralised and IPFS metadata group roots to be rendered.
4. EditionsMetadataRenderer A partially on-chain renderer for editions that encodes name and description on-chain with media metadata off-chain.
5. UpgradeGate A registry allowing for upgrades to be allowed for child contracts by zora.eth.

Flexibility and safety

All drops contracts are wholly owned by their creator and allow for extensibility with rendering and minting. The root drops contract can be upgraded to allow for product upgrades with new contracts and Zora gates allowed upgrade paths for deployed contracts to be upgraded by the users of the platform to opt into new features.

The metadata renderer abstraction allows these drops contracts to power a variety of on-chain powered projects and also.

Local development

1. Install Foundry
2. yarn install
3. git submodule init && git submodule update
4. yarn build

Bug Bounty

5 ETH for any critical bugs that could result in loss of funds. Rewards will be given for smaller bugs or ideas.

zora-721-contracts's Issues

Fix comment inside ZoraNFTCreatorV1

I believe line 36 should read

/// @param _implementation ERC721Drop logic implementation contract to clone

Or should it be the interface?

base sepolia support

• chainID: 84532
• I have a PR open with deployments already. however, I just need a deployment. If zora team wants to ignore my PR and deploy their own on base sepolia I would welcome it

Withdraws should emit an event

Withdraws should emit an event

[Bug] Using editionSize == 0 on ERC721Drop doesn't allow minting

Deployed Contract on Goerli: https://goerli.etherscan.io/address/0xa063e18781ec993b6070446cce80ea934262b11e

Hi! We're trying to create an Editions contract with unlimited editions. The spec says

/// @param _editionSize Number of editions that can be minted in total. If 0, unlimited editions can be minted.

However, using 0 as _editionSize leads to the contract being unusable. All transactions fail. Looking at the code, I don't see any special case handling for editionSize == 0, so my suspicion is it's actually setting the total volume of the collection to 0.

Lmk if you need anymore info! Thanks for publishing these contracts!

Why doesn't purchase() check editionSize limit?

As far as I understand, the editionSize of a drop is the total number of tokens that can be minted. So why doens't the purchase() function check for this limit like in the mintWithRewards() function.

Allow signature-based minting out of the box

@jemgold

Using Canvas feature

In the canvas feature,

I think it’s better if the word used to ‘imagine’ can be auto-used as the Title.

token uri needs to have a exists() guard

Docs: include subgraph reference to goerli

Summary

In the README's How do I integrate these in my own site?, step 2 says:

Use our subgraph to find media / metadata information (rinkeby: https://thegraph.com/hosted-service/subgraph/iainnash/erc721droprinkeby) (mainnet: https://thegraph.com/hosted-service/subgraph/iainnash/zora-editions-mainnet)

As of September 2, 2022, https://testnet.create.zora.co/ only supports the Goerli testnet (which in turn means that the Rinkeby testnet was deprecated).

I think it would be helpful to update step 2 to replace the rinkeby information with the goerli link -- could
https://api.thegraph.com/subgraphs/name/iainnash/erc721drop-goerli be the correct one? 💭

(Originally discovered in a component in the 0xTranqui/present-materials repo)

ERC721Drop constructor doesn't use interface for `FactoryUpgradeGate`

ERC721Drop should take IFactoryUpgradeGate instead of FactoryUpgradeGate in the constructor for more clean code and convention.

Add `batchSize` of 8 (reasonable default) to _mintNFTs

chiru-labs/ERC721A#28

This implements a batchSize of 8 to the internal _mintNFTs function to balance gas for ownerOf and mint price.

See: chiru-labs/ERC721A#28

Add provenance hash to metadata engine for drops?

Would it make sense to add a proveenance hash field to the metadata engine for drops?

refactor: increase sale prices to uint104

uint64 publicSalePrice & uint64 privateSalePrice can only be ~18.45 ETH at max.

ez fix: change to uint104, will still fit in one slot

https://github.com/ourzora/zora-nft-contracts/blob/main/contracts/ZoraNFTBase.sol#L67-L70

Fix sale admin permissions

Allow the sale admin to update the sales config, right now that permission is not allowed.

return version directly from fn, add to standard interface

NFTs are a scam which happen to also be destroying the only known ecosystem in the universe

Resolution:

• Delete this project
• Reflect upon the course of maintainer's life that led them to make these kinds of selfish decisions

Add multicall to token to allow updating multiple settings at once

Only admins can update sales config

Should include salesManagerRole

Allow arbitrary on-chain trait data

Currently, one cannot add new properties to NFTs using the on-chain metadata renderer for create. Perhaps add an optional field to add arbitrary strings to the metadata (and can be used to override the default serial behavior).

base - mintWithRewards

hi zora devs,

just me again
asking for another
base deployment

can you please deploy the latest version of ERC721DROP_IMPL on Base mainnet? (chainId: 8453)

latest ERC721DROP_IMPL: [0xaDf8fF6a7EA4f028A384D00136fEF0FFfEb39f14] is missing mintWithRewards function
(https://thirdweb.com/base/0xaDf8fF6a7EA4f028A384D00136fEF0FFfEb39f14/explorer)