ovakefali13 / buerro Goto Github PK

This line makes tests on develop fail.

Maybe there is a missing usecase file?

We could think about moving use cases to separate folders instead of having a use case wide test folder. I'm thinking of usecase/lunchbreak/test/test_usecase.py.

Looks a bit like duplicate code. I feel like a Class instantiation of ExampleUsecase(True) is not that meaningful. Why should the Usecase itself bother about setting Mocks? I would leave that to the test. You're already importing the Mock remots there anyway.

To me it's a bit unintuitive that the yelp services requires two interactions for a request.

I would expect request_businesses to return the businesses. Instead it is setting them. If this is the way it's meant to be I would rename it to set_businesses.

I think it could be restructured, though: request_businesses could get some basic search params and fill them with provided information. You could also think about defining these rather remote-specific base parameters in the remote.

@JannisTriesToCode

Why and how to use named tuples in python

:)

Using the actual APIs the real temperature will only rarely equal expected discrete temperatures. Instead a test could verify that a response is in a range, or of a certain type (float).

@timozuther

I've been getting nightmares thinking about the voice you are using for the T2S feature. Please change it. Thanks

@timozuther

The CalService is instantiated with the iCloud Remote non-regarding of whether we are in a mock or non-mocking test.

Also you might think about moving the setting of Mock remotes and services out of the class into the test. Even though it might require some setters, I feel like it shouldn't the classes responsibility to handle mocking.