GithubHelp home page GithubHelp logo

overshare-kit's People

Contributors

berg avatar csteynberg avatar dentelezhkin avatar gpoitch avatar inb4ohnoes avatar jaredsinclair avatar jhersh avatar padraigk avatar peterfriese avatar rudyrichter avatar samuelclay avatar sukima avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

overshare-kit's Issues

Add Cocoapods podspec

Hi, thanks for a great project!

Would you consider adding Overshare to Cocoapods? You could use subspecs to allow the developer to conditionally require one, both, or neither of the ADN and Pocket SDKs.

Sorting activity

Depending on the context of the app could be important to specify the order of the activity displayed.
Is there a way to do that ?

Presentation for iPad as iPhone

Firstly , thank you for sharing us this awesome source.
how can I implement the presentation for iPad as iPhone view not as popover

thank you

Animation Timing Doesn't Feel Like Native iOS

The animation timing for the OSK menu doesn't feel like it has the same timing that other transitions in iOS 7 do. For me, this makes OSK feel a bit less integrated. Is this something that can be changed?

Implemented Sina Weibo and Tencent Weibo activities

I implemented Sina Weibo and Tencent Weibo activities in the master branch of my fork.

They are very similar to twitter: use the iOS system accounts, are limited to 140 characters and support up to one image. Note that Tencent Weibo needs an App Key but I am not providing any example one (Tencent Weibo made it more difficult to get app keys outside Chine since I got mine).

If my Tumblr activity pull request gets merged, I'll submit a new one for this.

Facebook sharing fails in sample app

When I try to share to Facebook in the sample app, a dialog pops up that says "Couldn't Access Your Accounts" and "You have previously denied this app access to your accounts. Please head to the Settings app's Privacy options to enable sharing". I have recently installed the Facebook app, and I did not deny it access to my accounts. It never even asked for access. There is also nothing in the Privacy section of the Settings app that allows me to give the app access to my accounts.

Ability to use existing keychain data for third party authentication

I've already rolled my own authentication in my app for Instapaper, Readability, and Pocket, and want to continue to let users use these services without having to re-login. It would be great if I could pass one of my classes as a authentication manager delegate (?), so that I could provide OvershareKit with the credentials that I already have stored.

Instagram support

I see that Instagram is there as a URLScheme type but the implementation is not there yet. I'm wondering if Instagram support is in the works or not.

customizationsDelegate is released after presenting Activity Sheet

Sorry for the tweet spam. I realized I should just write up an issue.

I'm setting my customizationsDelegate with my Facebook API key before presenting the activity sheet via the Presentation Manager and what I'm seeing is that the customizationDelegate is acknowledged to show the Facebook activity itself but when the user clicks on the Facebook activity as if to share to it, when it comes time to call up on the customizationsDelegate again to get that Facebook API Key , the customizationsDelegate has been released already (weak delegate property).

I fixed this of course by making the property strong but I realize delegate properties are supposed to be weak so I'm not sure what a better workaround is.

Presenting view controller from activity

I'm working on Evernote activity with generic authentication. SDK Evernote have method for authentication:
-authenticateWithViewController:(*UIViewController) completionHandler:^(NSError *error)
How i can create view controller, pass to method and present it without appDelegate?

Sorry for my english.

Email Share Generates Service Termination Error on iOS 8

When using email share activity, the view service terminates when running on iOS 8. Error below.

2014-09-11 22:41:14.717 Overshare[32357:646951] viewServiceDidTerminateWithError: Error Domain=_UIViewServiceInterfaceErrorDomain Code=3 "The operation couldn’t be completed. (_UIViewServiceInterfaceErrorDomain error 3.)" UserInfo=0x7fcbf957a690 {Message=Service Connection Interrupted}
2014-09-11 22:41:25.702 Overshare[32357:647590] <MFMailComposeRemoteViewController: 0x7fcbf9576f50> timed out waiting for fence barrier from com.apple.MailCompositionService

MPMoviePlayerThumbnailImageKey GooglePlus error

I'm using OvershareKit form CocoaPods, and starting today, I'm getting this error when building:

(null): "_MPMoviePlayerThumbnailImageKey", referenced from:

(null): -[GPPMediaPreviewView thumbnailImageRequestDidFinish:] in GooglePlus(GPPMediaPreviewView.o)

(null): "_MPMoviePlayerThumbnailImageRequestDidFinishNotification", referenced from:

(null): -[GPPMediaPreviewView initWithFrame:mediaAttachment:] in GooglePlus(GPPMediaPreviewView.o)

(null): -[GPPMediaPreviewView thumbnailImageRequestDidFinish:] in GooglePlus(GPPMediaPreviewView.o)

(null): "_OBJC_CLASS_$_MPMoviePlayerController", referenced from:

Since it has something to do with GooglePlus, I'm guessing it's related to OvershareKit

Add pinterest support

Pinterest support would be great but I know their current iOS SDK is not so great as of yet. Still figured this was worth putting a placeholder in for

[OSKFacebookPostContentItem] More options for a Facebook Share.

A Facebook Share should be able to have a link (which will result in a link box attached below the status on Facebook).

Also posts on Facebook support a lot more meta data.. that should be reflected in Overshare. I would recommend a type called OSKFacebookPostContentItem which has all specific Facebook parameters.

"Application-Specific Credentials" document not specific enough (maybe?)

Here's the confusing part: (maybe only I was confused)
"Facebook: The iOS authentication requirements for Facebook include passing an application ID. Register your app at http://developers.facebook.com/."

I've registered my Facebook App and got and App Id. However I don't know how to pass this App Id to OvershareKit.

I've tried change the demo's bundle id to mine, and it doesn't work, showing error like this:
facebook remote_app_id does not match stored id.

Maybe this is more of an ask for help than a bug report, am I doing something wrong?

Undefined symbols for architecture x86_64 - GooglePlus

After installing with Cocoapods, is there another step? This is the error I am getting:

    Undefined symbols for architecture x86_64:
      "_OBJC_CLASS_$_GPPShare", referenced from:
          objc-class-ref in libPods.a(OSKGooglePlusActivity.o)
      "_OBJC_CLASS_$_GPPSignIn", referenced from:
          objc-class-ref in libPods.a(OSKGooglePlusActivity.o)
      "_kGTLAuthScopePlusLogin", referenced from:
          -[OSKGooglePlusActivity authenticate:] in libPods.a(OSKGooglePlusActivity.o)
    ld: symbol(s) not found for architecture x86_64
    clang: error: linker command failed with exit code 1 (use -v to see invocation)

Crash in OSKCopyToPasteboardActivity when copy image

Here the self.pasteboardItem.text is nil and it crashes

  • (void)performActivity:(OSKActivityCompletionHandler)completion {
    [[UIPasteboard generalPasteboard] setString:self.pasteboardItem.text];
    if (completion) {
    completion(self, YES, nil);
    }
    }

Sample app fails to build

When I try to build the sample app, I get the following build error. Perhaps this is related to commit d5655fd.

Undefined symbols for architecture armv7:
"OBJC_CLASS$_OSKSaveToCameraRollActivity", referenced from:
objc-class-ref in OSKActivitiesManager.o
ld: symbol(s) not found for architecture armv7
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Many instances of 'release' and 'retain' (pre-ARC) and other errors

I know this was written pre-ARC and I'm getting dozens of errors on 'release', 'retain', and 'autorelease'. I'm also getting a bunch of casting errors that I'm doing my best to fix. I've only been developing in xcode for a few months so this activity is very difficult for me.

Xamarin bindings

It would be super nice with bindings/dll for Xamarin/MonoTouch

Skipping built in Activity Sheet

Hello,

I am attempting to skip the built in Activity Sheet as currently my app only has a limited selection of sharing options, but will be expanding in the future. So, for now, I am going to use a couple buttons to trigger sharing to specific services.

My question is that I found the code block below in OSKPresentationManager, but I'm not sure how to create an activity such as OSKFacebookActivity (or another) myself.

/**
 Use this method to skip the activity sheet view controller and proceed straight to the built-in flow 
 through purchasing, authentication, and publishing view controllers.

 This method is for applications that wish to present their own activity sheet UI, but still wish
 to use Overshare Kit for all the other view controllers & logic.

 @param activity The user's selected activity. It's up to you to create & obtain this activity.

 @param presentingViewController The view controller from which OSK will present it's view controllers.

 @param options A dictionary of options. The accepted keys are `OSKPresentationOption_ActivityCompletionHandler` 
 and `OSKPresentationOption_PresentationEndingHandler`.
 */
- (void)beginSessionWithSelectedActivity:(OSKActivity *)activity
                presentingViewController:(UIViewController *)presentingViewController
                                 options:(NSDictionary *)options;

Does the OSKActivitiesManager need to be used, and the appropriate activity picked out of the array returned by

- (NSArray *)validActivitiesForContent:(OSKShareableContent *)content options:(NSDictionary *)options;

?

Is there another way to create a specific activity and activity specific content?

Thank you for your time.

Documentation regarding installation

Hi,

The docs read: "After including OvershareKit in your Xcode project (see the detailed requirements below), the steps to get started couldn't be easier:"

There are no 'detailed requirements' listed below and I'm having trouble integrating the library into a project.

Smart quotes curled the wrong way

Tried out the as-you-type quote smartener in Sunlit. Please forgive me if the following is a bug only in Sunlit but not in OvershareKit.

If you type an "opening" punctuation character -- think: ( { [ -- and then type a single or double quote, OSK will give you a closing quote, but clearly should give you an opening quote.

In the case where you type a quote immediately after a quote:

  1. If you type two of the same quotes (double-quote double-quote, or single- single), you should get an opener then a closer. OSK does this correctly.
  2. If you type two different quotes in succession (double- single-, or single- double), you should get two opening quotes, because the user is likely writing a quote of a quote. OSK gets this wrong -- it always closes the second quote.

Unable to submit apps due to GooglePlus framework causing validation errors

It's currently impossible to submit to the app store due to validation failures.

Google has updated their API to resolve the issue, but due to the fact that the project includes the source of a much older version of the library it still fails.

Is there a specific reason that the source for GooglePlus is included in project instead of just relying on cocoa pods to pull it down?

Email default appearance

Apple requires that emails follow the standard iOS look and feel. When customising your app appearance (together with overshare-kit), it changes the headers and other fields of emails, making it non-standard.

To get past this, I had to reset appearance to standards before sharing via email, and set it back afterwards. It took a lot of fiddling to get it right.

This issue is not specific to overshare-kit, but I think it would be great to support this behaviour right inside it, since email is usually invoked via sharing.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.