The data-binding-support from oxoooo

data-binding-support's People

Contributors

Stargazers

Watchers

data-binding-support's Issues

BindingRecyclerView.ListAdapter: when source ObservableList changes outside UI thread

I'm using an ObservableArrayList that changes on some network events. Whenever a change occurs, I'm getting warnings about them happening outisde the UI thread and the RecyclerView isn't updating.

I made the following changes to widget/BindingRecyclerView at line 43 that fixes the problem for me, but I'd like to get some feedback on them:

        private Context context;
        protected final LayoutInflater inflater;
        protected final ObservableList<T> data;

        private final AtomicInteger refs = new AtomicInteger();

        private final ObservableList.OnListChangedCallback<ObservableList<T>> callback =
                new ObservableList.OnListChangedCallback<ObservableList<T>>() {
                    @Override
                    public void onChanged(ObservableList<T> sender) {
                        ((Activity)context).runOnUiThread(new Runnable() {
                            @Override
                            public void run() {
                                notifyDataSetChanged();
                            }
                        });
                    }

                    @Override
                    public void onItemRangeChanged(ObservableList<T> sender,
                                                   final int positionStart, final int itemCount) {
                        ((Activity)context).runOnUiThread(new Runnable() {
                            @Override
                            public void run() {
                                notifyItemRangeChanged(positionStart, itemCount);
                            }
                        });
                    }

                    @Override
                    public void onItemRangeInserted(ObservableList<T> sender,
                                                    final int positionStart, final int itemCount) {
                        ((Activity)context).runOnUiThread(new Runnable() {
                            @Override
                            public void run() {
                                notifyItemRangeInserted(positionStart, itemCount);
                            }
                        });
                    }

                    @Override
                    public void onItemRangeMoved(ObservableList<T> sender,
                                                 final int fromPosition, final int toPosition, final int itemCount) {
                        ((Activity)context).runOnUiThread(new Runnable() {
                            @Override
                            public void run() {
                                for (int i = 0; i < itemCount; i++) {
                                    notifyItemMoved(fromPosition + i, toPosition + i);
                                }
                            }
                        });
                    }

                    @Override
                    public void onItemRangeRemoved(ObservableList<T> sender,
                                                   final int positionStart, final int itemCount) {
                        ((Activity)context).runOnUiThread(new Runnable() {
                            @Override
                            public void run() {
                                notifyItemRangeRemoved(positionStart, itemCount);
                            }
                        });
                    }
                };

Recommend Projects