oyeb / phoenix Goto Github PK

Each line on the file seems to be valid json, but that's not enough.

Currently

bot's STDERR -> debug_log
bot's STDOUT -> move_log

What an error_log might look like

What if the bot is making an invalid move? We register an exception on the gameloop STDOUT but the bot is never told that. The gameloop can log errors-that-happen-due-to-bots in a error_log.
There could be a error_log per bot.
This log cannot be seen by the bot, in any iteration. Should we send the errors-in-prev-iter to the bot as part of the new game-state?

What an event log might look like

There is some event logging in gameloop STDOUT, a tuple of (turn_no, [list-of-events]) would be a compact event log (Since turn_no is explicit, we don't need a row for empty turns).
This log cannot be seen by the bot, in any iteration. Should we send the errors-in-prev-iter to the bot as part of the new game-state?

This is not a trivial task. The amount of information available to a bot is the sum of information available to it's children.
So, we need to perform bounding-box (BB) tests for each child.
Relevant code: gamectl.py

The select syscall prematurely exits after the buffer is flushed. The STDOUT of the bots buffer size has to be increased exactly.

after a bot dies, it is still on the game_state_log.txt but its details don't change, thus the UI displays dead bots.

Fix: the game_state_log.txt must contain the bot details until the bot dies.

related file gamectl.py

The server is exception-safe, handles stuff gracefully but phoenix doesn't.
If the game terminates due to an unhandled exception the game_state_log will be empty.

Otherwise the raw_input() keeps waiting and select() eventually takes over. This should be done in the engine as well a map.

if a bot gains a bigger score and there are only two bots remaining on the map, if the bot with bigger score raises some kind of exception, that particular bot's execution stops. Then when there are less than two bots on map, the game execution stops. The bot with higher score just wins it, the bot with higher score can win with a cheat.

The following are mandatory:

scores : [ ... ]
bot_names : [ ... ]
this_bot: <this-bot's-name> | null
map : "map"
iters : #
winner : ""

• this_bot is null if the game is among real bots. If this game is being run for an online submission against sample_bots only, then the value is <this-bot's-name>

What more?

related file /src/engine/gamectl.py

Need to add this to botapi.
All writes for 1 iter must be clubbed in a list. Each of these lists must be mapped to iteration #.
There should be nothing in the dict for if there is no log for that iteration.

Debug log must be valid JSON.