padthaitofuhot / se-configurable-ores

A Space Engineers mod for managing planetary ores.

Configurable Ores

This is a Space Engineers mod for managing planetary ores. Full information available at the Steam Workshop page: Configurable Ores

se-configurable-ores's Issues

Add P142cWater to static voxelmaterials list

Apply GPLv3 headers to source files

GPLv3 specifies that a comment containing the GPL copyleft statement should be present in every source file.

Iron_01 is not editable with mod (Industrial Overhaul incompatibility)

This is an incompatibility with Industrial Overhaul and other mods which use the Iron_01 VoxelMaterial.

Okay, fixing this requires me to change some assumptions about which voxelmaterials are used. Nothing vanilla uses Iron_01 and I've not seen it used on any modded planets for planetary ores, so any mappings with iron_01 are ignored. This is so there's no duplicate irons when adding ores by ore name. I'll need to come up with some way of also specifying the voxelmaterial.

Request: "it would be nice to have the feedback of what was set [by the command]"

Feedback from TechCoder:

Following along on the Example (including subscribing and starting a new world - without the other planet install - I'll use Mars instead of 'Silona'), commands worked fine, though it would be nice to have the feedback of what was set.
/ore earthlike del magnesium

responds with "Magnesium removed..." (great)
/ore earthlike cobalt rarity 9

responds "Rarity set to 9" (nothing about Cobalt)
That would be ok, but the next one
/ore earthlike gold rarity 12

responds "Rarity set to 12" (again, nothing about the ore)
while
/ore earthlike add uranium 12

responds "Uranium added to Earthlike with rarity 12" (really informative..)

[6:02 PM]TechCoder:
/ore earthlike uranium usedetector off

responds with
"Command unknown or incorrect: /ore earthlike uranium usedetector off"
[6:03 PM]TechCoder:

[6:09 PM]TechCoder: (most people would give up - but you know me...

I looked around and found the picture with the commands (NICE) and figured out to try
/ore earthlike gold detector usedetector off

and that WORKED
got "UseDetector set to False (again, no indication/comfirmation of what ore or if it was all ores, etc., but it worked....)
[6:10 PM]TechCoder: same of course for /ore earthlike uranium usedetector off (adding 'depth' in there worked)

GetVoxelMaterialByOre(string ore) crashes on null value

Mod crash on malformed planet: duplicate blue bytes in oremapping table

Config file fails sanity checking when planet has duplicate blue values in the PlanetGeneratorDefinition oremappings table. The mod correctly halts operation when sanity checking detects a discrepancy between calculated blue values and actual blue values.

Example planet:
https://steamcommunity.com/sharedfiles/filedetails/?id=2907125513

      <!-- U 2-->
      <Ore Value="156" Type="Iron_02" Start="167" Depth="25" TargetColor="#616c83" ColorInfluence="15"/>
      <Ore Value="160" Type="Iron_02" Start="181" Depth="33" TargetColor="#616c83" ColorInfluence="15"/>
      <Ore Value="164" Type="Iron_02" Start="196" Depth="39" TargetColor="#616c83" ColorInfluence="15"/>
      
      <Ore Value="156" Type="Uraninite_01" Start="40" Depth="6" TargetColor="#616c83" ColorInfluence="15"/>
      <Ore Value="160" Type="Uraninite_01" Start="121" Depth="7" TargetColor="#616c83" ColorInfluence="15"/>
      <Ore Value="164" Type="Uraninite_01" Start="142" Depth="8" TargetColor="#616c83" ColorInfluence="15"/>
      
      <Ore Value="156" Type="Uraninite_01" Start="770" Depth="18" TargetColor="#616c83" ColorInfluence="15"/>
      <Ore Value="160" Type="Uraninite_01" Start="1191" Depth="23" TargetColor="#616c83" ColorInfluence="15"/>
      <Ore Value="164" Type="Uraninite_01" Start="1442" Depth="35" TargetColor="#616c83" ColorInfluence="15"/>

Planet malformation issue reported to mod planet author "Fizzy".

Crash when using Khurakan planet pack & Industrial Overhaul (mod compatibility issue)

[1:25 PM] ABITCRAZY: Hi Team, I would like to seek help for below errors which cause the game is unable to load with configurable-ores loaded into the mod list.

2023-06-13 01:17:40.654 - Thread:   1 ->  ORE[]> SESSION > -=] Configurable Ores v1.0.15.0 (Mod ID 2973891097) [=-
2023-06-13 01:17:40.654 - Thread:   1 ->  ORE[]> SESSION > https://steamcommunity.com/sharedfiles/filedetails/?id=2973891097
2023-06-13 01:17:40.654 - Thread:   1 ->  ORE[]> SESSION > Initialize(¯\_(ツ)_/¯)
2023-06-13 01:17:40.657 - Thread:   1 ->  ORE[SP]> CONFIG > [BEGIN] Load configuration
2023-06-13 01:17:40.657 - Thread:   1 ->  ORE[SP]> CONFIG > No config present, creating default config.
2023-06-13 01:17:40.658 - Thread:   1 ->  ORE[SP]> CONFIG > [BEGIN] Create default configuration
2023-06-13 01:17:40.659 - Thread:   1 ->  ORE[SP]> CONFIG > [END] Create default configuration
2023-06-13 01:17:40.697 - Thread:   1 ->  Error: Error during loading session:System.NullReferenceException: Object reference not set to an instance of an object.
   at ConfigurableOres.Helpers.LogVar[T](String prefix, String name, T varT, Boolean isServer)
   at ConfigurableOres.MyPlanetConfiguration.LogVar[T](String name, T varT, Boolean isServer)
   at ConfigurableOres.MyPlanetConfiguration.GenerateMappings()
   at ConfigurableOres.MyPlanetConfiguration..ctor(IEnumerable`1 planetOreMappings)
   at ConfigurableOres.ConfigurableOres.LoadAndCheckPlanetConfigurations()
   at ConfigurableOres.ConfigurableOres.LoadData()
   at Sandbox.Game.World.MySession.LoadComponent(MySessionComponentBase component)
   at Sandbox.Game.World.MySession.LoadDataComponents()
   at Sandbox.Game.World.MySession.PrepareBaseSession(MyObjectBuilder_Checkpoint checkpoint, MyObjectBuilder_Sector sector)
   at Sandbox.Game.World.MySession.Load(String sessionPath, MyObjectBuilder_Checkpoint checkpoint, UInt64 checkpointSizeInBytes, Boolean saveLastStates, Boolean allowXml)
2023-06-13 01:17:40.698 - Thread:   1 ->  ERROR: Loading screen failed

[1:25 PM] ABITCRAZY:

2023-06-13 01:17:40.702 - Thread:   1 ->  Exception occurred: System.NullReferenceException: Object reference not set to an instance of an object.
   at ConfigurableOres.Helpers.LogVar[T](String prefix, String name, T varT, Boolean isServer)
   at ConfigurableOres.MyPlanetConfiguration.LogVar[T](String name, T varT, Boolean isServer)
   at ConfigurableOres.MyPlanetConfiguration.GenerateMappings()
   at ConfigurableOres.MyPlanetConfiguration..ctor(IEnumerable`1 planetOreMappings)
   at ConfigurableOres.ConfigurableOres.LoadAndCheckPlanetConfigurations()
   at ConfigurableOres.ConfigurableOres.LoadData()
   at Sandbox.Game.World.MySession.LoadComponent(MySessionComponentBase component)
   at Sandbox.Game.World.MySession.LoadDataComponents()
   at Sandbox.Game.World.MySession.PrepareBaseSession(MyObjectBuilder_Checkpoint checkpoint, MyObjectBuilder_Sector sector)
   at Sandbox.Game.World.MySession.Load(String sessionPath, MyObjectBuilder_Checkpoint checkpoint, UInt64 checkpointSizeInBytes, Boolean saveLastStates, Boolean allowXml)
   at Sandbox.Game.World.MySessionLoader.<>c__DisplayClass18_0.<LoadSingleplayerSessionInternal>b__6()
   at System.DelegateExtensions.InvokeIfNotNull(Action handler)
   at Sandbox.Game.Gui.MyGuiScreenLoading.RunLoad()

[1:27 PM] ABITCRAZY: I am using this mod with now only Insturial Overhaul & World Scenario - Khurakan (https://steamcommunity.com/sharedfiles/filedetails/?id=2852224218) , these are the only mod and world scenario), any clues? (edited)
Steam Workshop::The Khurakan System

[1:28 PM] ABITCRAZY: Thanks, please TAG me for any reply. Thanks a lot with much appreciation.
[10:52 PM] ABITCRAZY: I will try to remove planets from the world scenario one by one tonight and see if anyway to fix, if anyone guide me a fix method also welcomed.

Ensure parser for planet names the same way as ore names

In #5 the issue was raised that when ore names fail parsing when they contain characters that must be escaped before use as a regex match expression. This should be implemented for planet name parsing as well.

Ore spot colors need to be maintained per ore (Industrial Overhaul Incompatibility)

[8:09 AM] smerk: with the mod loaded, it disappears. Is that normal? i think so or?
[8:12 AM] Siv: Yes, probably. The ore depths all change.
[8:13 AM] Siv: Yes, there are specific places where ores spawn. That is decided by the planet author, not this mod.
[8:14 AM] smerk: i mean, without your mod there are the "black" textures, with your mod they are not there

"Add" command should accept optional argument [VoxelMaterial]

There are several instances where it would be incredibly useful to optionally specify which VoxelMaterial is to be presented for a given ore. For example, Industrial Overhaul is hugely popular but has significant incompatibilities with Configurable Ores due to its use of Iron_01.

Mod menu logging toggle doesn't work

Logging toggle stopped working. Not sure what I did.

NRE on load, sometimes.

Fixed already. This is/was a race condition. The config object is loaded in parallel thread. Config object must be explicitly passed to MyPlanetConfiguration instances to avoid the race.

Apply GPLv3 notice to mod description

See title.

Issue adding Better Stone ores to TerraRemake

Reporter: Freeshava
Via: Discord

I was trying to use this mod to put Better Stone ores onto modded planets. I know the mod works, but I can't seem to get the commands to recognize the modded ores. For instance I type
/ore TerraRemake add [EI] Uraniaurite (U,Au) 9
or
/ore TerraRemake add Uraniaurite 9
and the mod says "ADD FAILED: duplicate ore or no free slots". The show commands tells me that I have 54 ore slots and one assigned ore for that planet (stone). Does anyone know what I am doing wrong?
I have validated my files, but I haven't fully reset the game.

The Terra remake mod is https://steamcommunity.com/sharedfiles/filedetails/?id=2930070836&searchtext=
The Better Stone Mod is https://steamcommunity.com/sharedfiles/filedetails/?id=406244471

Code cleanup pass

Time to get out the hoover and clean up this code.