paintswap / estfor-contracts Goto Github PK

When forking with npx hardhat node --fork https://.... it currently uses the default hardhat accounts, this causes problems if we want to impersonate the owner for upgrades. Current we use getImpersonatedSigner and then pass the owner signer in various places through .connect, but I don't think this is necessary. Can set hardhat to use the owner as the default.

hardhat.config.ts

const hardhatAccounts: HardhatNetworkAccountUserConfig[] = [
  {
    privateKey: process.env.PRIVATE_KEY as string,
    balance: ethers.parseEther("100000").toString(),
  },
];

Add accounts here:

    hardhat: {
      gasPrice: 0,
      initialBaseFeePerGas: 0,
      allowUnlimitedContractSize: true,
      accounts: hardhatAccounts,
    }

But thought needs to be put into running the tests and deployment on CI as it would then use them too, hmm

Although BRUSH token on fantom always returns true and instead reverts on failure to be safe we should check all returns when transferring tokens.

Most scripts begin with something like this:

const [owner] = await ethers.getSigners();
console.log(`Deploying upgradeable contracts with the account: ${owner.address}`);

const network = await ethers.provider.getNetwork();
console.log(`ChainId: ${network.chainId}`);

But we could console.log in one line with this:

const [owner] = await ethers.getSigners();
const network = await ethers.provider.getNetwork();
console.log(`Deploying instant actions using account: ${owner.address} on chain id ${network.chainId}`);

Edit: Actually this might work:

const [owner] = await ethers.getSigners();
console.log(`Deploying instant actions using account: ${owner.address} on chain id ${await owner.getChainId()}`);

This commit removed it as the code was not tested: a28497f

When selling multiple items it issues a TransferSingle event instead of TransferBatch for ERC1155

Things like checking min xp for skills and input item validation

Easier exporting of abis

https://www.npmjs.com/package/hardhat-abi-exporter

• Hook in chainlink oracles properly
• Replace all requires with revert and custom error
• Change all mentions of tokenId in Players to playerId
• Add boost vial test
• Use defence combat skill
• Test for health point
• More combat tests
• Add level up rewards to pending output.
• When consuming actions, also retrieve any random rewards for previous actions.
• Go through all integer casts and check if they are necessary
• Rename rate in pending
• Make sure there are never errors thrown when processing actions
• Rename itemTokenIdRangeMin/Max to include hand
• Deployment test script, add combat
• Include updated total xp reward items
• Check speed multiplier is working correctly with past random loot items
• Is minSkillPoints used correctly in places where there are no minimum equipment items.
• minSkillPoints test for consumeables, attire and left/right hand equipment. Actions and action choices too
• Full equipment bonuses
• Map skill points to level in uri.
• Check for re-entrancies (especially when minting)
• Go through all the comments and check if they are still relevant
• Fix solidity compiler warnings
• Reuse some code from pendingRewards and processActions
• Check storage slots are actually packed as expected
• Is equip position correct for attire?
• Upgrade to solidity 0.8.19
• Convert for loops to while or do-while with unchecked increments
• Use unsafe array access
• Use new combat system
• Implement ERC2981 and buy brush on the backend and send to the pool
• Update names of item/player NFTs when they are launched
• Update alpha whitelist to 2 mints per account
• Make alpha whitelist players non-transferable (Not done)
• Add require around brush transfer (e.g in RoyaltyReceiver)
• Add nft vault check in alpha whitelist
• Add shield test and check it is only equippable in left hand (and others only in right hand)
• Daily/Weekly rewards
• Discount on xp boosts for the first X weeks
• Use non-transferable SoulBound ERC? (No clue EIP to use)
• Use revertedWithCustomError in all tests with the appropriate custom error message
• Create some re-usable objects in Players.ts tests
• May need to move all error inside PlayerBase.sol
• Use new npm definition library
• Cooking success rate
• Thieving success rate
• Add CI
• Beardie holder discount (Not doing)
• Add admin whitelist
• Give some characters extra skills
• Verify contracts in deployment script
• ProcessActions should fail if there are no actions to do
• Add alpha whitelist
• Use names of NFTs with (ALPHA)
• Update boots to feet
• Enable full attire bonuses once all items are added
• Change max food and scrolls that can be consumed to 65536?
• Make sure unused dynamic actions are not available to be used
• Minting a new active player while an existing one has actions queued is not working.
• Check XP boosts can be liquidated.
• A test when maxing out XP (overflowing)
• Combine some world.*() functions together to reduce calls
• Some tests fail if they cross a UTC midnight boundary
• Add a test which maxes out food/scrolls (scrolls not needed)
• Add all shop items
• Implement gathering boost
• Add name to Item events
• Use whitelist .json files from estfor-definitions lib
• (bug) Combat not always using up food against high level enemies
• Gathering boost random reward tests

During alpha

• Thieving full set should give +3% reward chance
• Add overall level to "name" in player metadata
• Add external_uri to player url
• Update liquidating logic, each item BRUSH allocation should be defined daily
• Give each player permanent bonuses for their starting skills, 10%? and 5% if shared
• Add multiple queued action checks with new pendingQueuedActionState

During beta

• Check comment // TODO Update later to pendingRandomReward.elapsedTime