pajtai / express-static-file-cache Goto Github PK

var cachePath           = path.join(cacheDir, req.url);

Doesn't reflect the correct paths when using express 4.0 router functions

var router = require("./routes/router");
app.use("/router/", router);

router.get("/", function(req, res { 
});

should be

cachePath = "/router/index.html";

but only gets index.html

Currently for a workaround see: #1 (comment)

The readme is incorrect for the configuration setup
should be:

app.use(require('express-static-file-cache').configure({
    app         : app,
    express     : express,
    cacheDir    : cacheDir
}));

Also, any chance for EJS support? Looking into the EJS's version of the compile and see if it's a straight port.

Use case is if for example you are fetching data that includes an editorial window (or other TTL) where you know that in X hours you will want this page to change, become a 404, or go from a 404 to a 200.

If a project is using PUG, this module fails. Will submit pull request.

There's an issue with caching additional GET requests parameters

for example

curl http://localhost:1337/stuff/

creates cache
/stuff/index.html

now

curl http://localhost:1337/stuff/?otherStuff=1&futureStuff=2

Reads the previous /stuff/index.html cache if it's there

Thoughts on solving that issue?