palant / image-resize-comfyui Goto Github PK

Can you add additional resize methods other than bicubic?

Hello, when using a node to input the value for side_ratio there is an input invalidation error that occurs. It looks like the parse_side_ratio() function is being called twice and the first call the value for side_ratio is empty. Unfortunately when the validation error is thrown this causes resize() to have no output even though parse_side_ratio() is called again with non-empty values.

I was able to hack around this problem by returning a default ratio from parse_side_ratio() when an exception occurs. The image then resizes according to the ratio input from my node and the default that I entered is ignored. I know this is not desirable behavior generally but it works for my use case. I took a crack at writing a proper fix but I can't make heads or tails of why side_ratio is empty on the first call to parse_side_ratio().

Also worth noting that this problem was completely bypassed when I entered the value for the side_ratio input via a primitive node.

Picture below shows a simplified example of a graph that will produce this issue.

am using your plugin with https://github.com/ZHO-ZHO-ZHO/ComfyUI-InstantID

but it hits a snag.
my input image is 1024x1024

I load your node in try a bunch of settings but errors

your asking for pixels - not an image for input. how can I do format image to that?

Hello,really appreciate your work! But when i connect [padding image for outpainting]'s mask to the [mask] socket in this node. It just report error. I wonder if i am doing something wrong
Input and output must have the same number of spatial dimensions, but got input with spatial dimensions of [1542] and output size of (896, 1542). Please provide input tensor in (N, C, d1, d2, ...,dK) format and output size in (o1, o2, ...,oK) format.

It appears there's a conflict with this node: https://github.com/taabata/LCM_Inpaint_Outpaint_Comfy

If your node is included in a workflow and LCM_Inpaint_Outpaint_Comfy is installed while your node isn't, it will default to using LCM_Inpaint_Outpaint_Comfy instead.

Additionally, in a scenario where neither node is installed and a workflow containing your node is loaded, both nodes are visible under "install missing node."

I'm uncertain if the issue lies with your node.