pancurster / ccl Goto Github PK

FYI...

From r16. Attached is the output of running the test app through valgrind. i 
haven't looked closely enough to see if these were intentional or not, but 
thought i'd report them nonetheless. If they are intentional, or global/shared 
objects, i would recommend adding an atexit() handler to clean them up, to 
avoid problems in combination with leak-checking tools.

valgrind was run like:

valgrind --leak-check=full -v --show-reachable=yes --track-origins=yes ./dotest

Happy hacking! i really like how you've separated interface/implementation here.

What steps will reproduce the problem?
1. Invoke "make"

What is the expected output? What do you see instead?
- It is expected that "make" would complete successfully. 
- Instead, it failed.


What version of the product are you using? On what operating system?
- Jul 13 2012
- Linux
 [Linux 2.6.18-128.el5PAE #1 SMP Wed Jan 21 11:19:46 EST 2009 i686 i686 i386 GNU/Linux]

Please provide any additional information below.

$ make
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o vector.o vector.c
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o error.o error.c
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o dlist.o dlist.c
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o qsortex.o qsortex.c
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o bitstrings.o 
bitstrings.c
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o generic.o generic.c
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o dictionary.o 
dictionary.c
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o wdictionary.o 
wdictionary.c
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o list.o list.c
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o strcollection.o 
strcollection.c
In file included from strcollection.c:33:
strcollectiongen.c: In function ‘Contains’:
strcollectiongen.c:357: warning: dereferencing type-punned pointer will break 
strict-aliasing rules
strcollectiongen.c: In function ‘IndexOf’:
strcollectiongen.c:405: warning: dereferencing type-punned pointer will break 
strict-aliasing rules
strcollectiongen.c: In function ‘EraseInternal’:
strcollectiongen.c:650: warning: dereferencing type-punned pointer will break 
strict-aliasing rules
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o searchtree.o 
searchtree.c
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o heap.o heap.c
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o malloc_debug.o 
malloc_debug.c
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o bloom.o bloom.c
bloom.c: In function ‘Create’:
bloom.c:99: warning: implicit declaration of function ‘round’
bloom.c:99: warning: incompatible implicit declaration of built-in function 
‘round’
bloom.c: In function ‘CalculateSpace’:
bloom.c:135: warning: incompatible implicit declaration of built-in function 
‘round’
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o fgetline.o fgetline.c
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o pool.o pool.c
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o pooldebug.o 
pooldebug.c
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o redblacktree.o 
redblacktree.c
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o scapegoat.o 
scapegoat.c
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o queue.o queue.c
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o buffer.o buffer.c
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o observer.o observer.c
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o valarraydouble.o 
valarraydouble.c
In file included from valarraydouble.c:25:
valarraygen.c: In function ‘AddRange’:
valarraygen.c:199: warning: dereferencing type-punned pointer will break 
strict-aliasing rules
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o valarrayint.o 
valarrayint.c
In file included from valarrayint.c:23:
valarraygen.c: In function ‘AddRange’:
valarraygen.c:199: warning: dereferencing type-punned pointer will break 
strict-aliasing rules
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o vectorsize_t.o 
vectorsize_t.c
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o valarraylongdouble.o 
valarraylongdouble.c
In file included from valarraylongdouble.c:25:
valarraygen.c: In function ‘AddRange’:
valarraygen.c:199: warning: dereferencing type-punned pointer will break 
strict-aliasing rules
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o valarrayshort.o 
valarrayshort.c
In file included from valarrayshort.c:25:
valarraygen.c: In function ‘AddRange’:
valarraygen.c:199: warning: dereferencing type-punned pointer will break 
strict-aliasing rules
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o valarrayfloat.o 
valarrayfloat.c
In file included from valarrayfloat.c:25:
valarraygen.c: In function ‘AddRange’:
valarraygen.c:199: warning: dereferencing type-punned pointer will break 
strict-aliasing rules
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o valarrayuint.o 
valarrayuint.c
In file included from valarrayuint.c:25:
valarraygen.c: In function ‘AddRange’:
valarraygen.c:199: warning: dereferencing type-punned pointer will break 
strict-aliasing rules
gcc -O2 -Wno-pointer-sign -DUNIX -Wall -D__MAC_OSX   -c -o valarraylonglong.o 
valarraylonglong.c
In file included from valarraylonglong.c:23:
valarraygen.c: In function ‘AddRange’:
valarraygen.c:199: warning: dereferencing type-punned pointer will break 
strict-aliasing rules
valarraygen.c: In function ‘GetElement’:
valarraygen.c:427: error: ‘LLONG_MIN’ undeclared (first use in this 
function)
valarraygen.c:427: error: (Each undeclared identifier is reported only once
valarraygen.c:427: error: for each function it appears in.)
valarraygen.c: In function ‘Max’:
valarraygen.c:1966: error: ‘LLONG_MIN’ undeclared (first use in this 
function)
valarraygen.c:1970: error: ‘LLONG_MAX’ undeclared (first use in this 
function)
valarraygen.c: In function ‘Min’:
valarraygen.c:2044: error: ‘LLONG_MAX’ undeclared (first use in this 
function)
make: *** [valarraylonglong.o] Error 1

diff -uBb  pooldebug.c.org pooldebug.c
--- pooldebug.c.org 2011-03-01 11:37:07.588075465 +0100
+++ pooldebug.c 2011-03-01 11:47:16.366520121 +0100
@@ -508,6 +508,7 @@
     pool->owner = GetCurrentThread();
 #endif /* THREAD_VERSION */
      if ((pool_allocator = calloc(1,sizeof(Allocator))) == NULL) {
+   Free(pool);
         return NULL;
     }
     pool_allocator->owner = pool;

diff -uBb strcollection.c.org strcollection.c
--- strcollection.c.org 2011-03-01 11:49:57.397800620 +0100
+++ strcollection.c 2011-03-01 11:54:29.966477540 +0100
@@ -1166,17 +1166,23 @@
        return NULL;
    }
    result = iStringCollection.Create(10);
-   if (result == NULL)
+   if (result == NULL) {
+       close(f);
        return NULL;
+   }
    r = GetLine(&line,&llen,f,mm);
    while (r >= 0) {
        if (iStringCollection.Add(result,line) <= 0) {
            Finalize(result);
+           free(line);
+           close(f);
            return NULL;
        }
        r = GetLine(&line,&llen,f,mm);
    }
    if (r != EOF) {
+       free(line);
+       close(f);
        Finalize(result);
        return NULL;
    }

Ho to reproduce the problem:
0. My system is: "Linux Feynman 3.5.0-17-lowlatency #18-Ubuntu SMP PREEMPT Tue 
Oct 9 20:04:43 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux"
1. Download the trunk sources with SVN
2. Run "make dotest; ./dotest"
3. Read the results near the end

I would expect womthing like:
011 AND 11011    000 0011

Instead I read:
011 AND 11011    000 0001

The system is actually an x86-64 Kubuntu 12.10 machine running "gcc version 
4.7.2 (Ubuntu/Linaro 4.7.2-2ubuntu1)"

There seems to be no reference "dotest" output, nor an explaination about how 
to interpred the results.
I attach here my very own dotest output.

What steps will reproduce the problem?
1. Compile latest svn source using lcc 32 bit
2.
3.

What is the expected output? What do you see instead?
Error : 
c:\ccl-svn>C:\lcc\bin\make.exe -f Makefile.lcc
    lcc.exe -I. -O -A  -p6 -ansic  -g2 buffer.c
    lcc.exe -I. -O -A  -p6 -ansic  -g2 vector.c
    lcc.exe -c -I. -O -A  -p6 -ansic  -g2 .\bitstrings.c
    lcc.exe -c -I. -O -A  -p6 -ansic  -g2 .\bloom.c
    lcc.exe -c -I. -O -A  -p6 -ansic  -g2 .\error.c
    lcc.exe -c -I. -O -A  -p6 -ansic  -g2 .\deque.c
    lcc.exe -I. -O -A  -p6 -ansic  -g2 doublelist.c
Warning c:\ccl-svn\doublelist.c: listg
en.c: 200  result of unsigned comparison is constant
0 errors, 1 warning
    lcc.exe -c -I. -O -A  -p6 -ansic  -g2 .\dictionary.c
    lcc.exe -c -I. -O -A  -p6 -ansic  -g2 .\dlist.c
Warning dlist.c: 471  Comparison of signed with unsigned integer
0 errors, 1 warning
    lcc.exe -c -I. -O -A  -p6 -ansic  -g2 .\fgetline.c
    lcc.exe -c -I. -O -A  -p6 -ansic  -g2 .\generic.c
    lcc.exe -c -I. -O -A  -p6 -ansic  -g2 .\hashtable.c
    lcc.exe -c -I. -O -A  -p6 -ansic  -g2 .\heap.c
    lcc.exe -I. -O -A  -p6 -ansic  -g2 iMask.c
    lcc.exe -I. -O -A  -p6 -ansic  -g2 intlist.c
    lcc.exe -c -I. -O -A  -p6 -ansic  -g2 .\list.c
Warning list.c: 947  unreachable code
0 errors, 1 warning
    lcc.exe -I. -O -A  -p6 -ansic  -g2 longlonglist.c
Warning c:\ccl-svn\longlonglist.c: lis
tgen.c: 200  result of unsigned comparison is constant
0 errors, 1 warning
    lcc.exe -c -I. -O -A  -p6 -ansic  -g2 .\malloc_debug.c
    lcc.exe -c -I. -O -A  -p6 -ansic  -g2 .\pool.c
    lcc.exe -c -I. -O -A  -p6 -ansic  -g2 .\pooldebug.c
    lcc.exe -c -I. -O -A  -p6 -ansic  -g2 .\qsortex.c
    lcc.exe -I. -O -A  -p6 -ansic  -g2 queue.c
    lcc.exe -c -I. -O -A  -p6 -ansic  -g2 .\redblacktree.c
    lcc.exe -c -I. -O -A  -p6 -ansic  -g2 .\scapegoat.c
Warning scapegoat.c: 433  shift by 64 is undefined
Warning scapegoat.c: 436  shift by 32 is undefined
0 errors, 2 warnings
    lcc.exe -c -I. -O -A  -p6 -ansic  -g2 .\searchtree.c
Warning searchtree.c: 75  static 'const guid BinarySearchTreeGuid' is not refere
nced
0 errors, 1 warning
    lcc.exe -c -I. -O -A  -p6 -ansic  -g2 .\strcollection.c
Error c:\ccl-svn\strcollection.c: c:\l
cc\include\wchar.h: 510  missing parameter type
Warning c:\ccl-svn\strcollection.c: c:
\lcc\include\wchar.h: 510  no type specified. Defaulting to int
Error c:\ccl-svn\strcollection.c: c:\l
cc\include\wchar.h: 510  syntax error; found `n' expecting ')'
Error c:\ccl-svn\strcollection.c: c:\l
cc\include\wchar.h: 510  skipping `n' `,'
Error c:\ccl-svn\strcollection.c: c:\l
cc\include\wchar.h: 510  syntax error; found `const' expecting '{'
Error c:\ccl-svn\strcollection.c: c:\l
cc\include\wchar.h: 510  missing identifier
Error c:\ccl-svn\strcollection.c: c:\l
cc\include\wchar.h: 510  Syntax error; missing semicolon before  `...'
Error c:\ccl-svn\strcollection.c: c:\l
cc\include\wchar.h: 510  skipping `...' `)'
Error c:\ccl-svn\strcollection.c: c:\l
cc\include\wchar.h: 511  missing parameter type
Warning c:\ccl-svn\strcollection.c: c:
\lcc\include\wchar.h: 511  no type specified. Defaulting to int
Error c:\ccl-svn\strcollection.c: c:\l
cc\include\wchar.h: 511  syntax error; found `n' expecting ')'
Error c:\ccl-svn\strcollection.c: c:\l
cc\include\wchar.h: 511  skipping `n' `,'
Error c:\ccl-svn\strcollection.c: c:\l
cc\include\wchar.h: 511  Syntax error; missing semicolon before  `const'
Error c:\ccl-svn\strcollection.c: c:\l
cc\include\wchar.h: 511  redeclaration of local variable 'format'
Error c:\ccl-svn\strcollection.c: c:\l
cc\include\wchar.h: 510  Previous definition of 'format' here
Error c:\ccl-svn\strcollection.c: c:\l
cc\include\wchar.h: 511  missing identifier
Error c:\ccl-svn\strcollection.c: c:\l
cc\include\wchar.h: 511  Syntax error; missing semicolon before  `...'
Error c:\ccl-svn\strcollection.c: c:\l
cc\include\wchar.h: 511  skipping `...' `)'
Error c:\ccl-svn\strcollection.c: c:\l
cc\include\wchar.h: 515  missing parameter type
Warning c:\ccl-svn\strcollection.c: c:
\lcc\include\wchar.h: 515  no type specified. Defaulting to int
Error c:\ccl-svn\strcollection.c: c:\l
cc\include\wchar.h: 515  syntax error; found `n' expecting ')'
Error c:\ccl-svn\strcollection.c: c:\l
cc\include\wchar.h: 515  skipping `n' `,'
Error c:\ccl-svn\strcollection.c: c:\l
cc\include\wchar.h: 515  Syntax error; missing semicolon before  `const'
Error c:\ccl-svn\strcollection.c: c:\l
cc\include\wchar.h: 515  too many errors
C:\lcc\bin\make.exe: Error code 1


What version of the product are you using? On what operating system?
OS : windows 7

Please provide any additional information below.
Failed to compile, i tried to compile source using mingGw and lcc
both fail..

Do i miss something ?

Thx

What steps will reproduce the problem?
1. a = iVector.Create(sizeof(int),10);
2. iVector.Add(a,&i);
3. iVector.Add(a,&i);
4. iVector.Erase(a,1)
5. iVector.Finalize(a) will report error when Mem Debug enabled

Please change line 652 in vector.c to 

memmove(p,p+AL->ElementSize,(AL->count-idx-1)*AL->ElementSize);

1. makefile.msvc failed with msvc
2. heap.c have a bug in function FreeObject 
3. hashtable.c have a bug in function static int Clear(HashTable *ht)

   patch file will fix it(1,2,3).

4. document have a error, in ccl.pdf 5.8.2, Add,
   Both the key and the data are copied into the container. But only value be copied, key just a pointer ref.

diff -uB scapegoat.c.org scapegoat.c
--- scapegoat.c.org 2011-03-01 11:30:46.666520383 +0100
+++ scapegoat.c 2011-03-01 11:31:11.997765691 +0100
@@ -876,7 +876,8 @@
     result = Create(L.ElementSize);
     if (result == NULL) {
         iError.RaiseError("Load",CONTAINER_ERROR_NOMEMORY);
-        return NULL;
+       free(buf);
+   return NULL;
     }
     result->Flags = L.Flags;
     r = 1;

diff -uBb list.c.org list.c
--- list.c.org  2011-03-01 11:34:08.226523528 +0100
+++ list.c  2011-03-01 11:34:59.777768935 +0100
@@ -1459,6 +1459,7 @@
     result = iList.Create(L.ElementSize);
     if (result == NULL) {
         iError.RaiseError("iList.Load",CONTAINER_ERROR_NOMEMORY);
+        free(buf);
         return NULL;
     }
     result->Flags = L.Flags;

I tried but failed with mingw compiler.Could support MinGW in the near future 
since as mentioned it is added to portable C?