GithubHelp home page GithubHelp logo

Comments (4)

pandulapeter avatar pandulapeter commented on May 26, 2024 1

Thanks for raising the issue I'll look into it!

from beagle.

pandulapeter avatar pandulapeter commented on May 26, 2024

Sorry to hear about that, I hope you didn't spend too much time debugging before figuring out it wasn't your fault. I can change the name of the class in the next update and improve the documentation to avoid confusions.

Just to be clear: did using addInterceptor() instead of addNetworkInterceptor() fix your issue? If not, do you have any suggestions of what I should change to not mess up the compression?

from beagle.

angusholder avatar angusholder commented on May 26, 2024

No worries, I didn't mean it to come across as pointing blame!

Yeah addInterceptor fixed it. I suppose this is more of an OkHttp problem, it can be easy to mix up which kind of interceptor you have, and it will mostly work when you do it wrong, just ends up being hard to debug 💀

I think BeagleNetworkInterceptor could be adjusted to take the Content-Encoding: gzip header into account, but I don't know if it would be worthwhile, there might be other ways in which it doesn't work properly when inserted as a network interceptor, probably better just to document clearly which kind of interceptor it is.

Thanks for the quick reply!

from beagle.

pandulapeter avatar pandulapeter commented on May 26, 2024

In v2 the interceptor is accessed using Beagle.interceptor and the KDoc for the relevant class also contains a code snippet., so hopefully there will be no more confusion.

from beagle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.