Drawer does not work with FragNav about beagle

[pandulapeter]

Hi,

Thanks for the bug report, this sounds interesting! I've never used FragNav so I'm investigating this right now (I've managed to reproduce the issue). Should be something simple, as apparently this addOverlayFragment() function fails to do its job, my first guess was that FragNav is replacing the Fragment in the android.R.id.content FrameLayout with something else but looks like that's not the case. Anyway, I'll let you know when I find something.

[pandulapeter]

Awesome 👍 And thanks for posting the code as well.

Yeah, the OverlayFragment does a couple of things: while you're right that its View hierarchy is only used for the Drawer, it also handles some Activity Results (screenshot, screen recording) and the keyline overlay module which must work for all types, so it must be added.

I'll close this one for now, I think this is a reasonable workaround and a more elegant solution would be the ability to whitelist some Fragment tags in FragNav which doesn't depend on us. Thanks for bringing it up, let me know if you find anything else!

[pandulapeter]

I think I found it.

During its initialize() function, in line 201 FragNav removes all Fragments from the FragmentManager (which at that moment already contains the OverlayFragment needed for Beagle). Now, maybe I could introduce a small delay to circumvent this but this comment is pretty clear, and we might introduce further issues down the road. Exposing the OverlayFragment for you to manually add is cumbersome + can introduce issues with the release build.

I think I have a solution but I'd kindly ask you to give it a try with your setup. Could you let Beagle use the Activity's supportFragmentManager (as it does now) but initialize FragNav within a Fragment, using that Fragment's childFragmentManager? From what I saw, that could work and would be a relatively quick fix (besides introducing a Fragment into the hierarchy...). Will this fix your issue? If it does, is it too much overhead when using FragNav?

I'll think about it a bit more but for now I don't see a fix that won't affect other users negatively (people using manual Fragment management / Jetpack Navigation).

[jakoss]

Ok, so i changed my activity to this:

class MainActivity : AppCompatActivity() {
    private val binding by viewBinding(ActivityMainBinding::inflate)

    override fun onCreate(savedInstanceState: Bundle?) {
        setTheme(R.style.AppTheme)
        super.onCreate(savedInstanceState)
        setContentView(binding.root)

        supportFragmentManager.commit {
            replace(R.id.activityFragmentContainer, MainNavigationFragment())
        }
    }
}

and MainNavigationFragment looks like this:

class MainNavigationFragment : Fragment(R.layout.fragment_main_navigation) {
    val fragNavController by lazy {
        FragNavController(
            childFragmentManager,
            R.id.fragmentContainer
        )
    }

    override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
        super.onViewCreated(view, savedInstanceState)

        fragNavController.apply {
            rootFragments = listOf(HomeFragment())
            fragNavLogger = object : FragNavLogger {
                override fun error(message: String, throwable: Throwable) {
                    Timber.e(throwable, message)
                }
            }

            defaultTransactionOptions = FragNavTransactionOptions.newBuilder().customAnimations(
                R.anim.slide_left_from_right,
                R.anim.slide_left_from_middle,
                R.anim.slide_right_from_left,
                R.anim.slide_right_from_middle
            ).build()
            initialize(savedInstanceState = savedInstanceState)
        }

        requireActivity().onBackPressedDispatcher.addCallback(viewLifecycleOwner, backCallback)
    }
}

And it works fine so far. I don't think that one more fragment in hierarchy will drastically impact the performance, so this is ok for me 👍🏻

[jakoss]

Also, is it necessary to create Overlay while using dialog or bottom sheet menu?