GithubHelp home page GithubHelp logo

Refactor inset handling about beagle HOT 6 CLOSED

pandulapeter avatar pandulapeter commented on May 27, 2024
Refactor inset handling

from beagle.

Comments (6)

pandulapeter avatar pandulapeter commented on May 27, 2024

Blocked by appCompat: the necessary methods are not yet part of the stable release, so this can only be implemented after 1.3.0 comes out.

from beagle.

rahulsainani avatar rahulsainani commented on May 27, 2024

Hey @pandulapeter I have been using this library and it's been very helpful, thank you! I have some changes locally, to use the new WindowInsetsCompat API with inset types in DebugMenuDrawerLayout, DebugMenuActivity, DebugMenuBottomSheet and DebugMenuDialog. No implementation changes, just mapping androix.core.graphics.Insets to com.pandulapeter.beagle.common.configuration.Insets to avoid any breaking changes of users. I can make the PR, just let me know. :)

from beagle.

pandulapeter avatar pandulapeter commented on May 27, 2024

Hi @rahulsainani ! I'm very happy to accept any contributions, feel free to create a PR and I'll do some testing next week. If everything goes well, it will be part of the next release (with the regular dependency updates). Let me know if you need help, thanks in advance!

from beagle.

rahulsainani avatar rahulsainani commented on May 27, 2024

Sounds good! 👍 Just created a PR, please take a look. Happy to do any changes if required.

from beagle.

pandulapeter avatar pandulapeter commented on May 27, 2024

@rahulsainani looks like the artifacts for release2.6.5 are live, thanks again for the help!

from beagle.

rahulsainani avatar rahulsainani commented on May 27, 2024

@pandulapeter glad to help! Thanks for the quick review and release! 👍

from beagle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.