pantsbuild / jmake Goto Github PK
View Code? Open in Web Editor NEWA repo to track modifications of jmake used by pants but not yet merged upstream
License: GNU General Public License v2.0
jmake's Introduction
This is the source code for the "jmake" project (formerly known as Javamake). The file: ./com/sun/tools/jmake/ant/JavaMake.java requires ant.jar from the Apache foundation to build: the rest of the sources are self-contained. SAU 4/08
jmake's People
Contributors
Stargazers
Watchers
Forkers
pombredanne dturner-tw gigamonkey baroquebobcat twitter-forks runt18 gs-rezaem jahatdurhaka alikkille benpope82 shubhindia kampbelljmake's Issues
project database corrupted: file size does not match stored value
Recently started making use of jmake inside of chromium, but we are occasionally hitting this error message:
bin/jmake -pdb gen/content/shell/android/content_shell_apk_java__compile_java.initial.jar.pdb -C-g -C-encoding -CUTF-8 -classpath lib.java/content/shell/android/content_shell_java.interface.jar:lib.java/base/base_java.interface.jar:lib.java/content/public/android/content_java.interface.jar:lib.java/media/base/android/media_java.interface.jar:lib.java/net/android/net_java.interface.jar:lib.java/ui/android/ui_java.interface.jar -C-sourcepath -C -bootclasspath lib.java/android.interface.jar -C-source -C1.7 -C-target -C1.7 -C-Xlint:unchecked -C-Xlint:deprecation -d /tmp/tmp8CxgKR/classes ../../content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java ../../content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java /tmp/tmp8CxgKR/java/org/chromium/content_shell_apk/R.java )
jmake: project database corrupted: file size does not match stored value
I sadly cannot provide reliable repro steps, but wanted to at least file a bug to track this. Relevant Chromium bug: https://code.google.com/p/chromium/issues/detail?id=551449
org.pantsbuild#jmake-1.3.8-7 does not support java 1.6
Errors look like so: https://travis-ci.org/pantsbuild/pants/jobs/47479542
...
03:36:27 00:08 [compile]
03:36:27 00:08 [bootstrap-jmake]DEBUG] Executing: /usr/lib/jvm/java-6-openjdk-amd64/bin/java -Divy.cache.dir=/home/travis/.ivy2/pants -Dsun.io.useCanonCaches=false -cp ../../../.ivy2/pants/org.apache.ivy/ivy/jars/ivy-2.3.0.jar org.apache.ivy.Main -settings /home/travis/build/pantsbuild/pants/build-support/ivy/ivysettings.xml -ivy /home/travis/build/pantsbuild/pants/.pants.d/ivy/b1f0f7d888deba59ac2f77e4f929422e05822284-IvyResolveFingerprintStrategy_53c4bb9c6553/ivy.xml -confs default -cachepath /home/travis/build/pantsbuild/pants/.pants.d/ivy/b1f0f7d888deba59ac2f77e4f929422e05822284-IvyResolveFingerprintStrategy_53c4bb9c6553/classpath.raw.tmp args={'stderr': <pants.rwbuf.read_write_buffer.FileBackedRWBuf object at 0x2deec90>, 'stdout': <pants.rwbuf.read_write_buffer.FileBackedRWBuf object at 0x2dee790>} at cwd=/home/travis/build/pantsbuild/pants
DEBUG] Copied ivy classfile file to /home/travis/build/pantsbuild/pants/.pants.d/ivy/b1f0f7d888deba59ac2f77e4f929422e05822284-IvyResolveFingerprintStrategy_53c4bb9c6553/classpath.raw
03:36:28 00:09 [bootstrap-java-compiler]DEBUG] Executing: /usr/lib/jvm/java-6-openjdk-amd64/bin/java -Divy.cache.dir=/home/travis/.ivy2/pants -Dsun.io.useCanonCaches=false -cp ../../../.ivy2/pants/org.apache.ivy/ivy/jars/ivy-2.3.0.jar org.apache.ivy.Main -settings /home/travis/build/pantsbuild/pants/build-support/ivy/ivysettings.xml -ivy /home/travis/build/pantsbuild/pants/.pants.d/ivy/1589b77554b51ecbd78f75b31c06c723e5bcfea0-IvyResolveFingerprintStrategy_53c4bb9c6553/ivy.xml -confs default -cachepath /home/travis/build/pantsbuild/pants/.pants.d/ivy/1589b77554b51ecbd78f75b31c06c723e5bcfea0-IvyResolveFingerprintStrategy_53c4bb9c6553/classpath.raw.tmp args={'stderr': <pants.rwbuf.read_write_buffer.FileBackedRWBuf object at 0x2ddedd0>, 'stdout': <pants.rwbuf.read_write_buffer.FileBackedRWBuf object at 0x2de4c10>} at cwd=/home/travis/build/pantsbuild/pants
DEBUG] Copied ivy classfile file to /home/travis/build/pantsbuild/pants/.pants.d/ivy/1589b77554b51ecbd78f75b31c06c723e5bcfea0-IvyResolveFingerprintStrategy_53c4bb9c6553/classpath.raw
03:36:31 00:12 [jmake]
DEBUG] No ng server found with fingerprint 662b69e083f554fdde9a461b2d98ff967fd8dd92, spawning...
DEBUG] Executing: /usr/lib/jvm/java-6-openjdk-amd64/bin/java -Xmx2G -Dpants.buildroot=/home/travis/build/pantsbuild/pants -Dpants.nailgun.owner=/home/travis/build/pantsbuild/pants/.pants.d/ng/JavaCompile -Dpants.nailgun.fingerprint=662b69e083f554fdde9a461b2d98ff967fd8dd92 -cp .pants.d/ivy/jars/com.martiansoftware/nailgun-server/jars/nailgun-server-0.9.1.jar:.pants.d/ivy/jars/org.pantsbuild/jmake/jars/jmake-1.3.8-7.jar com.martiansoftware.nailgun.NGServer :0 args={'close_fds': True, 'stdin': <open file u'/dev/null', mode 'r' at 0x2d6ef60>, 'stderr': <open file u'/home/travis/build/pantsbuild/pants/.pants.d/ng/JavaCompile/stderr', mode 'w' at 0x2df40c0>, 'stdout': <open file u'/home/travis/build/pantsbuild/pants/.pants.d/ng/JavaCompile/stdout', mode 'w' at 0x2df4030>} at cwd=/home/travis/build/pantsbuild/pants
DEBUG] Spawned ng server with fingerprint 662b69e083f554fdde9a461b2d98ff967fd8dd92 @ 3072
DEBUG] Detected ng server up on port 43417
DEBUG] Found ng server launched with Endpoint(exe='/usr/lib/jvm/java-6-openjdk-amd64/bin/java', fingerprint='662b69e083f554fdde9a461b2d98ff967fd8dd92', pid=3072, port=43417)
DEBUG] Connected to ng server launched with Endpoint(exe='/usr/lib/jvm/java-6-openjdk-amd64/bin/java', fingerprint='662b69e083f554fdde9a461b2d98ff967fd8dd92', pid=3072, port=43417)
DEBUG] Executing via NailgunClient(host=u'localhost', port=43417, workdir='/home/travis/build/pantsbuild/pants'): /usr/lib/jvm/java-6-openjdk-amd64/bin/java -Xmx2G -cp /home/travis/build/pantsbuild/pants/.pants.d/ivy/jars/org.pantsbuild/jmake/jars/jmake-1.3.8-7.jar org.pantsbuild.jmake.Main -classpath .pants.d/ivy/jars/com.google.guava/guava/bundles/guava-16.0.jar:.pants.d/ivy/jars/javax.inject/javax.inject/jars/javax.inject-1.jar:.pants.d/ivy/jars/com.google.code.findbugs/jsr305/jars/jsr305-1.3.9.jar:.pants.d/compile/jvm/apt/classes:.pants.d/compile/jvm/apt/resources:.pants.d/compile/jvm/java/classes:.pants.d/compile/jvm/java/resources:/home/travis/build/pantsbuild/pants/.pants.d/compile/jvm/java/classes -d /home/travis/build/pantsbuild/pants/.pants.d/compile/jvm/java/classes -pdb /home/travis/build/pantsbuild/pants/.pants.d/compile/jvm/java/analysis/artifact_cache_tmpdir/ed843ecb-da04-4b41-a181-6e903b90aae0/examples.src.java.com.pants.examples.annotation.example.example/analysis -pdb-text-format -jcpath /home/travis/build/pantsbuild/pants/.pants.d/ivy/jars/com.twitter.common.tools/java-compiler/jars/java-compiler-0.0.12.jar:/home/travis/build/pantsbuild/pants/.pants.d/ivy/jars/org.fusesource.jansi/jansi/jars/jansi-1.8.jar -jcmainclass com.twitter.common.tools.Compiler -C-source -C6 -C-target -C6 -C-encoding -CUTF-8 -C-g -C-Tcolor -C-Tnowarnprefixes -C/home/travis/build/pantsbuild/pants/.pants.d/gen -C-Tnowarnregex -C^(warning: )?No processor claimed any of these annotations: .* -C-Xlint:all -C-Xlint:-serial -C-Xlint:-path -C-deprecation examples/src/java/com/pants/examples/annotation/example/Example.java
java.lang.UnsupportedClassVersionError: org/pantsbuild/jmake/PublicExceptions$DoubleEntryException : Unsupported major.minor version 51.0
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:643)
at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:277)
at java.net.URLClassLoader.access$000(URLClassLoader.java:73)
at java.net.URLClassLoader$1.run(URLClassLoader.java:212)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:205)
at java.lang.ClassLoader.loadClass(ClassLoader.java:323)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:294)
at java.lang.ClassLoader.loadClass(ClassLoader.java:268)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:191)
at com.martiansoftware.nailgun.NGSession.run(NGSession.java:242)
FAILURE: Unexpected error - JMake returned 899
...A check of the jar shows all but 3 classes are java 1.7:
jsirois@gill ~/dev-jsirois-pants3 (jsirois/debug/942) $ mkdir /tmp/jmake
jsirois@gill ~/dev-jsirois-pants3 (jsirois/debug/942) $ unzip -qd /tmp/jmake/ ~/.ivy2/pants/org.pantsbuild/jmake/jars/jmake-1.3.8-7.jar
jsirois@gill ~/dev-jsirois-pants3 (jsirois/debug/942) $ find /tmp/jmake/ -name "*.class" | xargs file
/tmp/jmake/org/pantsbuild/jmake/Base64.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/Base64Test.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/BinaryFileReader.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/BinaryFileWriter.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/BinaryProjectDatabaseReader.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/BinaryProjectDatabaseWriter$StringHashTable.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/BinaryProjectDatabaseWriter.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/ClassFileReader.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/ClassFileReaderTest.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/ClassInfo$MethodHandler.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/ClassInfo.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/ClassPath$1.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/ClassPath$Dir.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/ClassPath$PathEntry.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/ClassPath$Zip.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/ClassPath.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/CompatibilityChecker$1.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/CompatibilityChecker$2.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/CompatibilityChecker.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/CompileResult.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/Main.class: compiled Java class data, version 49.0 (Java 1.5)
/tmp/jmake/org/pantsbuild/jmake/MainTest.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/PCDContainer.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/PCDEntry.class: compiled Java class data, version 49.0 (Java 1.5)
/tmp/jmake/org/pantsbuild/jmake/PCDManager.class: compiled Java class data, version 49.0 (Java 1.5)
/tmp/jmake/org/pantsbuild/jmake/PCDManagerTest.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/PCDSerializationTest.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/PrivateException.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/PublicExceptions$ClassFileParseException.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/PublicExceptions$ClassNameMismatchException.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/PublicExceptions$CommandFileReadException.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/PublicExceptions$CompilerInteractionException.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/PublicExceptions$DoubleEntryException.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/PublicExceptions$InternalException.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/PublicExceptions$InvalidCmdOptionException.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/PublicExceptions$InvalidSourceFileExtensionException.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/PublicExceptions$JarDependsOnSourceException.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/PublicExceptions$NoActionRequestedException.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/PublicExceptions$PDBCorruptedException.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/PublicExceptions.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/RefClassFinder$1.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/RefClassFinder.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/TestCase1.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/TestDepFile.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/TestPCDUtils$1.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/TestPCDUtils.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/TextProjectDatabaseReader.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/TextProjectDatabaseWriter.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/Utils.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/UtilsTest.class: compiled Java class data, version 51.0
/tmp/jmake/org/pantsbuild/jmake/ant/JavaMake.class: compiled Java class data, version 51.0It seems like the cause is the jarjar post-processing step since the compile step in nbproject/build-impl.xml pins outputs to 1.5 via nbproject/project.properties. The remedy is either being careful to use an old jdk to publish or else adding a java -version parse/check to release.sh.
NullPointerException
There is a simple bug on line 843 of PCDManager:
int filesNo = updatedJavaFiles.size() + newJavaFiles.size();
String[] fileNames = new String[filesNo];
int i = 0;
for (String updatedFile : updatedJavaFiles) {
recompiledJavaFiles.add(fileNames[i] = updatedFile); // line 843
}
for (int j = 0; j < newJavaFiles.size(); j++) {
recompiledJavaFiles.add(fileNames[i++] = newJavaFiles.get(j));
that fileNames[i] should be fileNames[i++], otherwise the array doesn't get filled with the proper contents leading to an eventual NPE.
Some sources without license header
GPL requires to have license header in sources. We found some of the test files have none.
jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/classfilereader/Parent.java
jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/org/pantsbuild/jmake/ClassFileReaderTest.java
jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/org/pantsbuild/jmake/CompileResult.java
jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/org/pantsbuild/jmake/PCDManagerTest.java
jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/org/pantsbuild/jmake/PCDSerializationTest.java
jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/org/pantsbuild/jmake/TestPCDUtils.java
jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/org/pantsbuild/jmake/UtilsTest.java
jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/packageinfo/package-info.java
jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/testcase1/A.java
jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/testcase1/B.java
jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/testcase1/C.java
jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/testcase2/orig-files/with-extra
jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/testcase2/orig-files/without-extra
A developer found pants 'FAILURE: deduced and actual class name mismatch' misleading
jmake: Could not find class file for /Users/cconroy/Development/java/tracon/src/test/java/com/squareup/tracon/protocol/http/match/Foo.java
Warning: unable to find .class file corresponding to source /Users/cconroy/Development/java/tracon/src/test/java/com/squareup/tracon/protocol/http/match/Foo.java: expected /Users/cconroy/Development/java/.pants.d/compile/jvm/java/classes/Foo.class
This is a frequently seen error from jmake and can cause some head scratching. There are several different classes of problems that cause this error:
- multiple top level classes in one source file
- package name different from source path
- in this case, the class was commented out.
It might be nice to add some extra logic to jmake to try to guess which problem this is and give better diagnostics.
Only one toplevel class per .java file analyzed
(I thought I had reported this before but can find no recorded mention of it)
Problem
Jmake ignores any classes other than the one named the same as the .java file in its analysis. This causes it to miss some rarely seen cases where multiple top level classes are defined in the same .java file.
Example source file A.java:
class A {
public int foo() { return 0; }
}
class B {
public int foo() { return 0; }
}
This is against most "best practices", but valid Java syntax nonetheless.
Repro case
Here's a repro case given to me by Patrick Lawson:
rm -rf /tmp/jmake
mkdir -p /tmp/jmake
echo "class A { public int foo() { return 0; } } \
class B { public int foo() { return 0; } }" > /tmp/jmake/A.java
java -cp /Users/zundel/.ivy2//cache/com.sun.tools/jmake/jars/jmake-1.3.8-3.jar com.sun.tools.jmake.Main -d /tmp/jmake -pdb /tmp/jmake/analysis -pdb-text-format -jcpath /Users/zundel/.ivy2//cache/com.twitter.common.tools/java-compiler/jars/java-compiler-0.0.12.jar:/Users/zundel/.ivy2//cache/org.fusesource.jansi/jansi/jars/jansi-1.8.jar -jcmainclass com.twitter.common.tools.Compiler /tmp/jmake/A.java
The output is:
$ cat /tmp/jmake/analysis
pcd entries:
1 items
A /tmp/jmake/A.java 1413839986000 3578666871 rO0ABXNyAB1jb20uc3VuLnRvb2xzLmptYWtlLkNsYXNzSW5mb+rCYhTPBpzvAgAXQwALYWNjZXNzRmxhZ3NaABZpc05vbk1lbWJlck5lc3RlZENsYXNzSQASamF2YWNUYXJnZXRSZWxlYXNlWwARY2hlY2tlZEV4Y2VwdGlvbnN0ABRbW0xqYXZhL2xhbmcvU3RyaW5nO1sAEmNwb29sUmVmc1RvQ2xhc3Nlc3QAE1tMamF2YS9sYW5nL1N0cmluZztbABdjcG9vbFJlZnNUb0ZpZWxkQ2xhc3Nlc3EAfgACWwAVY3Bvb2xSZWZzVG9GaWVsZE5hbWVzcQB+AAJbABpjcG9vbFJlZnNUb0ZpZWxkU2lnbmF0dXJlc3EAfgACWwAYY3Bvb2xSZWZzVG9NZXRob2RDbGFzc2VzcQB+AAJbABZjcG9vbFJlZnNUb01ldGhvZE5hbWVzcQB+AAJbABtjcG9vbFJlZnNUb01ldGhvZFNpZ25hdHVyZXNxAH4AAlsAEGZpZWxkQWNjZXNzRmxhZ3N0AAJbQ1sACmZpZWxkTmFtZXNxAH4AAlsAD2ZpZWxkU2lnbmF0dXJlc3EAfgACWwAKaW50ZXJmYWNlc3EAfgACWwAPaXNSZWZDbGFzc0FycmF5dAACW1pbABFtZXRob2RBY2Nlc3NGbGFnc3EAfgADWwALbWV0aG9kTmFtZXNxAH4AAlsAEG1ldGhvZFNpZ25hdHVyZXNxAH4AAkwABG5hbWV0ABJMamF2YS9sYW5nL1N0cmluZztbAA1uZXN0ZWRDbGFzc2VzcQB+AAJbABtwcmltaXRpdmVDb25zdGFudEluaXRWYWx1ZXN0ABNbTGphdmEvbGFuZy9PYmplY3Q7TAAJc3VwZXJOYW1lcQB+AAV4cAAgAAEIAABwdXIAE1tMamF2YS5sYW5nLlN0cmluZzut0lbn6R17RwIAAHhwAAAAAnQAAUF0ABBqYXZhL2xhbmcvT2JqZWN0dXEAfgAIAAAAAHVxAH4ACAAAAAB1cQB+AAgAAAAAdXEAfgAIAAAAAXEAfgALdXEAfgAIAAAAAXQABjxpbml0PnVxAH4ACAAAAAF0AAMoKVZwcHBwdXIAAltaV48gORS4XeICAAB4cAAAAAIAAHVyAAJbQ7AmZrDiXYSsAgAAeHAAAAACAAAAAXVxAH4ACAAAAAJxAH4AEXQAA2Zvb3VxAH4ACAAAAAJxAH4AE3QAAygpSXEAfgAKcHBxAH4ACw==
dependencies:
1 items
/tmp/jmake/A.java A java/lang/Object
Notably missing from the analysis file is any mention of B.class defined in A.java
Workarounds
One way to work around this is to move all of your toplevel classes into separate files. Another is to move your other toplevel classes into the same class as the name of the .java file and make them static classes.
Cause
t looks like in PCDManager.findClassFileOnSubsystem() there is a shortcut they use. Working from the .java source file name passed on the command line, Jmake expects that the .class name is the name of the .java file.
Possible fix
The name of the .java file is encoded in the .class file. You can see this by running doing a binary search on the .class files:
/tmp/jmake $ ls
A.class A.java B.class analysis
/tmp/jmake $ grep -a java B.class
SourceFileA.java
Bjava/lang/Object *?? ?
One solution would be to scan all the class files, read the source file name out of them and build a dictionary. of class file to source file name. For large classpaths, this might not perform well. Maybe there is some other way to get a list of .class files output by the compiler? Regardless, after building the map from class files to source files by pulling the info out of the .class files, I think the rest would fall into place without too many changes on the jmake side. To complete the integration with pants, there would probably need to be some additional work on jmake_analysis.py.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.