papahippo / abcmidi Goto Github PK
View Code? Open in Web Editor NEWunofficial repsoitory for controlled quality improvements to the abcMIDI suite of (C) programs
unofficial repsoitory for controlled quality improvements to the abcMIDI suite of (C) programs
The current code checks for a POINTER value between 0 and 9 whereas it should de-reference the pointer and check for a VALUE between '0' and '9'. This bug is actually reasonably harmless: it treats all V: commands arguments as arbitrary strings; the special case for numerics e.g. V:5 is never identified.
Nonetheless I have fixed this because presumably the special case handling of numerics has some value.
compiler ouput... "parseabc.c:1771:3: warning: format ‘%s’ expects argument of type ‘char ’, but argument 3 has type ‘char ()[4]’" ... is quite right; abcversion NOT &abcversion represents the start address of the string.
Also there is no protection against an input string longer than 3 significant characters - except that it will usually cause a segmentation fault.
There is a case for moving this functionality to within the 'event_specific' function, but - this being the first change under the new way of working - there is also a case for a "softly softly" approach!
As far as I can find, this %%abc-version is not mentioned in the abcplus PDF documentation and this variable has no influence on the behaviour of abcmidi etc.
To be fixed within branch 'warnings'.
Need to fix:
matchsup.c:2012:3: warning: format ‘%d’ expects a matching ‘int’ argument [-Wformat=]
else printf("%d %s %d %d %d %d \n",i,featname[j],pitch[i],num[i],denom[i]);
Use of & where no appropriate causes...
stresspat.c:518:5: warning: format ‘%s’ expects argument of type ‘char ’, but argument 3 has type ‘char ()[32]’
... and another similar at line 521
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.