papahippo / abcmidi Goto Github PK

Need to fix:
matchsup.c:2012:3: warning: format ‘%d’ expects a matching ‘int’ argument [-Wformat=]
else printf("%d %s %d %d %d %d \n",i,featname[j],pitch[i],num[i],denom[i]);

Use of & where no appropriate causes...

stresspat.c:518:5: warning: format ‘%s’ expects argument of type ‘char ’, but argument 3 has type ‘char ()[32]’

... and another similar at line 521

compiler ouput... "parseabc.c:1771:3: warning: format ‘%s’ expects argument of type ‘char ’, but argument 3 has type ‘char ()[4]’" ... is quite right; abcversion NOT &abcversion represents the start address of the string.
Also there is no protection against an input string longer than 3 significant characters - except that it will usually cause a segmentation fault.

There is a case for moving this functionality to within the 'event_specific' function, but - this being the first change under the new way of working - there is also a case for a "softly softly" approach!

As far as I can find, this %%abc-version is not mentioned in the abcplus PDF documentation and this variable has no influence on the behaviour of abcmidi etc.

To be fixed within branch 'warnings'.

The current code checks for a POINTER value between 0 and 9 whereas it should de-reference the pointer and check for a VALUE between '0' and '9'. This bug is actually reasonably harmless: it treats all V: commands arguments as arbitrary strings; the special case for numerics e.g. V:5 is never identified.

Nonetheless I have fixed this because presumably the special case handling of numerics has some value.