IndexError about pypte

[patrk]

Thank you for pointing out the potential "IndexError" in the compute_PTE function. I understand the concern about the non-square nature of P_y_x and the possibility of an index mismatch.

The current approach of using the .max() method to determine the size of the arrays might be a source of this error, especially when there's missing data in the sequences. I'll be looking into more reliable ways to set the array dimensions to avoid such indexing issues.

Regarding the delay estimation, while it's a broader concern, I'll take your feedback into consideration and evaluate its potential impact on the accuracy and reliability of the entire procedure.

To help me better diagnose and fix the issue, could you please provide some test data that reproduces the behavior you described?

[patrk]

a quick fix would be to ensure that the matrix P_y_x is square

max_dim = max(y.max(), x.max()) + 1
P_y_x = np.zeros([max_dim, max_dim])
np.add.at(P_y_x, [y, x], 1)

I cannot guarantee the correctness of the algorithm at the moment, though.

Checkout this branch: https://github.com/patrk/pyPTE/tree/12-indexerror where I applied this quick fix and let me know if it helps. #

[patrk]

I deem the fix as suitable after some testing and incorporated it in the recent refactoring.