GithubHelp home page GithubHelp logo

paulinakhew / web_trader Goto Github PK

View Code? Open in Web Editor NEW
26.0 6.0 19.0 6.95 MB

๐Ÿ“Š Python Flask game that consolidates data from Nasdaq, allowing the user to practice buying and selling stocks.

License: MIT License

Python 37.52% HTML 62.45% Procfile 0.03%
python stock nasdaq profit web-trader sqlite3-database sqlite3 html css bootstrap finance trading stock-market transaction password-hash api flask-restful

web_trader's People

Contributors

dependabot[bot] avatar ishan3299 avatar paulinakhew avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

web_trader's Issues

Change return_list into a class

In the functions that involve db work, a list is passed as a param:

return_list = (last_price, brokerage_fee, current_balance, trade_volume, agg_balance, username, ticker_symbol, current_number_shares)

this should be converted into its own class in a different file that is imported at the top of models. This would also help with testing as we can use an __eq__ function

Add docstrings to all functions and clean up code

  • this issue just has to do with code readability
  • in the future, when building this out, each function should be properly labeled and its purpose should be easy to identify
  • this website has a lot of popular docstrings formats
  • Add docstrings to all functions in model.py
  • Add docstrings to all functions in controller.py
  • Add line separations within functions
  • remove unnecessary commented out code
  • implement flake8

App doesn't actually log the user out upon exit

Screen Shot 2019-03-15 at 9 40 19 PM

  • I queried the database after I finished a session as paulinakhew and it still had my account under the current_user even after I signed out
  • Create a function that functions similarly to seed.py that resets the current user to the original
  • this issue is related to #14 since I need to make sure that the current user is always the seed user

Fix alert in create account page

After creating an account, the app does not redirect to the main menu page. Instead it stays on the same page with an alert that you should create a different account. The newly created account exists in the system.

  • Fix this bug ๐Ÿ›

Create a redirect for when users log out

  • this is a better way to code user logouts than just immediately redirecting to the login page and changing the current_user in the SQLite3 database
  • Add the /logout page
  • Add an alert to the /login page once the user has logged out

Image on Menu page not loading

Hi Paulina!

I tried out this app, and had an issue when rendering the menu page:
screen shot 2018-09-26 at 9 06 20 pm

I got a 403 error attempting to fetch this image. It looks like it is hosted on a third party storage platform, and doesn't have public read permissions set.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.