payex / payex-sdk-php

PayEx SDK for PHP

PayEx SDK for PHP

SDK for PHP, as a part of PayEx' Commerce offering, is being rebranded to Swedbank Pay and as such you can find its source code under Swedbank Pay SDK for PHP.

payex-sdk-php's Issues

Set up Travis build

We should set up a Travis build for this repository so we can execute the tests written in #2 automatically and have Travis report its status back to GitHub. How this can be done is explained here.

Allow setting User-Agent

To be able to distinguish different implementaions of this library from one another, it should be possible to set a $userAgent parameter that is used in a User-Agent header which is sent every HTTP request against PayEx' API.

It should be possible to set custom HTTP headers in the stream_context key of the options array parameter of the SoapClient constructor:

// We should of course figure out which version this library as well as PHP we're running dynamically and not hard coded liket his:
$userAgent = $this->_userAgent . 'PayEx.Ecommerce.Php/1.0.2 php/7.0.6';
// The stream_context needs to include the 'ssl' key if 'ssl_verify' is set to true.
$context = stream_context_create(array('http' => array('header' => "User-Agent: $userAgent"));
$options = array('stream_context' => $context);
$client = new \SoapClient($wsdl, $options);

Since the stream_context is already initialized in __construct(), the header key can just be added there along with the already existing ssl key being set if ssl_verify is true.

The format of the User-Agent header should be as per RFC 7231 section 5.5.3. We should include as much information in the header as possible, such as the version of PHP and any library relevant to the HTTP request. Simply put, it should look something like this:

User-Agent: PayEx.Magento/1.2.3 PayEx.Ecommerce.Php/1.0.2 Magento/1.9.2.4 PHP/7.0.6

Add tests

We should have some automatic tests that can be executed to verify that the code is in working order. Travis can execute PHPUnit tests, so we should look into adding some of those.

How to create Payments instance with array $data argument?

Seems like the following way of creating a Payments instance doesn't work:
$data = [
"operation" => "Purchase",
"intent" => "Authorization"
];
$payment = new PayEx\Api\Service\Payment\Request\Payments( $data );
I believe, this is because in \src\PayEx\Api\Service\Request (parent class) in the constructor the $data is sent as a first and only argument (in case if $data is array or string):
$this->setRequestResource($this->resourceFactory->newRequestResource($data));
while newRequestResource method of PayEx\Api\Service\ResourceFactory class expects 3 optional arguments, where $data is the last one:
public function newRequestResource($service = '', $resource = '', $data = [])

PayEx API Service\Request 'send' method throws an exception if any of payment URLs contains a percent symbol.

Hi!

During the PaymentorderObject preparation my PaymentorderUrls are created using the PHP urlencode() function, that replaces all non-alphanumeric characters except -_. ... with a percent (%) sign followed by two hex digits (https://www.php.net/manual/en/function.urlencode.php).
As a result, after the \vendor\payex\payex-sdk-php\src\PayEx\Api\Service\Request->send() method invocation, the API shows the following error:
message: sprintf(): Too few arguments
status_code: 500
debug: {…}
line: 203
file: /vendor/payex/payex-sdk-php/src/PayEx/Api/Service/Request.php
class: PayEx\Api\Client\Exception

Could you, please, fix this issue, so as the 'urlencoding' is widely used in URLs generation?
Thanks in advance!

New addreses for SOAP test

PxConfined https://confined.externaltest.payex.com/PxConfined/Pxorder.asmx?WSDL
PxOrder https://external.externaltest.payex.com/pxorder/pxorder.asmx?WSDL
PxClient https://external.externaltest.payex.com/pxclient/pxclient.asmx?WSDL
https://external.externaltest.payex.com/pxclient/pxaccount.asmx?WSDL
PxMerchant https://external.externaltest.payex.com/pxmerchant/pxmerchant.asmx?WSDL
PxAgreement https://external.externaltest.payex.com/pxagreement/pxagreement.asmx?WSDL
https://external.externaltest.payex.com/pxagreement/pxrecurring.asmx?WSDL
PxVerification
https://external.externaltest.payex.com/pxverification/pxverification.asmx?WSDL
PxMisc https://external.externaltest.payex.com/pxmisc/pxredirect.asmx?WSDL
PxGiftCard https://external.externaltest.payex.com/PxGiftCard/PxGiftCard.asmx?WSDL

Not possible to handle exceptions

The exceptions thrown in Client::request writes the body in the message string

https://github.com/PayEx/PayEx.Ecommerce.Php/blob/079d59eaef4bacc70ad1acedc09cfefff3379a66/src/PayEx/Api/Client.php#L207

The exception object doesn't have any "body" property that contains the error json from Payex API

The only way to handle exceptions with this implementation would be to search in the message string, which is not optimal.