GithubHelp home page GithubHelp logo

paypal-sdk-client's Issues

How to detect closed onboarding window?

Greetings!

We're using the following for embedding the sign up link: https://developer.paypal.com/docs/platforms/seller-onboarding/build-onboarding/#step-2-embed-the-paypal-sign-up-link

As we're testing, we're finding that some folks are starting the process and closing (maybe they meant to change countries), or they're actually finishing the onboarding process but then closing the window instead of clicking "Go back to John's Store website".

When the user first clicks on the link, the SDK puts a dark overlay on the screen while the onboarding process goes on. If the user closes the window, the overly is simply removed. We can't seem to find a way to know if the user simply canceled the process โ€” or if they did finish but didn't click the 'Go Back' button. There's checking the response.ok, but this seems to only cover errors, which these two scenarios don't appear to qualify as.

Any direction you're able to give for this? Thank you!

PayPal CloudQuery Plugin?

Hi Team, hopefully this is right place to ask, if not, I'd appreciate if you can direct me.

I'm the founder of cloudquery.io, a high performance open source ELT framework.

Our users are interested in a PayPal plugin, but as we cannot maintain all the plugins ourselves, I was curious if this would be an interesting collaboration, where we would help implement an initial source plugin, and you will help maintain it.

This will give your users the ability to sync PayPal data to any of their datalakes/data-warehouses/databases easily using any of the growing list of CQ destination plugins.

Best,
Yevgeny

Invalid authorization code

we just noticed that, when use paypal authentication. it will return authorization code. But to some specifc user, when we use this authorization code to exchange token, it always report 400, and the payload would like:
{"error_description":"Invalid authorization code","error":"access_denied","correlation_id":"2ac9f7fa4e099","information_link":"https://developer.paypal.com/docs/api/#errors"}

web-client repository infrastructure

There is a card to take care of a couple of tasks in this repo and I feel like we need input from other folks that will be touching this code before I sign off on this card.

Reviewers (Feel free to add folks to this for review):

These are the tasks that this repo needs to setup for infrastructure:

  • Build
  • Lint
  • Test
  • src dir structure
  • test dir structure
  • Docs
  • Assets are in a deployable state

I'm going to summarize it currently in point form. Please comment on this issue with questions, or just ๐Ÿ‘ if you're happy!

Build

  • Babel transpiling
  • Builds to webpack
  • Uses flow

Lint

Test

src dir structure

  • Currently just js scripts in src/
  • I could see the structure being:
    • src/component/Client/index.js
    • src/component/Client/shared-config.js
    • src/component/HostedFields/index.js
    • src/lib/polyfill-assign.js

test dir structure

  • Currently a karma test skeleton
  • I could see the structure being:
    • test/unit/Client/index.js
    • test/integration/Client/index.js

Docs

  • ESDocs
    • Removes flow flavored code
    • Generates HTML that we can host on ESDocs or though GitHub pages

Assets are in a deployable state

  • Git holds on to dist/
  • Built assets are assigned a tag in git

Flow syntax error

In the flow type definitions, this seems to be a syntax error:

https://github.com/paypal/paypal-braintree-web-client/blob/3c7b64f560bd5b58d55235c5b66eb91ce3d3027d/dist/module/index.js.flow#L49

at least the flow command says so:

49:   toPromise(): Class<Promise<R>> | Class<Promise> | Promise<+R>;
                                                                ^ Unexpected token +

and flow.org/try:

https://flow.org/try/#0PTAEAEDMBsHsHcBQiAmBTAxtAhgJzaFtgM7GgDCOpAjKAN6KijEAu2LAlhqACQbbRoACgC2aUtgDmaAPwAuZi1wcAdpICUCyiWLUA3I0XsuhbAAcWAV3wBlNhgDWAFVzYMaIW1zSWCgPIARgBWmCwANISwKqy4lhgssLjyoABilirxHFGaoABusBwoBkysxtxm+GZ4aHZuzq7uCkJouLhaVLoRpY4KAIKt2ACeADzkAtA2HCxoAHzqoAC8M6AiHAAeaEWGpZzc3fVuaAAyHKu+oCqWIgEtBoYYsNBXKgByVzdJCpfXt4boxBhlBYsipkjFVJJiqBIBxoGgXtgxGClBCodBVPD3i1kt8PlCxBJpApwWooSpEWhiSjSYZcdivljcFD9lTlDSmA9oko4glcKJxMQpLIFKsNigcvlClCEnY2ZIhDkSZDEABfVCYHD4QgdCgdAAM9G2bF2oHGwwAGgoANqizagYAAKlAAFUXgBRc0ABTd5CcboAIqAnABNb0KN1rDisYhOUAO4AAXVAAB9QDb1nbHS73V6fX7AyGw6AI1GWDG48AIraUPana6Pd7fQGg6G3eHI9HY-Gk6n02La9mG3nm4W28WO2Wu5WVhma1n67mmwXW+3S+X41XZwOF438y2iyXOxWe2nq9uc7uRyvx2up5v+-OL8PlweJ+vp2fH0Ol-ux4fJxW96ZnWT4-qOq5Ht2KanluX6Lnu4E3pBH6wSB34Ide-7vkBc5ofBV6vregEzg+eGXi+f5vneJHAYO+EURBAFQb2n5kc+v6MdhNG4XR5EcUhTEoaRvHsYhWHUaxIlgZhVHEZJO6iTJREbtx57oQRlHKYm0F9rRCnSYRyE4Wp9H8eJcmoVJGGGYJxlwXxYmySp8mgdZmlGap9mKTZXEuepDECe+J66Tx+luZxEmWWFGkRRZwnRQF5nOVFrkxYFkXxaliVOUJelZWZOV2WxBnubZnnFeF6XHjpfmmY5WlFVZaVJbloX5fVHm1Q5SmdSl-kFQ15VNdlg1dd5pW+X1dU9WVY0lbFzGgP0rgjNWMwzEIFSwKsxDiAo5o5NopB6sMc2VW6uQCFOMzMsaJjoDggxCA9QwMj8uCHfqwySigN1GmU0JPMQAAWCrtDoJ0-X9JR3dwMCWCDACKlhoCjYOmiogy3QDwMkMDwx+AodBWgA+qyEIJiKU3dT5U4qhtW07XtoB+J9EOndT43hpd0DXdjJpRp6uDbVGHg8yjVNijkASwI8aDYCo-MmCI5jDE4ETmhtUxoCIxB9AMIxODMVZoCwwOwCgTRk0G8xLLq7Oa9BB3g8dwzLUMFrrUr3BRJ6sCkBwATQIMzoqLjKgoHCKARu4wJREI4eRy0TQtG03G28sP05HQ-AZGg0BNBneQFCgKre6A+AhPEzStIkkubGzrsAErQ0YJr4MQjy5GgntCOLlKgOa0FHcQJ2a43o+e+XSgjOaETBhE5ARL0+srRzYrrfyZsW00AB0+94JIetLUXI9j8sqYL5EKjTGs5wyEvpreMfMi9BPY-QcGf1-FGVQsBgwMIQKBlnLBWUJU5124uA2uuAAASCsk6W1ACAuEYDDCJzhLgY+7sRh0CiG6GBCgfrQRrsLNO1Yi7VgiFEGwcR3CkCISXEhHdLDQHOE3Shs4IiM1Fi7SeZ1mo5RmPTKEldQibGAbLVBitDAdy7hI5BUj5YyKYP3BQTcoQkEGBkJuaAq4sFIZAihCgFZY3uOwABFp54bXwYQ0AhjyGzlPl9R2l934Wk-q3TkMQeSJATggzBCgZBCDkdAbuTQWFsPUUXH6EQxHxBTnYihixM4lxiWkkxmMoQoF-hY0GORTFQhhOSQQT0MHJ3sZwqWfCTot1EXo0IDj67ihqcMOpsjxDyJCeIVh7D3HtKYGbNAKgrGgC-kIGhdCBSMMKMwnpUTQAcJSfbV2rixnUJUAQshMyaypiaenZZZ9Paf3cUPS+rdOBiFgJYAxlyB50lwBEVOQSR7UH6Rc2AQsRa7XRiPYYXymZtPWsPDo-zhZMwvqAAFothgAGp2lqnQEQLUaA1hmESCwPIeAKB+FdE4JuwYia9H9AoAARMS0ly8xzkrdJSpaABxMlvR6V0t6AASSZWy1lRwmVHFZQAWSZfy1lLwmUvFZYTUA5K-CsqbkypurKnBMqcKy50TLnSsoAOpMs1aygAWkyvVdKABCK8pWmpNcaslxrjUmupca2lERjUpGtSkE1jLzUsqdbA61sCTUcvNVyp1AApa1waTWCvNcKp1orzXiqdZK0lxqZVOrleahVTqbDWpsCapV5qVVOu1ea3VTrCXmuDCag15qjWLzNaS8gvQ6XkBJVK5tTaPX1q9RQH1ra-WLwDfWoNFAADSZLyDDqbTy1tfLF6RvrdGigsb63xpxWOlNFA031ozRQAAamOndTay31orYvKt9aa2gH9NSq9dL-ShqlXe29o6H0ToiP6Od77b2Jv9Ou-0Z6-10p9GSn0gHqVukdcWDtbou1uk3bBwDWapVuhzREN0ebSVobpSkAd2GsP3tJSkcNEQUjPoI6+1Ic6UgLpSImmjWHN0pG3fSutzG6X0qtVK9jbGW2kvpf6Nj1L6UQfpS6zjbqIj0oHZJtjU7eMztAPSudim2NLvpSu+lnoyUabY5u+lTH0P0oLQpotvGS0KaPfSk9oBYGkZs3S2BS6HP2c3bA7dsC1VSvc3StlPGfPeepWyiDbLZPBe80utlK62WIdJVF7z6G2VGeDXOpLdLg2JrS6lzTUrg2ejpcO6l+W8sduHV24dPbSVlbywO4dQ7h1zrq3lpdw6V3Ds3a1vLJnh1meHUenreWz3DovUcOtw26VHHIGS8bY2B1HCHUcUj82xvRaOCh0ARx0PrbGx50lRwNURCOHuqVB26X8rradk7E2pX8vICdnj-L+MRH5dSp7J2O38q7fy8rn2Tukf5eR-lsmAcnaXfyld-LEZkvBydzd-Lt38ui-Dk76H+VGf5dttHJ3Dukv5Qex7Jn+Vmf5ZaK75oTtHv5VZ-lZ6qd0peHWuntPLukpeDdiI7oyXulp6J5n4nQAvA7fz2nA6XhDpeLJsXtPE0vHXS8LLzPcts83S8bdLxtuq9p2el4F6-Bzp13Sz0daDf6+pd6fX3PPS889B2q3+vyuej7VC2Tnp5Oejna7-XS7PQrs9Ohn3+uTOejM56I9we6WIzreHulTdqXR6j4mpu66m7RaT1H7bTc9uLJM03MzNg6257pTYDjpLC8F6ZzYVnoAbDUqrwXjtNgu02HK43gvA6bBDpsPhjvBfSM2HIzYWT-eC9zpsAumwS6x8F8TTYddNhN2z4L+hmwRmbBY5XwXs9NgL1OCZ9vulTgeP773x2pwXanDlbP3v-DTgiNBjnU4BdTgl2P734mpw678VkvxXv9DTgjNOCx--nviZk4GZk4GemAXSs6HWlAZAR2s6F2s6NFogZAUes6FZjunWhgXSjukzjgdgdSjuhBjuh2sQdgUujuiujuttlQXSpqtznQbQdFpqqtsGNSqwXSsGOhpwXSnqnWrwTwXOnqgunqiZiIaSmXOqMigQKiuirgJipdLgDinigSiTMNvzohsTNbAIolDzFOJTEtAbOvHlP1GJLoRWMIgYDIRiqACwIMGYAQJQBwMMiwH4HHNEE4HYQQAsPQNgDcsDMkJoeTGoPoUqCqE8ioLkEEZIBIVYXITYZ4RQNcjfLgIMEcArEfIsPQMSmSsMqStBKSpALgHkamKSuIMUVKgAF7AysrUq5H5GFHlGlHECNFVGNF4Csodp1ElENH5FlH5GtHLwDpdFSo9ElF9ElEDFLSya5HLxzrDEFFFG9HNH9HVHLxLrzGjFSrjGVGrFLSJobGLFjHLETG7G9CbrbGlEqCKpkroCNEzFLTbb3G9AmYHF3HHE7H6o5FXH1GHFbHvGkqTGmpfGWrAk-FvEtG7EOqgklEqDQCNENFOrc6bGXHgkrHurAnepkrtG9HfHdG-FNEQn+pkrInzEXGAn4Ykm4l-GElOpzFUkLGoknEmrrFXEJo5H-GvFomppkoWB3GsmgDGrRaclHE0kCnob3HGovH0kkn-GAlHoSlnqkn-HImTENrQkjFFGLw8aUmMkfGLydHSn4lkm7HkDla3Fgk4lNoDo6mLykbCnUlckUDTEcmGminkBzo2mLpkqqn7Eunwn4mqnnF+kWlMmLxY72kEmOnkDyn8nkBnoYDBl4m6kAm7FXo3FoB8m3oUlGn0nGlPo3HYCZlvp0n+nJmTE-rsmZkhl6mXpnrYljGulLGilAYOkNmlmOngbqmkqxDtkikdkdr1lbGNl9mhnFjnHDmtk1nIaVmWmobikTmRmjnYbEkcBVlJlNmOmEZdkymikkbblGmym7FUYYmpCJooCFmWnVmLk1mMbEk5lsZ1o6kbmjnsYnl8b7llm7FCYfnPk1kiY-kjl-lDELl5kSaybnlrkamflsYllXmgUKZLpPmAUplsZy4RnwV6Y5FwmXnrnIWTGGYzltlXn4VSm9mTkoUSYxlkXXkUXWZ2n0mTEOaEVDnUWMXjn2bbbAyWCQUMm-m0U+ZkqFBFmgCBYAXkWTHBZkrAwZmzkiUsneZCn8kJaCUsDCVJZdkXEqm7FpZYn3lwWHmZZkpBAXltkRD5ZiU0WTElYWXwVlYnk1Y2UGVmUel6V4W7HNaOWimtZkoOCwDCVda6U8U7mOk9aeUhWKkgVOVrZ1r3HjZhWjmzbxU1nzYnkrZJW0XrZdk9n6Wim7Zdnmm4XiW7EHZZXcU5WOmnaBU4VQV8WTHXZ3nCX3YnlPbNUGnUXwWfbpV1X0UnayZIVFXA7NUQ4sXlWjmw5dW7Hw4TVI7NWPGRWik47NWkWjU1lE7MUomPZUWPYRXtVRV07TVs5M7oV7XUr9WWW7EvDc7HWin84nki7rURmTFi5kqwnCXS4vV+WyWy53XsUrW0Wq4HV847V-WTE65VVEWFXnX64xWJk1WjlFg0WPW7EW6A1W6o3lb3HO48nYWmVQqwWQ3wVe6o3oa8myWB6o3yl+kRDh7TX5HtERDR6A0J5M2KW7Winp5krZW43Z4NXVVQ0RC57g0jUE1RWF6A3l680Q0DUC3UrEC5DCX14nmN7i3AVs2Okd7i2kbEAOBBUHmin97i341w3S2V6IWuUm3T7i2-Ui363zlq2jkr4PULmTGb6A3b5u3anm381BgdpnXwVn5kpmzCXX5u1G28VuV75LqDkokg27Fv4nkf5SpKDB122x177hnzWOkgHenVGyVgGA1QGlX201nwEF2s1p0RBoFO2sW7EYGA04H121Gw3h01nEH13yURBUGA10Hd2s3zzUrR3XWOmcGA28Gj1h3BWjkiHAkSFIqajSForWEKGXpugpC9DOjrYkxugvBY5bQoA8ggikoGBz3VCgCxHyHYrb2HZ0BXr8pnk6x+X7Z+ANqyZwD8BwkRCegJ7+jOi+hsp+BLp70H1RAF69AvD+jJrE6kqCgRwyxrAL7Mqy1sDSB77IbobTCsDiGWGL1xG2H2HjiyGTgJHeGBGKByj6HViz0ain3n1YqKEpA+5sokz+i9BOC9AkzT7OhNzkBjh0AG7BhPYvBOA2AcP+ikZVCDBiA3zEAkzEAoA61UNSFn04MX30OMMkwpDgYtp8O9ACPb3COiPiNDBSNliyPyNYOSHz3KOEN0OpDqP5Zlp0DGrOi-4AOqG6O4roYBA3IJAqAkyPTXKqVOouNv4vAcPIZt5uPOgCVSreMsC+OyMCgggkxCXBOuNhOcPcPUpxMJOdzWDuAmohNuOISko5NRAkx4MZmLywJ+BV5hMpCuj+gRYdq7RwjxCbAkwSMmMkxiDbwoCTqBZCMkwxOkpYBOE3wpP9OLwAN+jmhODDM8aci3wsCTNNozMejzMlNLOoorOVO3qsPsOZM8Nkq7S4DdxYKFBoAkznlsCyPXK4AFOoZNwJ5NwkzkB+BplbF3wkwQK4AkwPC3FPMvPMPIZHXfO-PXPiAYCAa5hNxsqCPzN04tVSpmBoo-NoupOpBaPEloAdPkhiBYaNPNNvO4pCNYUcCSCBxwidPGPOH-NJFBOpBEv86qFRbinoiUtBxXNdN0u9PmwoDNGf2IOqF+DEokxODwvUpVDSD+OwDYAoAVOnBVNQq6MLM8lDCrMM2r2wawac1oCQAtAtAkzWAf2V5uhHBHCwZqtSqtOYKatms2CRNhPRM8bStXO7QBzlOYtL6sNIPsBXP4vKtv75ZLoJAOD3H4pgNt4SsAOB2uDRBTDJOBt75NxRsJb-1hMSvIukpKAKzECJvlN3IptuisMIskxItStotKAsAiATOYuEFJ4ZtkoAKYC+U3JBAyPnP5sgMxEqPxH4NpARwQhugcuBywhTCDAeH4MkMBAKxLNuDnB0ABDxvoBIIoLKJPKjtcuSKgIqBhGmC4BIJLsrsKLrsKybsUtUsDxnsqARDdwRyJDHx0AUhrBEz5yXvbuKK7v7s5IAiwDnNvtbtwg7vSL7v5ywCAcfvAdfugcRCAL2Fpx0DvucvQc3v7tBAYABCQcofXtKIKz7sqysAtD8CHvYdXsgfKL7u5BRjYBkeftocqj7uAibBTBEzLsIKnt4e3tn1Ae4fftPJmBPvscRyce7sXs4cUf4cRCUvCwSNscntrtcfifkcweUcRCXMCDycceKdic8dQd8ewcrCDCzsqAOBacic6fSLKf0dcf7tmAABMAALOZ6u5J9x8hyp2h9wkMFUAXPQMJ656p+e3pxJ0F3u10GgFUC56J1ZyF557Z10LAJABitF5Zxu3FzZ-x3kMMiIBB-5wp259Z6hwl6APAJgLjCwHJ-l9p4Vxl8V1lxUacGYIEtVxZ7Vx55l6B4o1Y7Q8vfSkcH4KakcCTA41EcfdQyin231wN0N+W70E9jYAbsc2Q6iJYzQ1N9imoR6nQGcYFYvNFgmfswWbetSoC8WNMaa9vSedOdScRtaaucRpugidZtStJRxVJdxRECM5i8pVKlMKlnWsZXlomr5bTrJq9WzomioI-Y7tjfriTYyxzVKj2QLVrTrQLVjnLXvuVkHREInTm5qaAHquVq0b2zY5U2trAO-WgFO14fQA8OkDPM0iZDTH+GYSpDgGoMz15PNMWOz8AGT9YRT8jC0IMK4ZwFEDGMQ-T9tOiioM4dgoYUqMbGfREVEREG-QIAPDnAyyker6AJz5IFEQR8R+HCwDE6Edg+TwkTYGI-SnALO7zNL3QAAI4owpHi8ghPsPAiBy8K+rwezK-hGRErdqAa9U9a9EwM-JGDD6+G-G8mwPNm8W-UjRHdfrc2PL1cNpUYxmIn2Tc2OQDpCZBRCmjxNuCgy5f71wgIhiD6-n3GqWCwjoBpxCDWw5zojOGe+S9Ey+FmwBGkxREhGp9gdq+h9p9FykNKgUOzgqgSglzjdKO0NF8ZAS8qCgA+A2BJNRA+boxKiL89cbeKFwCSDSCIfysoCwLywt+N-N8VJt9WxEyD-j-D9yhz-LJT+p-6EyChHpKFARAX9+UpsbALf2gAt9H+9idvs-2n7G9J+0Ar-kEl-7LJYkpoFACgE9BDA4A8rUAeAMgEQDP+5DWAR-3gGEDQAP-Efn-xQAAC0BLgOoBCBwH39rYD-egCQIphEC7YBAtgWQKQF2wUB6Abxkb3sSBt9eEjLASgAH7WwYB3AigcgJLhPI7EQgYQeP286DAxBEgofogJkG8C5BgMBGMDELiHIvoUMdTiIDEA5J-WKQIGPoMqSGD2Yxg0AKoGS5NAlBSoFQWoKf6SCEB0gt-pQIi4sBaB0QQhhAOYF0BpK8rFoE+1YHBEE+oADtlEH8DBBQgJsPpvrxNbsDlgRyKGL4JsINAzO9iUQXKyPZRDJA3-Hgakn-6lc8AKgZwRSBEGYDCh6gl-poJ8GyDCgEhIAA

QUESTION: Where am I supposed to ask about webhook?

Hi, sorry for the random question.
I realized that the webhook is not working since some hours ago.
Not sure where to ask about this though.
I checked the API status page and it says Sandbox system is working correctly.
Please let me know if this is something I can expect to be back to normal soon.

Smart Button onError callback not firing

Greetings!

We're tightening up our integration by making sure we've got error handling locked down. I'm having trouble getting the onError callback on the paypal.Buttons(config) to work properly. Here's the thing, though, it's working just fine in this codepen I threw together: https://codepen.io/JasonTheAdams/pen/gOrKyoG

Clearly we're doing something different. Here's what we've got in the application:

		paypal.Buttons( {
			onInit: onInitHandler,
			onClick: onClickHandler,
			createOrder: createOrderHandler,
			onApprove: onApproveHandler,
			onError: function( error ) {
				console.log( 'In this function' );
				console.log( error );
			},
			style: {
				layout: 'vertical',
				size: 'responsive',
				shape: 'rect',
				label: 'paypal',
				color: 'gold',
				tagline: false,
			},
		} ).render( this.smartButtonContainer );

As you can see, I've just got a closure for onError, however "In this function" never shows up in the console. Here's our createOrderHandler method which throws the error:

	async createOrderHandler( data, actions ) {
		Give.form.fn.removeErrors( this.jQueryForm );

		const response = await fetch( `${ Give.fn.getGlobalVar( 'ajaxurl' ) }?action=give_paypal_commerce_create_order`, {
			method: 'POST',
			body: DonationForm.getFormDataWithoutGiveActionField( this.form ),
		} );

		const responseJson = await response.json();

		if ( ! responseJson.success ) {
			if ( null === responseJson.data.error ) {
				throw {};
			}

			throw responseJson.data.error;
		}

		return responseJson.data.id;
	}

It is throwing the error, and I see the following show up in the console:
image

Any ideas as to why the onError callback may not be getting fired?

Action Required: Fix Renovate Configuration

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: undefined. Note: this is a nested preset so please contact the preset author if you are unable to fix it yourself.

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

Detected dependencies

github-actions
.github/workflows/main.yml
  • actions/checkout v3
  • actions/setup-node v3
  • bahmutov/npm-install v1
  • codecov/codecov-action v3
  • codecov/codecov-action v3
.github/workflows/publish.yml
  • actions/checkout v3
  • actions/setup-node v3
  • bahmutov/npm-install v1
npm
package.json
  • @krakenjs/beaver-logger ^5.0.0
  • @krakenjs/belter ^2.0.0
  • @krakenjs/cross-domain-utils ^3.0.2
  • @krakenjs/jsx-pragmatic ^3.0.0
  • @krakenjs/zalgo-promise ^2.0.0
  • @paypal/sdk-constants ^1.0.94
  • bowser ^2.0.0
  • @krakenjs/grumbler-scripts ^8.0.4
  • @krakenjs/sync-browser-mocks ^3.0.0
  • babel-core 7.0.0-bridge.0
  • cheerio 1.0.0-rc.9
  • cross-env ^7.0.3
  • esdoc 1.1.0
  • esdoc-flow-type-plugin 1.1.0
  • esdoc-standard-plugin 1.0.0
  • flow-bin 0.155.0
  • flow-typed ^3.8.0
  • husky ^8.0.1
  • jest ^29.3.1
  • lint-staged ^13.0.3
  • mocha ^10.0.0
  • prettier 2.8.8
nvm
.nvmrc
  • node 18

  • Check this box to trigger a request for Renovate to run again on this repository

Specify orders versus subscription when displaying Smart Buttons

I wanted to expand on #44 (comment) โ€”ย I believe that issue is resolved, but we have another need I want to clearly spell out.

Our product, GiveWP, provides our customers with the ability to create a donation form on their website. The form can be displayed either as the page is loaded, or in a modal once a button is clicked, or some other way. This creates the common scenario where a page will have more than one donation form displayed at a time.

Right now, the SDK seems to be built around as a global, wherein the SDK applies to the whole document. This is especially evident as the intent=order or intent=subscription is defined as a parameter of the script. In #44 we were given the ability to change between orders and subscriptions by reloading the script, but this isn't a perfect solution in the context of multiple forms potentially being in separate states (i.e. one in single donations, the other in recurring).

As @ravinderk found, we're able to process Orders and Subscriptions by setting vault=true and intent=order, however we get a warning when the Subscription is processed. Is this something stable we can continue to do? Or will it likely break at some point?

In our perfect world, we wouldn't need to globally set whether we intend to process orders or subscriptions, but handle it on a per Smart Buttons and per Hosted Fields basis. Does this make sense?

Allow for switching between Orders and Subscriptions

Greetings!

I work with givewp.com and we've been working with an integration manager at PayPal since June to provide integration for PayPal Commerce.

We've recently run into a problem with this SDK wherein the vault=true parameter must be set at the time that the SDK script is loaded. This means that the SDK is locked into either creating Orders or Subscriptions once it's loaded.

This is a problem for us as our product provides organizations with a donation form to put on their website. During realtime, the donor may decide whether they're making a one-time or recurring donation. In fact, the donor could even start willing out CC details, then decide they want to make it recurring, tick a box, and continue. You can see a couple demos:

Is there currently a way of switching between Orders and Subscriptions at runtime? If not, we need that for compatibility of integration.

Thank you!

Allow to destroy existing hosted card field

As per requirement, we re-render smart buttons and hosted card fields when currency changes because PayPal SDK only processes currency which we pass in query param. The smart button can be destroyed by calling the close function but I did not find a similar function for hosted card fields.

GitHub Discussion: #44 (comment)

Can you suggest the best way to re-render the hosted card field without reloading the whole page?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.