pcdshub / mods-ui

A collection of UI files related to the LCLS MODS Laser system.

mods-ui

A collection of UI files related to the LCLS MODS Laser system.

mods-ui's Issues

Screen re-configuration

Currently there are setpoints and boundaries hard-coded into the screen. These are used to indicate what mode a particular TILE may be in, or to save values for moving a stage to a different state (in, out, etc.). We should make this more easily configured by the laser group in operation.

There are a number of ways to do this, such as a higher level TILE "support" IOC, json files, etc. The current method of hard coding is not acceptable.

Change the screens to use macros

The screens written by the intern do not use macros. This should be changed to make things more re-usable.

Example:

mods-ui/mods_ui/HarmonicsDiagram.py

Line 97 in 39fc3c0

self.MP1_SPO1_pos = EpicsSignal('LM1K4:HRM_MP1_SPO1.DRBV', write_pv = "LM1K4:HRM_MP1_SPO1.VAL", name = 'MP1_SPO1_pos')

Improve and Standardize File Naming

The naming of these files, especially the embedded UIs, needs to be changed.

Style and PEP8 fixes

These files need to be modified to be more consistent with our normal style, as well as PEP8.