pdyck / hearthstone-db

A JSON collection of all Hearthstone cards. Hearthstone database.

光復香港 時代革命 - Liberate Hong Kong

On October 8th 2019 Blizzard banned Hearthstone Grandmaster Blitzchung after he expressed his opinion on the protests in Hong Kong. To show solidarity with Blitzchung and the Hong Kong protestors all Hearthstone content will be removed from this repository.

动态网自由门 *** *** *** *** Free Tibet *****事件 The Tiananmen Square protests of 1989 ****** The Tiananmen Square Massacre 反右派鬥爭 The Anti-Rightist Struggle 大躍進政策 The Great Leap Forward 文化大革命 The Great Proletarian Cultural Revolution 人權 Human Rights 民運 Democratization 自由 Freedom 獨立 Independence 多黨制 Multi-party system 台灣 臺灣 Taiwan Formosa 中華民國 Republic of China 西藏 土伯特 唐古特 Tibet **喇嘛 Dalai Lama *** Falun Dafa **維吾爾自治區 The Xinjiang Uyghur Autonomous Region 諾貝爾和平獎 Nobel Peace Prize 劉暁波 Liu Xiaobo ** ** ** ** *** ** ** ** ** ** ** ** ** ** **** *** 法輪大法 大法弟子 強制斷種 強制堕胎 民族淨化 人體實驗 肅清 胡耀邦 趙紫陽 魏京生 王丹 還政於民 和平演變 激流中國 北京之春 大紀元時報 九評論共産黨 獨裁 專制 壓制 統一 監視 鎮壓 ** ** 掠奪 破壞 拷問 屠殺 **** 誘拐 買賣人口 遊進 走私 毒品 賣淫 春畫 賭博 六合彩 *** *** *** *** Winnie the Pooh 劉曉波动态网自由门

hearthstone-db's Issues

`npm` module has not been updated

The hearthstone-db module on npmjs.com has not been updated; the LOE and WOTG expansions have not been added yet.

I'd like to help with it if that's possible.

Is this repository dead?

Title speaks for itself. Will the repository be updated as new cards come up? I found some that are missing.

Would it make sense to write a crawler for this kind of stuff so maintenance would be easy?

Experiencing an error with the description of the card.

If i try to filter through the json file by checking the description with and indexOf it says Uncaught TypeError: Cannot read property 'indexOf' of undefined, tried using some other functions on the description and it gives me the same error.

In all-collectables, it does not include nerfs

Molten Giant is set to 20 mana, Big Game Hunter is at 3 mana etc...
Call of the wild is at 8 mana, Rockbighter weapon is get to 1 mana etc...

all-collectibles.json missing promo cards

Elite Tauren Chieftain and Gelbin Mekkatorque from the Promo set are missing. Might be missing in other files as well, haven't checked.

Also a few cards start their description with "[x]" for some reason (like Arcane Giant), not sure if intended?

type / category

Wanted to write a little tool for myself to use. Came across this data base of cards ( thank you for saving me a bunch of work with this). I came across an onconsistency: Up to wrath of the old gods, there was a "type", which then seemngly was replaced by "category". any reason for it?

`npm` module has not been updated

The missing comma fix has not yet been added to the npm module. As a consequence, requiring hearthstone-db results in an error:

wtog: wtog.cards
^^^^
SyntaxError: Unexpected identifier
at exports.runInThisContext (vm.js:53:16)
at Module._compile (module.js:374:25)
at Object.Module._extensions..js (module.js:417:10)
at Module.load (module.js:344:32)
at Function.Module._load (module.js:301:12)
at Module.require (module.js:354:17)
at require (internal/module.js:12:17)
at repl:1:11
at REPLServer.defaultEval (repl.js:252:27)
at bound (domain.js:287:14)

'class' and 'type' are both reserved words in Rails

Having columns called class and type in Ruby on Rails causes issues. Suggest renaming these to hero and category respectively to help compatibility.

Naxx secrets have category "secret"

Naxx secrets are inconsistient with rest of db.

<b> tags in descriptions

I noticed some cards have <b> tags in their descriptions, for keywords like battlecry, while many others doesn't. Only expert and gadgetzan cards seems to have them. Not sure if they should be included or not, but it's a problem with consistency.

Missing Ragnaros as hero

Correct me if I'm wrong, but shouldn't Ragnaros as a hero also be included as card?

Since uncollectible Jaraxxus as a hero is included, it makes sense for the same for Rag. Also, I'm not sure if there are any others missing. Rag is the only one I came across.

Empty `effect_list` and a question about more detailed data

I've a couple questions.

I notice that many of the effect_list fields are empty. Is this a bug, WIP or something I'm missing?

It might be interesting to consider with a more structured format. For example instead of "Battlecry: Deal 1 damage to a random enemy." it becomes something like:

{
    "type": "battlecry",
    "action": {
        "type": "damage",
        "target": {
            "class": "enemy",
            "selection": "random"
        },
        value: 1
    }
}

Doing this manually would be a lot of work. It could be semi-automated then manually corrected for the weird cards. I'm willing to help.

Having a data-structure like this would make simulations easier - the only current example I can think of is the Yogg-Saron Simulator which only applies spells and stores spells as javascript.

'image' param name is misleading

I'd consider renaming the image parameter to image_url to better convey the contents.