pear2 / services_linkback Goto Github PK

$php examples/cli-client.php http://www.bogo/tagebuch/ssl-client-certificates.htm http://werxltd.com/wp/2010/09/28/secure-client-authentication-with-php-cert-auth/

Sending pingback from http://www.bogo/tagebuch/ssl-client-certificates.htm to http://werxltd.com/wp/2010/09/28/secure-client-authentication-with-php-cert-auth/
PHP Warning: include_once(PEAR/Error.php): failed to open stream: No such file or directory in /home/cweiske/Dev/pear/pear2/Services_Pingback/examples/cli-client.php on line 13
PHP Stack trace:
PHP 1. PEAR_Exception->__toString() /usr/share/php/PEAR/Exception.php:0
PHP 2. PEAR_Exception->toText() /usr/share/php/PEAR/Exception.php:320
PHP 3. PEAR_Exception->getCauseMessage() /usr/share/php/PEAR/Exception.php:380
PHP 4. class_exists() /usr/share/php/PEAR/Exception.php:255
PHP 5. __autoload() /usr/share/php/PEAR/Exception.php:255
PHP Warning: include_once(): Failed opening 'PEAR/Error.php' for inclusion (include_path='.:/usr/share/php:/usr/share/pear:/home/cweiske/Dev/pear/pear2/Services_Pingback/examples/../src/') in /home/cweiske/Dev/pear/pear2/Services_Pingback/examples/cli-client.php on line 13
PHP Stack trace:
PHP 1. PEAR_Exception->__toString() /usr/share/php/PEAR/Exception.php:0
PHP 2. PEAR_Exception->toText() /usr/share/php/PEAR/Exception.php:320
PHP 3. PEAR_Exception->getCauseMessage() /usr/share/php/PEAR/Exception.php:380
PHP 4. class_exists() /usr/share/php/PEAR/Exception.php:255
PHP 5. __autoload() /usr/share/php/PEAR/Exception.php:255
PHP Fatal error: Uncaught HTTP_Request2_MessageException: Malformed response: ��
thrown in /usr/share/php/HTTP/Request2/Response.php on line 238

Can't use CDATA?

https://github.com/pear2/Services_Pingback2/blob/master/src/PEAR2/Services/Pingback2/Client.php#L153-L170

HTTP_Request2 should be injected

https://github.com/pear2/Services_Pingback2/blob/master/src/PEAR2/Services/Pingback2/Client.php#L56

add use statement for HTTP_Request2

https://github.com/pear2/Services_Pingback2/blob/master/src/PEAR2/Services/Pingback2/Client.php#L56

(So you can skip the \ each time.)

Maybe Net_URL2

https://github.com/pear2/Services_Pingback2/blob/master/src/PEAR2/Services/Pingback2/Client.php#L105

Weird mix of PHP4 and PHP5.3 namespaces

https://github.com/pear2/Services_Pingback2/blob/master/src/PEAR2/Services/Pingback2/Response/Ping.php#L24

This seems to happen in all sub-classes. Not sure why you didn't namespace all the way.

Version is wrong

https://github.com/pear2/Services_Pingback2/blob/master/src/PEAR2/Services/Pingback2/Response/Ping.php#L5

input

https://github.com/pear2/Services_Pingback2/blob/master/src/PEAR2/Services/Pingback2/Server.php#L59

Would make this php://input by default but allow override so you can write an actual unit test for it.

type-hinting

https://github.com/pear2/Services_Pingback2/blob/master/src/PEAR2/Services/Pingback2/Server.php#L149
https://github.com/pear2/Services_Pingback2/blob/master/src/PEAR2/Services/Pingback2/Server.php#L162

If you validated the callback earlier, you could avoid these:
https://github.com/pear2/Services_Pingback2/blob/master/src/PEAR2/Services/Pingback2/Server.php#L261
https://github.com/pear2/Services_Pingback2/blob/master/src/PEAR2/Services/Pingback2/Server.php#L233
https://github.com/pear2/Services_Pingback2/blob/master/src/PEAR2/Services/Pingback2/Server.php#L206

header()

https://github.com/pear2/Services_Pingback2/blob/master/src/PEAR2/Services/Pingback2/Server.php#L137

Not the best idea, IMHO since this doesn't allow me to use your code within my own framework who may take care of this. :) Also, imagine people use another charset (for whatever reason, etc.).

This does not exist by default.

https://netzpolitik.org has:

<link rel="pingback" href="xmlrpc.php"/>